Unable to swallow Konsole on Plasma about pidswallow HOT 10 CLOSED

I'm not 100% on this but I think we can short , (window ID will increase) from parent to child. I am going to try that today and have a look. Sorry my time zone is different.

from pidswallow.

fixed on: a50ec46

from pidswallow.

Here's a video of some quick tests I did

Edit: Running latest (b931a77) with $TERMINAL as alacritty (that's why alacritty works)
Edit: XFCE produces the same weird window for xfce4-terminal:

Damn I got Rick rolled!

from pidswallow.

Sorry about that ;)

from pidswallow.

Same issue with xfce4-terminal on XFCE. Not sure how to deal with this.

from pidswallow.

Looks like I didn't test well enough yesterday...

from pidswallow.

Here's a video of some quick tests I did

Edit: Running latest (b931a77) with $TERMINAL as alacritty (that's why alacritty works)
Edit: XFCE produces the same weird window for xfce4-terminal:

from pidswallow.

Okay I figured something out. Everytime I tested, the "real" konsole window was the lowest number WID from xdotool search. In bspwm, this one is always the first, but in Plasma, it's usually the last one instead (no clue why!)
I think we're either gonna have to sort the WIDS by value and use the lowest one or check every WID for a real mapped window and use the one that is.

from pidswallow.

https://0x0.st/ixvY.patch worked for Konsole/Plasma but not for XFCE. I think we're gonna have to check each individually. I wonder if there's any xdotool command for that.

from pidswallow.

I feel so stupid now...

       --onlyvisible
          Show only visible windows in the results. This means ones with
          map state IsViewable.

Btw: Sorry for the possible spam. I just realized I've been replying to myself a lot and I could have done all these tests in one go and put the results later.

from pidswallow.