litone01 / pe Goto Github PK

1. Steps to reproduce

Dog with ID 4 is born at 2021-01-01, and it can enroll into the prorgam with ID 13 with session time of 1900-01-01 that is before its birth time. This cannot happen in reality and is not desirable for users.

command: enrol d/4 p/13

2. Expected:

enrol command should not allow a dog with date of birth later than session time to enrol.

Actual:

enrol command allows a dog with date of birth later than session time to enrol.

3. Screenshots
   Before:

After:

1. Steps to reproduce

add program n/test3 t/averylongtaggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggend

This case should be caught and handled properly. This was marked as medium because this bug can affect many other commands that involve adding or editing tag, such as add dog, add owner and all the edit commands.

2. Expected:

tag which is too long should be prevented from being added or UI needs to be adjusted for displaying the tag name fully.

Actual:

long tag is accepted and it is not displayed completely.

3. Screenshots
   Before:

After:

1. Issue:
   It should not be EnrolDropCommandParser in the sequence diagram, but DropCommandParser instead. I am a little bit confused over which one is correct because both are used in the content.
2. Justify:

This is a typo and inconsistency between content and diagram.

3. Screenshot
   content 1 :
   

diagram:

content 2:

1. Steps to reproduce
   add program n/another very long nameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee

This case should be caught and handled properly. I marked this as medium because this bug can affect many other commands that involve adding or editing the name attribute, such as add dog, add owner, and all the edit commands.

2. Expected:

name should be displayed fully or certain measures given to prevent user from creating such a long name that cannot be completely shown.

Actual:

long name accepted and incomplete display

3. Screenshots
   Before:

After:

1. Steps to reproduce

edit dog 2 b/golden retriever and testtttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt

This case should be caught and handled properly. This was marked as low instead of medium because this bug can affect less commands as compared to the issue with Name and Tag. Other commands invovled can be add dog.

2. Expected:

breed which is too long should be prevented from being added or UI needs to be adjusted for displaying the breed name fully.

Actual:

long breed is accepted and it is not displayed completely.

3. Screenshots
   Before:

After:

1. Issue:
   In 1a2, it says 'User supplies correct date.'
   and next line, it says 'Steps 1a1-1a2 are repeated until the command entered is correct.'

1a2 should be User supplies new date.

2. Justify:

if 1a2 is user supplies correct date, then the next line is automatically correct. Or rather, what happens if user still gives a wrong or invalid date? This is not handled in the current use case.

3. Screenshot

1. Issue and justify:

in 1a, it says 'The given command/format is invalid.' and error message will be shown to user.

However, since help command does not take in any argument, it is hard to find an example when error message is shown. Moreover, point 1 says user has entered 'help' command, so it cannot be a case where the command word is misspelled.

Thus, the logic of this use case may be wrong.

2. Screenshot
   

1. Steps to reproduce

command found in UG page 10 example,
add dog n/Oreo b/JackRussell Terrier d/2-02-2020 s/Female o/1 t/shy t/docile

it is located here:

2. Expected:

the dog can be added successfully given the example.

Actual:

error message is shown and invalid date of birth is provided. Command is working as intended or expected.

3. Screenshots
   Before:

After:

1.Issue and justify:
in 1a, it says ‘The given command/format is invalid.’ and error message will be shown to user.

However, since exit command does not take in any argument, it is hard to find an example when error message is shown. Moreover, point 1 says user has entered ‘exit’ command, so it cannot be a case where the command word is misspelled.

Thus, the logic of this use case may be wrong.

2. Screenshot: