lifs-tools / jmztab-m Goto Github PK
View Code? Open in Web Editor NEWReference implementation for mzTab-M 2.0 for metabolomics
Home Page: https://lifs-tools.github.io/jmzTab-m/
License: Apache License 2.0
Reference implementation for mzTab-M 2.0 for metabolomics
Home Page: https://lifs-tools.github.io/jmzTab-m/
License: Apache License 2.0
Hi,
On newer Java's (here. openjdk 10.0.1) I get a java.lang.NoClassDefFoundError: javax/xml/bind/ValidationException. This is because newer java (since 1.9) have removed them from
the ClassPath [1]. Hence, a new dependency has to be added explicitly.
PR coming.
Yours,
Steffen
Hi, does the validator capture if e.g. in the SML we have four ambiguous smiles A|B|C|D
but there are three ambiguous InChIs X|Y|Z
?
For now this is just a question, but if the answer is no, it is an issue ;-)
The stock templates used by swagger-codegen currently have some shortcomings. We should add testcases to validate and improve the JSON serialization and deserialization in R.
Hi, the web app is uber-cool, but I want a command-line validator.
I am sure it is simple to java -jar ... myfile.mzTab
somehow,
but it would save my soul if README.adoc
has a cut&past'able example.
Yours, Steffen
A name for each study variable (experimental condition or factor), to serve as a list of the study variables that MUST be reported in the following tables. For software that does not capture study variables, a single study variable MUST be reported, linking to all assays. This single study variable MUST have the identifier โundefinedโ.
Right now, the mzTabWriter implementation will skip any missing values, so it may be possible to write
an mzTab file, that is not valid according to the specification.
The current validator runs off of the parser, which requires a written file / string in the first place.
As a first step, one could serialize the file to String, the run the parser on it and cancel writing if any issues are reported (printing the errors or alternatively, returning the error list).
The Bean validation is currently not fully up to the task, apart from performing checks for null values and also not linked into the error reporting system of the parser.
retention time fields have been extended to hold the unit (seconds) in their name. HUPO-PSI/mzTab#77
This requires adaptation of the
In CCMS-UCSD/GNPS_Workflows#85 it is reported that the mzTab-M example files use index instead of scan to reference the original ms scans from the linked mzML files.
This needs to be fixed in the example files, but also, the validator should check these formats. This is not always possible if the scan_id type is not defined. We might need to define a default for that in the standard, unless "scan" is already the default fallback as it seems from those examples. If a cv term for the format is given, the validator should check that references follow this format.
However, without access to the original mzML files, the validator can not actually cross-check that these scan ids (apart from scan number, which should work always with TPP style mzMLs) actually exist and are accessible. The latter is currently out of scope for the validator but could be added in the future to simplify creating a complete submission.
The SEP ontology in OLS uses term id's with a lower-case prefix of sep: ...
Initially, that seemed to be the culprit for term resolution, but it turned out that actually, the default semantic mapping file does not know of SEP. If added, the validation succeeds. See the second comment on why SEP should non-the-less be left out of the mapping file.
As seen during the hangout, in some cases the file upload "Durchsuchen" is not visible,
and/or not responding to user clicks. Yours, Steffen
Some of the array types in the current class diagram https://lifs-tools.github.io/jmzTab-m/1.0.5/apidocs/resources/apidocs/mzTab-M-object-model-small.png are incorrect.
A new one needs to be prepared to reflect the correct member types.
Pull request HUPO-PSI/mzTab#76
There needs to be a test to check, that reading and writing a file produces the sample result, as the original input file.
We may have to exclude the following, though: Comments, order of elements, unless specified in the standard. Encoding of optional columns (numeric vs string).
Hi, with
openjdk version "10.0.2" 2018-07-17
OpenJDK Runtime Environment (build 10.0.2+13-Ubuntu-1ubuntu0.18.04.1)
OpenJDK 64-Bit Server VM (build 10.0.2+13-Ubuntu-1ubuntu0.18.04.1, mixed mode)
I get a
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on project jmztabm-api: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.: NullPointerException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on project jmztabm-api: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
...
Caused by: java.lang.NullPointerException
at org.apache.maven.surefire.shade.org.apache.commons.lang3.SystemUtils.isJavaVersionAtLeast (SystemUtils.java:1626)
at org.apache.maven.plugin.surefire.AbstractSurefireMojo.getEffectiveJvm (AbstractSurefireMojo.java:2107)
...
This is reported in https://issues.apache.org/jira/browse/SUREFIRE-1439
and fixed in https://blog.soebes.de/blog/2018/03/06/apache-maven-surefire-plugin-version-2-dot-21-released/.
PR coming.
Yours, Steffen
This seems to be
projectlombok/lombok#1572
So updating to 1.16.22 helps. PR coming ...
Yours, Steffen
The content of README.md is currently not available from within the Maven site at https://lifs-tools.github.io/jmzTab-m
It should be included as "Overview".
This could output versions for different components,
git commit hash etc. Yours, Steffen
Column order should be fixed, as in the column definitions.
Validator should output an error if column order is not as expected.
study_variables[1-n]-assay_refs is supposed to be bar separated, but currently a comma separated values are parsed correctly instead.
Hi, I am getting
Begin check mztab file: /vol/R/BioC/devel/xcms/R/faahKO.mzTab
There exist errors in the metadata section or protein/peptide/small_molecule/small_molecule_feature/small_molecule_evidence header section! Validation will stop, and ignore data table check!
No errors in file:/vol/R/BioC/devel/xcms/R/faahKO.mzTab file!
There were errors while processing your file, please check the output for details!
Finish!
Only if I -level Warn
then I see
[Warn-2041] line 88: The metadata section does not contain a small_molecule-identification_reliability parameter definition.
. Note that https://github.com/HUPO-PSI/mzTab/blob/master/specification_document/1_1_draft_specs/mzTab_format_specification_1_1-M_draft.adoc#6252-small_molecule-identification_reliability says mandatory=False
.
Yours, Steffen
This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
These updates are currently rate-limited. Click on a checkbox below to force their creation now.
org.slf4j:jul-to-slf4j
, org.slf4j:slf4j-simple
, org.slf4j:slf4j-api
)org.springframework:spring-web
, org.springframework:spring-test
, org.springframework:spring-expression
, org.springframework:spring-context-support
, org.springframework:spring-context
, org.springframework:spring-beans
, org.springframework:spring-aop
, org.springframework:spring-core
)com.fasterxml.jackson.datatype:jackson-datatype-joda
, com.fasterxml.jackson.dataformat:jackson-dataformat-xml
, com.fasterxml.jackson.core:jackson-annotations
, com.fasterxml.jackson.core:jackson-core
)org.glassfish.jersey.media:jersey-media-json-jackson
, org.glassfish.jersey.media:jersey-media-multipart
, org.glassfish.jersey.core:jersey-client
)ch.qos.logback:logback-classic
, ch.qos.logback:logback-core
)org.hibernate.validator:hibernate-validator-annotation-processor
, org.hibernate.validator:hibernate-validator
)org.glassfish.jersey.media:jersey-media-json-jackson
, org.glassfish.jersey.media:jersey-media-multipart
, org.glassfish.jersey.core:jersey-client
)org.springframework:spring-web
, org.springframework:spring-test
, org.springframework:spring-expression
, org.springframework:spring-context-support
, org.springframework:spring-context
, org.springframework:spring-beans
, org.springframework:spring-aop
, org.springframework:spring-core
)These updates have all been created already. Click a checkbox below to force a retry/rebase of any.
org.hibernate.validator:hibernate-validator-annotation-processor
, org.hibernate.validator:hibernate-validator
)cli/Dockerfile
openjdk 11-jre-slim
.github/workflows/maven.yml
actions/checkout v2
actions/setup-java v2
actions/cache v1
actions/cache v1
EnricoMi/publish-unit-test-result-action v1
api/pom.xml
io.swagger:swagger-codegen-maven-plugin 2.4.29
org.seleniumhq.selenium:selenium-java 2.53.1
com.opera:operadriver 1.5
cli/pom.xml
io/pom.xml
pom.xml
com.github.wumpz:diffutils 2.2
de.danielbechler:java-object-diff 0.95
com.github.ferstl:depgraph-maven-plugin 4.0.2
org.apache.maven.plugins:maven-site-plugin 3.12.1
org.asciidoctor:asciidoctor-maven-plugin 1.6.0
org.apache.maven.plugins:maven-clean-plugin 3.2.0
org.apache.maven.plugins:maven-site-plugin 3.12.1
org.apache.maven.plugins:maven-resources-plugin 3.3.0
org.apache.maven.plugins:maven-enforcer-plugin 3.1.0
org.owasp:dependency-check-maven 7.3.2
org.codehaus.mojo:buildnumber-maven-plugin 3.0.0
org.apache.maven.plugins:maven-install-plugin 3.1.0
org.apache.maven.plugins:maven-deploy-plugin 3.0.0
org.apache.maven.plugins:maven-dependency-plugin 3.3.0
org.apache.maven.plugins:maven-jar-plugin 3.3.0
org.apache.maven.plugins:maven-assembly-plugin 3.4.2
org.apache.maven.plugins:maven-javadoc-plugin 3.4.1
org.apache.maven.plugins:maven-compiler-plugin 3.10.1
org.apache.maven.plugins:maven-surefire-plugin 3.0.0-M7
org.apache.maven.plugins:maven-failsafe-plugin 3.0.0-M7
org.apache.maven.plugins:maven-shade-plugin 3.4.1
org.apache.maven.plugins:maven-source-plugin 3.2.1
org.jacoco:jacoco-maven-plugin 0.8.10
com.google.cloud.tools:jib-maven-plugin 2.8.0
org.projectlombok:lombok 1.18.24
junit:junit 4.13.2
org.hamcrest:hamcrest-library 2.2
org.hamcrest:hamcrest-core 2.2
javax.validation:validation-api 2.0.1.Final
org.slf4j:slf4j-api 2.0.6
org.slf4j:slf4j-simple 2.0.6
org.slf4j:jul-to-slf4j 2.0.6
io.swagger:swagger-annotations 1.6.9
org.glassfish.jersey.core:jersey-client 2.37
org.glassfish.jersey.media:jersey-media-multipart 2.37
org.glassfish.jersey.media:jersey-media-json-jackson 2.37
com.fasterxml.jackson.core:jackson-core 2.14.1
com.fasterxml.jackson.core:jackson-annotations 2.14.1
com.fasterxml.jackson.core:jackson-databind 2.14.1
com.fasterxml.jackson.dataformat:jackson-dataformat-xml 2.14.1
com.fasterxml.jackson.datatype:jackson-datatype-joda 2.14.1
com.fasterxml.jackson.dataformat:jackson-dataformat-csv 2.14.1
joda-time:joda-time 2.12.1
com.brsanthu:migbase64 2.2
io.github.swagger2markup:swagger2markup 1.3.7
commons-cli:commons-cli 1.5.0
javax.xml.bind:jaxb-api 2.3.1
com.sun.xml.bind:jaxb-core 2.3.0.1
com.sun.xml.bind:jaxb-impl 2.3.7
javax.annotation:javax.annotation-api 1.3.2
com.sun.activation:javax.activation 1.2.0
org.apache.maven.plugins:maven-site-plugin 3.8.2
org.apache.maven.plugins:maven-project-info-reports-plugin 3.0.0
org.apache.maven.plugins:maven-gpg-plugin 1.6
org.sonatype.plugins:nexus-staging-maven-plugin 1.6.8
org.hibernate.validator:hibernate-validator 6.0.22.Final
org.hibernate.validator:hibernate-validator-annotation-processor 6.0.22.Final
org.glassfish:javax.el 3.0.1-b12
commons-jxpath:commons-jxpath 1.3
uk.ac.ebi.pride.utilities:ols-client 2.11
org.springframework:spring-core 5.3.24
ch.qos.logback:logback-core 1.4.5
ch.qos.logback:logback-classic 1.4.5
org.springframework:spring-aop 5.3.24
org.springframework:spring-beans 5.3.24
org.springframework:spring-context 5.3.24
org.springframework:spring-context-support 5.3.24
org.springframework:spring-expression 5.3.24
org.springframework:spring-test 5.3.24
org.springframework:spring-web 5.3.24
org.mockito:mockito-core 3.6.28
test-utils/pom.xml
validation/pom.xml
org.apache.cxf:cxf-xjc-plugin 3.3.2
.mvn/wrapper/maven-wrapper.properties
maven 3.5.2
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.