Add get/set functions for ScmpFilterAttr about libseccomp-rs HOT 8 CLOSED

We need to decide the function name carefully to avoid under score(_) hell.

from libseccomp-rs.

Looks like there's no perfect solution either, so do what you want.

My idea would be to directly map the C constants like "SCMP_FLTATR_*".strip("^SCMP_FLTATR_").to_lower():

get_act_default()
{get,set}_act_badarch()
{get,set}_ctl_nnp()
{get,set}_ctl_tsync()
{get,set}_api_tskip()
{get,set}_ctl_log()
{get,set}_ctl_ssb()
{get,set}_ctl_optimize()
{get,set}_api_sysrawrc()

from libseccomp-rs.

IMHO we should keep it as deprecated alias even if we bump to 0.3.0.

Generally I think it is the best to just keep deprecated stuff unless it is a security risk or blocks future development.
Good examples would be
https://mesonbuild.com/Reference-manual_builtin_meson.html
https://docs.rs/clap/latest/clap/struct.Arg.html
https://doc.rust-lang.org/std/index.html

from libseccomp-rs.

I'd like to change the name of {get,set}_no_new_privs_bit() to {get,set}_nnp.
In case of {get,set}_ssb, If we unify the functions to full name like {get,set}_no_new_privs, we have to define {get,set}_speculative_store_bypass that is a very long name (so is get,set}_no_new_privs_bit()).
Hence, I propose the new function names as follows:

get_default_action()
{get,set}_badarch_action()
{get,set}_nnp()
{get,set}_log()
{get,set}_ssb()
{get,set}_optimize()
{get,set}_rawrc()
{get,set}_tskip()
{get,set}_tsync()

@rusty-snake Could you give me your thoughts?

Ref. https://man7.org/linux/man-pages/man3/seccomp_attr_set.3.html

from libseccomp-rs.

It's nice for me. Thank you.

from libseccomp-rs.

@rusty-snake
Regarding rename of {get,set}_no_new_privs_bit, Which would be better, we make the current function deprecated or bump the version to 0.3.0 without deprecated to avoid many deprecated functions?

from libseccomp-rs.

Thank you for your suggestion and the information.
I thought that I'd like to avoid generating many deprecated functions , but I agree with your thoughts.
I'll create a PR to rename it with making it deprecated.
Wow, clap has many deprecated functions :)

from libseccomp-rs.

I'll decide whether we should support {get,set}_api_tskip() after seccomp/libseccomp#368 (comment) is solved.

from libseccomp-rs.