Code Monkey home page Code Monkey logo

Comments (5)

rusty-snake avatar rusty-snake commented on May 20, 2024 1

@ManaSugi since you have more knowledge with tarpaulin, I would leave it to you to replace the tarpaulin action.

from libseccomp-rs.

ManaSugi avatar ManaSugi commented on May 20, 2024

@rusty-snake Thank you for the information!

As you mentioned, actions-rs/toolchain does not seem to be maintained for a long time, so we may have to start considering
an alternative action, just using rustup or stuff like that in order to avoid future problems.
On the other hand, the actions-rs/tarpaulin seems to be maintained actively, so I hope the mainteiner will handle this problem.
Could you create the issue for actions-rs/tarpaulin in order to tell it to the maintainers when you have time?

from libseccomp-rs.

rusty-snake avatar rusty-snake commented on May 20, 2024

cargo-tarpaulin itself is maintained. However we use it through the actions-rs/tarpaulin action.
It has three commits in the last two years, but if you wait two days (timezone ...) it will have zero commits in the last two years 😀 .

actions-rs has one public member, who has a lot activity in 2019/2020 and very less in 2021/2022.

For toolchain we could use https://github.com/marketplace/actions/rustup-toolchain-install.

For tarpaulin we need to write our own bash/python script, call it directly or find an other action. grcov does not seem to have an action either.

from libseccomp-rs.

ManaSugi avatar ManaSugi commented on May 20, 2024

cargo-tarpaulin itself is maintained. However we use it through the actions-rs/tarpaulin action.

Oh, you're right.

For toolchain we could use https://github.com/marketplace/actions/rustup-toolchain-install.

That's good an alterative action! We could use it instead of actions-rs/toolchain.
Regarding actions-rs/tarpaulin, I think we might as well write our own bash script in build-test.yaml directly. That won't be so many lines. In addition, It would be nice to switch to source-based coverage of cargo tarpaulin in the future in order to get more accurate coverage when it is available.
Ref. https://github.com/xd009642/tarpaulin/issues?q=is%3Aissue+is%3Aopen+%23549+

from libseccomp-rs.

ManaSugi avatar ManaSugi commented on May 20, 2024

This issue has been solved by the following commits.
5dcd06c
1748422

So, I can close this. Thanks! @rusty-snake

from libseccomp-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.