Ideas for a higher level notification API about libseccomp-rs HOT 6 OPEN

Hi, I've been working on a similar functionality and since I'm depending on tokio I've published it as an external crate: https://github.com/not-jan/seccomp-stream

Maybe you can take some inspiration / ideas from my implementation. I ended up implementing a non-blocking version as opposed to the normal blocking version by utilizing epoll.

If epoll signals that the fd is readable it guarantees that the ioctl won't block. This way you can also react to the fd closing because epoll will send a EPOLLHUP event.

Most of the actual epoll implementation is hidden within tokio / mio so it might not be super easy to extract this.

from libseccomp-rs.

Note: io_safety for ScmpFd.

from libseccomp-rs.

The correct type for ScmpFd would be BorrowedFd<'static> I think. Even if 'static is wrong, it is a BorrowedFd with a long lifetime.

from libseccomp-rs.

The correct type for ScmpFd would be BorrowedFd<'static> I think. Even if 'static is wrong, it is a BorrowedFd with a long lifetime.

It means that for safety you want to prevent users from accidentally closing the fd, isn't it?

from libseccomp-rs.

It we use OwnedFd it will be closed when OwnedFd gets dropped. Which would be the wrong think for a shared FD.

from libseccomp-rs.

Okay, is it necessary for us to make the lifetime 'static?
I think there seems to be no problem even if the lifetime is same as struct Rotify.

from libseccomp-rs.