lenitrous / anime-themes Goto Github PK
View Code? Open in Web Editor NEWA wrapper for interacting around https://themes.moe
License: MIT License
A wrapper for interacting around https://themes.moe
License: MIT License
Hi! ๐ I wrote tslint-to-eslint-config and noticed from its npm dependents report that this package has it as a devDependency
. Was that intentional? You shouldn't need to keep it in the package.json
after using it once.
I can send a PR to remove it if you'd like ๐
In theme.ts i found that your regex to extract if the theme is an opening/ending the number and version is:
/src/theme.ts
const parts = data.themeType.match(/(OP|ED)(\d)?( V(\d))?/);
Although some anime haave more than 9 themes thus having a number with more than 1 \d
example: https://themes.moe/api/themes/269 -> Ending 28 ->
{
"themeType": "ED28 V2",
"themeName": "Haruka Kanata",
"mirror": {
"mirrorURL": "https://animethemes.moe/video/Bleach-ED28v2.webm",
"priority": 3,
"notes": ""
}
}
this is easily fixable by changing it to:
const parts = data.themeType.match(/(OP|ED)(\d+)?( V(\d+))?/);
by adding the + after /d you say it should find 1 or more digits
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.