lenitrous / anime-themes Goto Github PK

Hi! 👋 I wrote tslint-to-eslint-config and noticed from its npm dependents report that this package has it as a devDependency. Was that intentional? You shouldn't need to keep it in the package.json after using it once.

I can send a PR to remove it if you'd like 😄

In theme.ts i found that your regex to extract if the theme is an opening/ending the number and version is:

/src/theme.ts

const parts = data.themeType.match(/(OP|ED)(\d)?( V(\d))?/);

Although some anime haave more than 9 themes thus having a number with more than 1 \d
example: https://themes.moe/api/themes/269 -> Ending 28 ->

{
    "themeType": "ED28 V2",
    "themeName": "Haruka Kanata",
    "mirror": {
      "mirrorURL": "https://animethemes.moe/video/Bleach-ED28v2.webm",
      "priority": 3,
      "notes": ""
    }
}

this is easily fixable by changing it to:

const parts = data.themeType.match(/(OP|ED)(\d+)?( V(\d+))?/);

by adding the + after /d you say it should find 1 or more digits