Code Monkey home page Code Monkey logo

ceramics's People

Contributors

aemande123 avatar bytegm avatar emirhangg avatar knightminer avatar mindy15963 avatar timeconqueror avatar yanisbft avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

ceramics's Issues

Clay bucket does not fill up Barrels

As the name says this buckets are not putting water into the barrel it shows that liquid is in but right click says that its empty.
Im suing v1.3.3b for 1.12.2 MC

Game wont start if porcelain or barrel are = false in config file

Im trying to use this mod because the buckets and armor sound really cool. I used the config file to disable the barrels and the decorative blocks but the game wont load. Config file and log below

enabled {
# Enables the clay armor, an early game alternative to leather [default: true]
B:armor=true

# Enables the clay barrel, a liquid tank that can be expanded upwards [default: true]
B:barrel=false

# Enables the clay bucket, an alternative to the iron bucket that breaks from hot liquids [default: true]
B:bucket=true

# Enables porcelain, a whiter clay that produces true colors when dyed [default: true]
B:porcelain=false

# Enables the clay shears, faster than iron shears but less duribility [default: true]
B:shears=true

}

---- Minecraft Crash Report ----

WARNING: coremods are present:
BetterFoliageLoader (BetterFoliage-MC1.10-2.1.0.jar)
LoadingPlugin (Quark-r1.0-56.jar)
LoadingPlugin (Bloodmoon-MC1.9.4-1.4.1.jar)
AppleCore (AppleCore-mc1.10.2-2.0.1.jar)
LoadingPlugin (ChunkAnimator-MC1.9.4-1.2.jar)
ForgelinPlugin (Forgelin-1.0.5.jar)
dsurroundcore_unofficial (DynamicSurroundingsUnofficial-1.10.2-3.0.6.1BETA.jar)
Contact their authors BEFORE contacting forge

// I let you down. Sorry :(

Time: 17/10/16 9:44 PM
Description: Initializing game

java.lang.IllegalArgumentException: Block registered to block color handler cannot be null!
at net.minecraft.client.renderer.color.BlockColors.func_186722_a(BlockColors.java:174)
at knightminer.ceramics.ClientProxy.init(ClientProxy.java:81)
at knightminer.ceramics.Ceramics.init(Ceramics.java:293)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

[MC 1.10.2] Faucet missing?

I can't seem to be able to find the porcelain faucet in the creative menu. Even with just Ceramics 1.1.6b in the mod folder it doesn't show up. Fresh JAR, same issue. New instance, same issue. And I can't see anything in the log about the mod itself. Only something about dependency on TiC?

Implement recipe return

Hi there, I've noticed that your buckets don't default to being returned when used in recipes like vanilla buckets do. It seems like that might be a nice feature, it could even handle the cold fluids return items thing vs hot fluids do not which seems like it would be aesthetic.

fluid gets stuck in dead branches of fluid channels

if you arrange channels in a tree when a container fills up fluid will get stuck on that branch so the last container wont fill up. this can be a problem when multiple fluids are supposed to flow. for example with a tinkers smeltery you dont want a nugget stuck in each casting table preventing the next fluid from flowing. a way to fix it is to make them work like the TE fluiducts.

Client crash w/ Tinker's Con

Hi there - thanks for checking this out, KnightMiner.

Rewally looking forward to using your mod in my 1.11 pack, but I am getting a client crash with Tinker's Construct. Removed TiCon (and the associated mods) and Ceramics loaded fine.

crash log paste
https://pastebin.com/R9bN3PAD

Tough as Nails integration

Would it be possible to to allow the water interfaces on TAN work from your barrels? Right now when I right-click with an empty bottle nothing happens. I would expect it would give me a dirty water bottle and remove a bucket's worth from the barrel (or a third?)
It would also be cool if you could drink directly from the barrel.

Unfired Porcelain Block Untextured w/ Creative Pick Block or TheOneProbe

If I craft an unfired porcelain block (ceramics:clay_soft:0), it looks as it should. If I place that place into the world, it appears as it should visually and I get the correct drop when silk touching it, but TheOneProbe show the block's icon as an untextured block when looking at it and if I pick-block it in creative, I actually get that untextured block (ceramics:clay_soft:4).

Filled Clay Buckets cannot be removed from AE2's ME Systems

Describe the bug
A player reported to me that they couldn't retrieve a Clay Water Bucket from their ME system. I tested this and can replicate. I can neither remove the Clay Water Bucket, nor the Clay Hot Spring Water Bucket from my ME system. Empty and Unfired Buckets do not seem to be affected.

I have reported this to the mod author of AE2 as well: AppliedEnergistics/Applied-Energistics-2#4058

To Reproduce
Place a filled clay bucket inside an ME system via terminal
Attempt to retrieve clay bucket from ME system via terminal

Expected behavior
I expect the bucket to be pulled from the ME inventory and placeable within player inventory. However, clicking on the bucket does not do anything. Shift+Click does not work, either.

Environment
We are running a multiplayer server. I have not tested this in singleplayer.

Minecraft Version: 1.12.2
AE2 Version: appliedenergistics2-rv6-stable-6
Ceramics Version: Ceramics-1.12-1.3.7
Forge Version: forge-1.12.2-14.23.5.2838-universal

Barrel / Bucket bug / sync issue

When i try to fill a clay barrel with a clay bucket filled with water, the level of water in the barrel increase but the tank still indicate empty on TOP. When if i log out / log in, the bucket look full but if i try to transfer water in a tank, it doesn't transfer anything and the barrel is empty.

Potential Future Features

This is just an issue to collect some of the suggestions I may add in the future into one place. Nothing on this list is final.

Functional blocks

  • Clay urns: chest like block with limited storage, but a mechanic for urn breaking (like terraria) and early game shulker box.
  • Flower pots, possibly multiple sizes. Needs to support modded flowers.
  • Clay furnace (kiln). Like a blast furnace or a smoker, but for ceramics.
  • Clay pressure plates or other basic redstone components
  • Some form of the faucet which has an on/off state instead of a toggle state, to allow an always draining barrel. Alternatively, somehow allow that to be possible using redstone
  • Golems

Decorative blocks

  • Clay tiles: carpet like block with fancy patterns
  • Something like glazed terracotta, but with porcelain. More consistent colors with the dye color instead of normal glazed mix

no return is not supported for clay bucket

hello i don't know if its issue or i am doing it wrong here is the code i don't want this return an empty bucket but it show error:
recipes.addShapeless(ceramics:clay_bucket:1.noReturn(), [ceramics:clay_bucket.withTag({fluids: {FluidName: "milk_friesian", Amount: 1000}}).onlyWithTag({fluids: {FluidName: "milk_friesian", Amount: 1000}})]);

Feature Request: Add 1.12 Glazed Terracotta

1.12 adds "glazed terracotta" blocks, with bright decorative patterns; these are created by re-firing "stained clay" blocks (now renamed to "terracotta"). I suggest adding support for Glazed Terracotta for barrels and suchlike, possibly by re-firing the standard clay barrels as a parallel to the process for creating the actual glazed terracotta blocks.

  • If you can re-use the resource location for the minecraft textures, this would keep compatibility with texture packs.

Alternate Porcelain Recipe

I adore the aesthetics for porcelain (the tinted hardened clay in vanilla has always bugged me) but the particular recipe you have (clay ball + 2 bone meal per porcelain ball) is a bit steep to anyone who might be inclined to avoid combat.

Maybe something that doesn't involve mob drops? In real life, bisque porcelain is a mixture of kaolinite, feldspar, and flint. Diorite is, among other things comprised of feldspar...

This suggests some possible configurations with technically non-renewable yet readily accessible resources for non-combatants.

[Suggestion] Clay urns, Vases, Chimineas

Suggestions:

  • One thing that would be nice to have here is the ability to make clay urns and vases to hold solid materials in the same way a chest does. The obvious benefit here is that clay urns could have different decorative designs and motifs, could come in different colors, and just would be more appealing.

  • The minecraft flower pots are UGLY. A nice porcelain vase with different colors and decorative designs would be a much better place to put flowers. Smaller ones could hold things like poppies and dandilions while larger vases could hold the bigger flowers like roses.

  • Chimineyas are Mexican fireplaces made of clay. These could act like decorative furnaces. Here is a link to one:

http://chimineasdirect.com/fired-up-designs-43-inch-iron-clad-clay-chiminea?gclid=CjwKEAiA_9nFBRCsurz7y_Px8xoSJAAUqvKCQwHS6i0ExXj1wBCTtxPAEhT3gG2UezYpDN-iYjHbvRoCK1Dw_wcB

https://en.wikipedia.org/wiki/Chimenea

Implementation With My Mod

Hello. I added a cauldron in minecraft with my mod and seems that it does not support the clay bucket. I looked into your ItemClayBucket class, and i wrote a code similiar to yours in interactCauldron in a FillBucketEvent. I have a question. I actually cant get the private methods used to place water in world with the clay bucket. I hope my text is clear. Thanks for reading.
Bye.

Clay Bucket and Milk Clay Bucket

I'm attempting to rename these in my modpack to fit Atum's clay variant (Marl), the water, lava, and whatever that other bucket is rename fine, but the empty bucket and milk bucket I can't seem to get them renamed. I'm assuming its something with my CraftTweaker script and my own infinite stupidity, but I thought I'd bring it up here in-case its something in the localization pull or something that isn't working properly.

image

image

[1.12.2] Clay Bucket Texture Mapping

Heyo!

Currently working on creating texture support in Fanver for the mod, and I came across an issue with the bucket and fluid render. Where the fluid render is not mapping to the base bucket texture correctly and seems to be hardcoded cords. If you see in the image below

image

The texture is being loaded as the lava shape is matching the overlay but is being pushed up out of the base sprite. I believe I have done this correctly if you want the textures to test with I can send them over ๐Ÿ˜„

Thanks!

Can't remove water from Botania Petal Apothecary

Hello!

I am working in Minecraft 1.10.2 with the following mod versions.

Forge 12.18.3.2297
Botania r1.9-341
Ceramics 1.10.2-1.1.6b

Everything works great except that I can't seem to remove water from the petal apothecary with a clay bucket. I can put water in without issue. Just can't remove it.

Thanks!

[Suggestion] non-porcelain faucets/channels

Just faucets and channels to match the undyed clay barrels. It always feels like a thing that's missing, cosmetically, when I'm building with them. Thank you for reading!

[Suggestion] Colored Armor + more

I'd like to suggest adding the ability to dye the armor, like leather.

I'd also like to suggest a simple clay watering can.

As well as the potential addition of Porcelain Clay and Porcelain blocks. The clay can be oredictionatiaried to work with other mods that use porcelain(ex nihilo). The blocks function similar to harden clay but produce truer colors. Porcelain could also be used to create plates, mugs and bowls.

I'm not sure if jaquadro has abandoned Modular Flower Pots/ Garden Stuff but if so and they are willing to allow someone else to take over; their pots would fit in thematically with your mod.

I'd like to suggest more but I don't know what you have planned. I do however actually have real world experience with ceramics if you are in need of real world examples of cool things you can do with clay

Ceramics breaks EnderIO's JEI plugin

Disabling Ceramics solves the issue.

[Client thread/ERROR] [JEI/]: Failed to register mod plugin: class crazypants.enderio.jei.JeiPlugin
java.lang.NullPointerException
at knightminer.ceramics.items.ItemClayBucket.doesBreak(ItemClayBucket.java:237) ~[ItemClayBucket.class:?]
at knightminer.ceramics.library.FluidClayBucketWrapper.setFluid(FluidClayBucketWrapper.java:28) ~[FluidClayBucketWrapper.class:?]
at net.minecraftforge.fluids.capability.wrappers.FluidBucketWrapper.drain(FluidBucketWrapper.java:171) ~[FluidBucketWrapper.class:?]
at crazypants.enderio.jei.TankRecipeCategory.register(TankRecipeCategory.java:115) ~[TankRecipeCategory.class:?]
at crazypants.enderio.jei.JeiPlugin.register(JeiPlugin.java:47) ~[JeiPlugin.class:?]
at mezz.jei.ProxyCommonClient.startJEI(ProxyCommonClient.java:169) [ProxyCommonClient.class:?]
at mezz.jei.ProxyCommonClient.onEntityJoinedWorld(ProxyCommonClient.java:142) [ProxyCommonClient.class:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_759_ProxyCommonClient_onEntityJoinedWorld_EntityJoinWorldEvent.invoke(.dynamic) [?:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:72) [ASMEventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:168) [EventBus.class:?]
at net.minecraft.world.World.func_72838_d(World.java:1129) [aid.class:?]
at net.minecraft.client.multiplayer.WorldClient.func_72838_d(WorldClient.java:196) [bln.class:?]
at net.minecraft.client.Minecraft.func_71353_a(Minecraft.java:2451) [bcx.class:?]
at net.minecraft.client.Minecraft.func_71403_a(Minecraft.java:2359) [bcx.class:?]
at net.minecraft.client.network.NetHandlerPlayClient.func_147282_a(NetHandlerPlayClient.java:276) [bll.class:?]
at net.minecraft.network.play.server.SPacketJoinGame.func_148833_a(SourceFile:76) [gw.class:?]
at net.minecraft.network.play.server.SPacketJoinGame.func_148833_a(SourceFile:13) [gw.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) [fl$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_25]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_25]
at net.minecraft.util.Util.func_181617_a(SourceFile:45) [h.class:?]
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1045) [bcx.class:?]
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:371) [bcx.class:?]
at net.minecraft.client.main.Main.main(SourceFile:124) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_25]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Method.java:483) ~[?:1.8.0_25]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]

[1.12.2] Compact with certain Animania milk

Heya,

i went through some old tickets on both here and the animania github where there was some talk about making the buckets work with animania animals.

If they provide normal milk, the clay buckets work no problem.

However if you try to milk anything with special milk (example: Goat Milk), the bucket doesn't work. I milk them using an iron bucket, place the liquid in the world, and pick it up with the ceramic bucket no problem though. But right clicking the goat itself doesn't give me the milk bucket.

Is this something that could be implemented, and would it be on Ceramics side or Animania?

Other milks are: Holsein, Friesian and Sheep.

Cheers,
SC

Compat issues with Animania's cows

We've encountered an issue that occurs when trying to milk Animania's cows with clay buckets:
Our cows have genders, only female cows give milk, but they all (also children) extend EntityCow. This causes both children and bulls to be milkable.
Our cows also have special milk conditions, which are also ignored by the clay bucket.

So can you make more checks, or is there something we should change about our interact method? Sadly there's no handly interface for milking like for shearing...

[Request] hot fluids whitelist

Originally a request for a creosote clay bucket but now I realize this is available but disabled when hotFluids=false. Is it possible to whitelist specific fluids from being ignored by the hotFluids option?

[1.12.2] Can't remove Porcelain Brick furnace recipe with CT

Ceramics version: 1.3.3b
Forge version: 2548
CraftTweaker version: 4.0.12

Trying to remove the porcelain brick furnace recipe using the following:

furnace.remove(<ceramics:unfired_clay:5>);

But it still stays. I tried the same line with other items (iron ingot, clay bucket, etc) and they all get removed properly. Porcelain Brick is the only one that doesn't.

CraftTweaker log:

[INITIALIZATION][CLIENT][INFO] CraftTweaker: Building registry
[INITIALIZATION][CLIENT][INFO] CraftTweaker: Successfully built item registry
[INITIALIZATION][CLIENT][INFO] Loading scripts
[INITIALIZATION][CLIENT][INFO] [crafttweaker | SIDE_CLIENT]: Loading Script: {[0:crafttweaker]: tinkers.zs}
[POSTINITIALIZATION][CLIENT][INFO] Removing furnace recipes for: <ceramics:unfired_clay:5>
[POSTINITIALIZATION][CLIENT][INFO] 0 recipes removed for: <ceramics:unfired_clay:5>
[POSTINITIALIZATION][CLIENT][INFO] Removing furnace recipes for: <ceramics:clay_bucket>
[POSTINITIALIZATION][CLIENT][INFO] 1 recipes removed for: <ceramics:clay_bucket>
[POSTINITIALIZATION][CLIENT][INFO] Altering WorktableShaped Recipe(s) for <minecraft:crafting_table>
[SERVER_STARTED][CLIENT][INFO] Fixed the RecipeBook

Buckets still picks sand up dispite config, does not break after picking up lava

Running Ceramics-1.12-1.3.5:

Currently have
Allows the clay bucket to pick up sand and gravel, because why not? [default: true]
B:sand=false

Yet bucket is still able todo so.

Also, when the bucket is able to pick up lava it does not break after placing in survival mode.'

Running forge
1.12.2-forge1.12.2-14.23.5.2768

HarvestDropsEvent handler for clay shears throws NPE.

Ceramics version: 1.1.0
Details:
The crash occured when I walked in front of a Botania Mana Spreader with a Tripwire Damaging lens installed. I did not have clay shears in my inventory. I suspect that the NPE was caused by HarvestDropsEvent#harvester being null; according to the comment on that field, null is a valid value.
Crash

[1.12.2] Null Pointer Crash

In Regards to DarkPacks/SevTech-Ages#1815

Hello, just had this report about a crash with the modpack and the usage of a distillation tower from IE Tech but looking the report given it's just a Null Pointer being thrown from Ceramics.

Crash Report: https://pastebin.com/SqFmHVvf
Version Used: 1.12-1.3.3b

If you need more info the user on how the setup is done/usage then you can chatter on the linked issue ๐Ÿ™‚

Thanks!

Issue using clay water buckets with craft tweaker

The way that the the mod sets up the water bucket results in it being very difficult (I won't say impossible though I haven't figured it out) to use these buckets with craft tweaker. I wanted to add a recipe to make Earthworks mud using a clay water bucket and dirt blocks.

Using recipe maker I wound up with an empty clay bucket being used. Using MT hand to manually get the ID this is what came up:

ceramics:clay_bucket.withTag({fluids: {FluidName: "water", Amount: 1000}})

That ID won't work in the script. I haven't tried <ceramics:clay_bucket.withTag({fluids: {FluidName: "water", Amount: 1000}})> but since that isn't how the mod itself pulls up the ID I doubt that would work.

I may try to add the water bucket to ore dictionary to make the water buckets equivalent in recipes but . . . that seems like it would either result in clay buckets being transmuted into iron; or wouldn't give back buckets at all. Both of which are bad options.

Clay armor not baking in 1.12

Mod version 1.3.1, forge 2441: I can't bake any of the clay armor pieces in the minecraft furnace :(
They don't shift-click into the furnace (as if they have no recipe), and JEI shows no uses for them.

Game Crashed when Right-click with armor in my hand to put it on...

Hello, I have a problem with the Fired Clay Armor;
When I right-click whit one pieces of the armor in my hand, the game completely crash and I need to restart the complete Modpack. This armor is needed for my Modpack, where the leather is take a multiple multiple day's to have, so the Fired Clay Armor and unfired Clay Armor is the 2 realy early game in my pack.

I test with a pack with pratically just your mod and couple other utillity mods, like JEI, crafttweaker, etc, and the same problem append.

Minecraft 1.12.2
Ceramics v. 1.12-1.3.3b
Forge 14.23.2.2616
Java: 8 (1.8.0_161-b12 64bit)

Crash Log: https://gist.github.com/Fireztonez/124fc08ec5a5cf38f332533ffa9fd80b

[Suggestion] Early Game Storage

It would be nice to have some kind of Clay Vessels that would function like a Shulker Box, but with less space, for a simple early game storage.

OreDict

Hey

I have a problem with OreDict on your clay buckets in Stoneblock.

Adding:

 <ore:listAlllava>.add(<ceramics:clay_bucket>.withTag({fluids: {FluidName: "lava", Amount: 1000}}));
<ore:listAllwater>.add(<ceramics:clay_bucket>.withTag({fluids: {FluidName: "water", Amount: 1000}}));

Will cause an empty Clay Bucket to have both Ore Dict tags.

forge 2796
Ceramics-1.12-1.3.6.jar

[1.12] Places liquid from a clay bucket makes the bucket become an iron bucket?

I was doing my everyday messing-around-with-mods-in-creative routine, and when I when I was looking at Ceramics features, pouring out liquid made the bucket become iron (only works in Survival, had discovered this because I used /gamemode 0 to test a few things with damage from another mod) and thus Creative will not have this issue). I have tested this with only Ceramics and Forge in a new instance, so it not caused by another mod.

TLDR: Clay buckets with liquid become iron when emptied.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.