Clay Bucket and Milk Clay Bucket about ceramics HOT 4 CLOSED

Honestly, no idea why it would not work, but that is 100% the wrong way to rename an item. Like, sure, CraftTweaker can do it, but a mod such as resource loader with changing the .lang files will be so much more reliable. If I had to guess, the reason is because of the custom logic to make the names work, but it shouldn't be any different than the Forge bucket or most other dynamically named items do.

from ceramics.

That's good to know, just figured I'd check in here and see if I was breaking things somewhere or if this was maybe a known issue. I'm normally a mod dev, not a modpack dev, so kinda learning the ins and outs of all of this, and someone had mentioned it might be on your lang side that it wasn't working.

Regardless, thank you!

from ceramics.

Yeah, I just looked into the code and the way CraftTweaker does renames is attempting to find the lang key from the itemstack and replacing that key, which does not work for the bucket as it uses a formatted lang key. I am skipping overriding one method which overriding might make CraftTweaker's method work, but it still will never beat the designed method.

from ceramics.

Makes sense, thank you so much for your time and advice.

from ceramics.