Code Monkey home page Code Monkey logo

Comments (6)

etherealite avatar etherealite commented on July 17, 2024 1

In my case it happens on any youtube video.

To reproduce:

  • Start playing any video, right click outside the asbplayer drop zone and select absplayer: Language-Learning with subtitles->Load Subtitles.
  • In the Select Subtitles dialogue box, load any subtitle stream into track 1.
  • As the new video is playing, click on a recommended video from the right hand column.
  • Repeat the process of selecting the subtitles for the newly playing video.

Subtitles will now appear on-top of the yomitan pop-up and obscure it from view.

All of this was performed on Brave browser with a clean slate profile:
image

from asbplayer.

etherealite avatar etherealite commented on July 17, 2024 1

I did try adding custom css in the Subtitle Appearance tab of the asbplayer config window. Unfortunately, it doesn't seem to work.

I am guessing that it has something to do with yomitan being in a different stacking context than that of asbplayer. For now a refresh of the page seems to be the only solution.

from asbplayer.

cspotcode avatar cspotcode commented on July 17, 2024 1

I am hitting the same issue, but with Migaku, which has similar functionality to Yomitan: it shows a popup dictionary.

The problem is that asbplayer custom CSS applies to the subtitle <span> itself, but that span is nested within <div class="asbplayer-subtitles-container-bottom"> which has z-index: 2147483647. I believe this means custom CSS z-index has no effect, because top-level z-index style has already ensured the asbplayer subtitles appear over top of everything else.

In my case, refreshing the page does not fix the issue. It would be nice to somehow adjust asbplayer's injected stylesheet to adjust this top-level <div> z-index.

from asbplayer.

killergerbah avatar killergerbah commented on July 17, 2024

Can you link to the website you're seeing the problem on? I can't reproduce it
As a workaround in the meantime you could lower the z-index manually with a custom CSS style setting

from asbplayer.

killergerbah avatar killergerbah commented on July 17, 2024

In some sense the subtitles are behaving correctly by being on top of everything but in the sense that this is problematic for most users this is a bug

from asbplayer.

killergerbah avatar killergerbah commented on July 17, 2024

Got it, may need to implement a way to change the CSS of the container or reconsider the usefulness of the container.

from asbplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.