Blur shortcuts improvements about asbplayer HOT 7 OPEN

That's a cool improvement. I am not sure if that should be a separate set of shortcuts or should it replace the current ones (although i feel that your idea would be utilised more often, so it could replace current ones).
Personally I won't be able to look into it myself for foreseeable time due to personal responsibilities, but definitely +1 from me.

from asbplayer.

In this scenario, would the settings toggle specify the initial blur state when subtitles load? And the shortcuts only control the blur state during playback?

from asbplayer.

Yes, exactly.

If track blur is off in the settings:
blur is permanently off for that track and mouse hover / blur shortcut doesn't change the subtitle appearance

If track blur is on in the settings:

• shortcut removes blur for the respective track, but blur is reintroduced when subtitles change
• mouse hover works as is, no changes (unblurs on hover, resumes blur when cursor leaves the sub track)

from asbplayer.

I am not sure if that should be a separate set of shortcuts or should it replace the current ones

I think it is fine to replace the existing set of shortcuts. Whoever will use the blur subtitles will be using them regularly as part of their workflow, and I'm not expecting them to use the shortcuts to change the type of the flow that they use

In other words, if they're using blur, I'm expecting them to continue using the blur and not use the shortcuts to periodically toggle that setting on and off

from asbplayer.

I see, makes sense. I agree this would be better.

from asbplayer.

Ok I'll take a look at this then

from asbplayer.

I've created the PR but it's slow to respond to keypresses and not sure what's the best way to tackle that. Feel free to update the PR! :)

from asbplayer.