kestasjk / webdiplomacy Goto Github PK

When we exposed the reliability breakdown, it was restricted to moderators so that the feature couldn't be used to work around anon games. However, it would be useful to allow users to view this information for their own profile.

Members probably should only see the CDs that don't have forcedByMod set, and consequently not see the "ignored" bit.

that can be updated w/o access to the db, so we can be aware of what's going on when the site is inaccessible

As per http://webdiplomacy.net/forum.php?viewthread=1198312

The large map in the Modern variant shows "Brest" for Brittany. It should instead read "Brittany".

The small map is correct.

Just wondering if anyone has an idea as to why I'm getting this when I connect to my server:

"Error triggered: Array to string conversion.

This was probably caused by a software bug. If these occur often try enabling error-logging via config.php, and report errors to the official devs for help."

I've patched to 1.4, and I've enabled error-logging, but there aren't any error messages generated. No errors from apache or mysql either. I haven't modified any code except my config.php file, so I'm not sure why this error's being thrown.

Thanks

Currently, the only way to find games is with the game search page, which only supports filtering on game features. It doesn't support find-by-name.

We should add the ability to find games by exact match on name.

I get what appears to be just a visual glitch when I support an army out of Spain. When I go to preview my orders, even though I have the corresponding move order set, it shows a grey line from the south coast of Spain to the province I'm moving to. This is part of a currently running game, so I'm not sure how much information I should provide, however, so ask me if you need more.

The board.php does not switch to the multiplayer-tab if necessary.

in board.php on line 320
add "tab=Multi-accounts&"
to the url.

I added a comment to your commit that contained a change to gamecreate.php, but I'm not sure if you'll automatically be shown that comment, so I'm opening it as an Issue as well. Let me know if my comment was brought to your attention so I'll know I don't need to open a separate Issue.

This line appears to have a problem:
$input['anon'] = ( (strtolower($input['anon']) == 'Yes') ? 'Yes' : 'No' );

Won't the strtolower($input['anon']) make it 'yes' instead of 'Yes'?

It'd be pretty neat if the Find User was modernised so you could start typing someone's name and it'd automatically give you suggestions for how to finish it.

-Hellenic Riot

Mods need to be able to remove players from games that have not started yet for a variety of reasons.

The current map performs poorly for colourblind users. We should add the option to display a better map to colourblind users.

vDip currently has this feature, we could pull it from them.

For some reason, the joinable games tab shows games which are not actually joinable (ie, they have no open positions). Perhaps it is showing games which used to have joinable positions, or were joined this turn?

Redesign the site banner to operate on a table, with a mod option to update. This removes the rather dangerous design of altering the webconfig file to change the banner.

don't know if it's intended, but in the "install" folder the update folder is named 0.34-0.35 instead of 1.34-1.35

When installing from the latest version, you get the following message the first time you access index.php:

Database version 1 and code version 1.04 don't match, and no auto-update script is available for this version. Please wait while the admin runs update.sql

I fixed the issue by applying all of the updates past version 1.0, but I assume that the install.sql is meant to include all the database changes up to the latest version.

There is an issue with the footerscript in V. 1.02.
If there is no $User the line 843 will fail.

If a player accidentally clicks "send" twice when sending a game message, then their message is posted twice.

To avoid this, the submit button should probably be disabled once clicked.

I saw that there's already a closed issue for this problem, which seems to include a pull request with a fix, but I'm still having issues with this. I've ticked the box in the settings to notify me of PMs, but I'm not getting any notifications. Is there anything I can do to test why?

Mods should be able to post on a thread as quickly as they need to, and they should be able to search for more then 1 user every 5 seconds.

Just started to integrate the new webDip code in the vDip branch as I noticed you added some new columns and tables to the database, but there is no update.sql, so I have no clue how to add the tables.
I noticed the sql vor a version-change from 1.35 to 1.46, but the RR entries are missing.

This query would be amazingly simple, just need to add sql and hmtl injection prevention code into this the same as is in the other search features.

If a player has TD powers over a game, they can't see who the players are if the game is anonymous.

We should change this so that they can.

The tool is supposed to allow forcing someone into CD in all of their games. The logic is on line 882 of adminActions.php.

That logic does not work for multiple games, the correct code can be taken from the ban user function, in the loop that begins "while( list($gameID, $status) = $DB->tabl_row($tabl) )" on line 948

Since powers with 0 or 1 centre left CD if they miss one turn, some users have ended up with CDs for missing one turn when they leave the game during retreats (which doesn't affect the game since their final orders are forced destroy orders).

It's more consistent for users to have the two-phases-missed rule always apply (and this is what the rulebook says too), so I think we should remove the 1 centre/1 turn CD possibility.

As part of this change, we should forgive all 0 centre CDs on the live install.

Currently, private messages that have fallen off the notifications page are inaccessible. However, they're still in the database.

It would be good to be able to see these messages - probably by adding a PM page, or adding navigation buttons to the bottom of the notifications page.

There is often 1 blank page at the end of results, probably due to the page counter being determined without removing games that you don't have the points to join.

Games cannot be made with more then 64,000 points (somewhere around there). This variable declaration should be a normal int.

"A comment you would like to make in your profile. eg Your AIM username or ICQ number."

I honestly do not know what an ICQ number is, and AIM is dead, we should update this to more relevant examples. Suggested text below.

"A comment you would like to make that will be visible to other members. Links to your favorite threads, your Ghostrating stats, etc.

As per JMO's report, if a user is banned and then has their Civil Disorder taken over, their points are returned to them. This is probably not the right behaviour.

Expected behaviour:

• Points you have in a game stay in the game pot when you CD
• When your CD is taken over, your points stay in the pot and are not returned.

Current (unconfirmed) behaviour:

• Points you have in a game stay in the game pot when you CD
• But, points are also returned to you when your CD is taken over.

I suspect this affects more than just banned users.

The >> button does not work, specifically for active games. You can get to a specific page by altering the page number in the url, so this fix shouldn't be difficult. Since you can alter via the url, it should all be possible to add a numeric input box to allow jumping to specific pages. For example if you are looking through all active gunboats and get to page 14 of 30, etc, this would allow you to immediately get to 15 without pressing the > button 15 times.

Current search for new games does not allow you to see games that you do not have the points to join. This should be an option in the search paramaters in advance search to turn off so that people interested in a starting game can find it.

The tools on the admin cp Locales page for admins do not work.

From Valis2501:

My NMR number moved up exactly one today.

I don't want to be presumptuous cause I can't code or read the github code (as in understand it) but I tried to submit moves when gameID=153273 had already drawn due to someone putting in the last vote; when a players does that (and this has always been the case) it gives you the message that the phase has already moved one as if it had moved on and you missed it (instead of being drawn). Could it be that trying to submit moves to a drawn game gives an NMR because it thinks you submitted them late? I'm sorry if this is a silly suggestion.

I suspect that the problem is that users who haven't entered orders when a game is drawn get an NMR logged. We should confirm this, and if it is the case, fix it

It would be useful if the Civil Disorder view of the profile also showed NMRs. As part of this change, the feature should be renamed "reliability breakdown" or similar.

Power is currently named "New-York", hyphen should be removed. Same for British Columbia.

It would really help live games (and indeed, all games) if game messages could be sent and received without requiring a page reload.

This would also solve the double-posting on page reload that currently happens.

In doing this, it's important to ensure that the game messaging still works on older browsers and mobile.

Searching for a game by Time Until Next Process Fix brings back paused games first. This is a bug, as it does not take the time until next phase of the paused game into account. The where clause needs to be altered on this query to correctly pull back paused games only if they are actually in order of the time until next process.

The control panel log would ideally keep a record of the user id's of the members in the game at the time it was cancelled, the person who cancelled it, time cancelled, and a reason for cancelling.

Have the list shown in the admin cp under status lists also show up on the credits page so that devs don't have to update core files.

On this map in Fall 2002, Sea of Saragasso (Cuba's unit) shows up as grey:

http://webdiplomacy.net/board.php?gameID=149754

Initial investigations suggest this is unrelated to the recent map preview changes, but regardless, we should fix this asap.

This doesn't always happen, but it has also happened on this map:

http://webdiplomacy.net/map.php?gameID=144470&turn=23

(Again, Cuba's unit, this time in Lesser Antilles)

The fix will be edit public function cdUser(array $params) to end with the line below to ensure the game realizes someone was removed to add the join button.

$Game->resetMinimumBet();

Show an X by all banned players who show up in mod tools, left intentionally vague to protect mod methods.

For special games like the SoW and interesting tournaments, it would be useful for a user to be able to pin games to a "watch list" that appears on their home page.

Hey all! I'm trying to set up a local dev version so I can contribute a ~/rss.php file to the project, letting users view RSS feeds of all their games (basically the same content displayed in the Notices/Game messages central homepage column) -- and optionally RSS feeds of individual games for observers and the like.

I'm having a few minor problems setting up the local install, is there anyone I could bother on Skype/IRC as to getting it up and running properly?

Thanks!

• George

Some of the information in the FAQ, help and getting started pages is out of date or otherwise incorrect now. We should do a full pass over everything to make sure that it's correct.

This is a more general case of issue #72.

From a member:

When I fully expand the chat window to type, so that I can see more of what I’ve been typing, and then “send” the message, the message posted is cut off on the right hand side of the message display and unreadable.

This is also a minor bug because users can open “Chat Archive” to read the message. (Not sure they all know that though).

http://webdiplomacy.net/board.php?gameID=152468 is an example of this issue. Looks like the message tab gets cut off for everyone when this happens, so it's a fairly important bug.

It should link to the github instead.

To cut down on reports of misorders that are actually user error, we could add a confirmation when navigating away from the game board when a user has entered but not saved orders.

Currently it's possible to enter some draft orders, and then send a message (which causes a page reload, and wipes the draft orders).

"Hours per phase" should be renamed "Time per phase". Since not all games are at least 1 hour.

When a user is banned the code calls the reset min bet function, but it does so before the code actually removes the member from the game. The function call needs to go after the sql code to remove a member from their game.

Basically this line "$Game->resetMinimumBet();" needs to be moved below this line " $DB->sql_put("UPDATE wD_Orders o INNER JOIN wD_Members m ON ( m.gameID = o.gameID AND m.countryID = o.countryID )
SET o.toTerrID = NULL, o.fromTerrID = NULL
WHERE m.userID = ".$userID);"