Level Generation is not consistent between certain runs using the same environment. about marioai HOT 11 CLOSED

Issue 8 has been merged into this issue.

all right! We now have our "Issue 9"! Let's GO for it! ;-)

Erik, Great job!

I would like to suggest you to join as a committer, so that you can include 
unit tests and suggestions easier. Write me an e-mail about that - we'll 
discuss!

You test contains important thing:
MarioEnvironment is a Singleton and it stores EvaluationInfo concerning only 
the latest run. Then it's fine that same task outputs different information 
after next run from another task. Benchmark now expects a user to store and 
utilize the evaluation info on his own, however now, with various tasks coming 
it looks like a nice idea to move this functionality up (to Tasks)

It is more a bit logical or design issue -- if we create two separate tasks, it 
could be more natural to store the latest evaluation info in corresponding 
task. Not in Environment. Agree! It will be redesigned.

So, fitnesses will remain different if you use

System.out.println(basicTask.getEnvironment().getEvaluationInfoAsString());

this is necessary due to cross-language usage: we propose using only 
environment as the sole mean of communication between agent and the Mario 
world. Tasks are build up upon Environments.

but I'll add basicTask.getEvaluationInfo() and this data will be Task-specific. 
In other languages, that use Mario AI through AmiCo, it will be necessary to 
wrap up with own tasks. 

I'll send you an email about that.

Your comments about storage of the EvaluationInfo seem correct!  If many tasks 
are going to be used at once I think it makes sense.

I also want to clarify what I think is the bigger problem here though.

What I was trying to show is that with the same seed and same arguments that 
two different levels are created sometimes. (Of course, this will probably be 
fixed if the level generator is being redone in the future.)

I realized that my I was making the test a bit harder than I thought.

I created a much more isolated unittest which I added to 
LevelGeneratorTest.java.

Hopefully, it makes it easier to see specifically what I meant.

That last test was broken. :)

Making a new one.

have a look at r615 -- that will fix this issue

now you can put it directly to SVN!

Yes r615 did fix the issue.  I added a regression test in r617.

This issue was closed by revision r618.