Code Monkey home page Code Monkey logo

alto's People

Contributors

benw avatar brendanzab avatar jasonsmith avatar jpernst avatar kvark avatar markjr94 avatar mtak- avatar red75prime avatar samyatchmenoff avatar suhr avatar torkleyy avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

alto's Issues

Alto::open_loopback(None) returns Invalid Device Error

i get thread 'main' panicked at 'called Result::unwrap()on anErr value: InvalidDevice', libcore/result.rs:945:5 in the third line.

fn main () {
    let alto =  Alto::load_default().unwrap();
    let mut loopback: LoopbackDevice<Stereo<i16>> = alto.open_loopback(None).unwrap()
}

when i call alcLoopbackOpenDeviceSOFT(NULL); in openal-soft directly, it works.
Is the rust code equivalent to the c code or did i miss something?

Capture not working

I tried to use the audio capture functionality (using open_capture from Alto) and it failed with the error
UnsupportedVersion { major: 0, minor: 0 }

I tested this on

  • Arch Linux with openal version 1.18.2
  • Debian with openal version 1.17.2
  • Fedora with openal version 1.18.0

Lets investigate further:
running cargo test on the alto repo also fails with the same error in the capture tests
by stepping trough alto in the debugger we find that the check_version function in alc.rs in line 221 seems to be the problem, but the code looks correct

alto/src/alc.rs

Lines 221 to 234 in e22efe2

fn check_version(&self, dev: *mut sys::ALCdevice) -> AltoResult<()> {
let mut major = 0;
unsafe { self.0.api.alcGetIntegerv(dev, sys::ALC_MAJOR_VERSION, 1, &mut major); }
let mut minor = 0;
unsafe { self.0.api.alcGetIntegerv(dev, sys::ALC_MINOR_VERSION, 1, &mut minor); }
if (major == 1 && minor >= 1)
|| (dev == ptr::null_mut() && major == 0 && minor == 0) // Creative's buggy router DLL won't report a version until you open a device
{
Ok(())
} else {
Err(AltoError::UnsupportedVersion{major, minor})
}
}

stepping further into libopenal we arrive at the GetIntergerv function in line 3164 (current master)

https://github.com/kcat/openal-soft/blob/d7895db166fe77bbeb360201a65a11f99693a65d/Alc/ALc.c#L3164-L3183

The code in and beyond this line suggests that getting major and minor versions for capture devices is not supported and always produces an ALC_INVALID_ENUM error. So the major and minor in check_verison are initialized with 0 but never changed. This results in the error.

Not sure what the best fix is, but my first thought was to simply remove the version check from open_capture. (or we suggest a fix in openal, but not sure how easy that would be)

Relicense under dual MIT/Apache-2.0

This issue was automatically generated. Feel free to close without ceremony if
you do not agree with re-licensing or if it is not possible for other reasons.
Respond to @cmr with any questions or concerns, or pop over to
#rust-offtopic on IRC to discuss.

You're receiving this because someone (perhaps the project maintainer)
published a crates.io package with the license as "MIT" xor "Apache-2.0" and
the repository field pointing here.

TL;DR the Rust ecosystem is largely Apache-2.0. Being available under that
license is good for interoperation. The MIT license as an add-on can be nice
for GPLv2 projects to use your code.

Why?

The MIT license requires reproducing countless copies of the same copyright
header with different names in the copyright field, for every MIT library in
use. The Apache license does not have this drawback. However, this is not the
primary motivation for me creating these issues. The Apache license also has
protections from patent trolls and an explicit contribution licensing clause.
However, the Apache license is incompatible with GPLv2. This is why Rust is
dual-licensed as MIT/Apache (the "primary" license being Apache, MIT only for
GPLv2 compat), and doing so would be wise for this project. This also makes
this crate suitable for inclusion and unrestricted sharing in the Rust
standard distribution and other projects using dual MIT/Apache, such as my
personal ulterior motive, the Robigalia project.

Some ask, "Does this really apply to binary redistributions? Does MIT really
require reproducing the whole thing?" I'm not a lawyer, and I can't give legal
advice, but some Google Android apps include open source attributions using
this interpretation. Others also agree with
it
.
But, again, the copyright notice redistribution is not the primary motivation
for the dual-licensing. It's stronger protections to licensees and better
interoperation with the wider Rust ecosystem.

How?

To do this, get explicit approval from each contributor of copyrightable work
(as not all contributions qualify for copyright, due to not being a "creative
work", e.g. a typo fix) and then add the following to your README:

## License

Licensed under either of

 * Apache License, Version 2.0 ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0)
 * MIT license ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT)

at your option.

### Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted
for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any
additional terms or conditions.

and in your license headers, if you have them, use the following boilerplate
(based on that used in Rust):

// Copyright 2016 openal-rs developers
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

It's commonly asked whether license headers are required. I'm not comfortable
making an official recommendation either way, but the Apache license
recommends it in their appendix on how to use the license.

Be sure to add the relevant LICENSE-{MIT,APACHE} files. You can copy these
from the Rust repo for a plain-text
version.

And don't forget to update the license metadata in your Cargo.toml to:

license = "MIT/Apache-2.0"

I'll be going through projects which agree to be relicensed and have approval
by the necessary contributors and doing this changes, so feel free to leave
the heavy lifting to me!

Contributor checkoff

To agree to relicensing, comment with :

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

Or, if you're a contributor, you can check the box in this repo next to your
name. My scripts will pick this exact phrase up and check your checkbox, but
I'll come through and manually review this issue later as well.

Add "alut" to this package?

ALUT adds some helper methods for initializing audio files and creating/binding a buffer. Is there a way you can get that added inside of this package so users don't have to resort to the boilerplate "alc" conventions?

Compiling for MinGW-W64

I’ve been trying to compile the crate on mingw-w64 for hours. I haven’t found a way to make it through with the crates.io crate, so I downloaded openal-rs, add a local override to my project and changed the link target from #[link(name = "openal32")] to #[link(name = "openal")], because that’s what pkg-config expects if you pass it --libs openal.

After our talk on IRC, you uploaded an upper-case version that will work for the native Windows installation but not for MinGW. What can we do about that?

Link against openal-soft (libopenal.dylib) on OSX (instead of framework version)

This may be kind of a pain for you, but I wonder if there is any way to give the option without needing have a whole other package. The problem is that openal-soft compiles as a dylib typically in /usr/local/lib but the openal link is specified as framework in this package so I just had to modify that one line in a local project to get it working.

FFI needs to be updated to allow the correct types to be passed into methods.

I've updated my code to reflect the changes in this repo. If you look at the types of data I'm passing into the ffi, you'll see that it doesn't match.

I glanced at my C++ code to verify that I was passing the right data into the methods, and everything looks right. There may still #need to be some kinks worked out in the ffi before it becomes fully functional.

Look at my audionode-rs repo to see my updates and compare.

Thank you!

Documentation?

I don't see a link to the rust docs for this library.

error[E0283]: type annotations required: cannot resolve `_: audio::alto::SampleFrame`

Sorry, this is probably a silly error on my part, but I can't figure this one out.

I'm trying to load samples from an array of Vorbis bytes. I currently have this naive start:

    pub fn new_buffer(&self, bytes: &[u8]) -> Result<Buffer, Error> {
        let reader = OggStreamReader::new(Cursor::new(bytes))
            .map_err(|e| err_msg("Failed to create stream reader"))?;
        let sample_rate = reader.ident_hdr.audio_sample_rate as i32;
        let audio_channels = reader.ident_hdr.audio_channels;
        let decoded: Vec<i16> = Vec::new();
        /*while let Some(samples) = reader.read_dec_packet_itl()? {
            decoded.append(&mut samples);
        }*/
        self.0.new_buffer(decoded, sample_rate)
            .map_err(|e| err_msg("Error creating buffer"))
    }

That case doesn't work. Neither does the case where the block is uncommented and, in theory, I'm appending decoded samples to a larger byte vec I'll ultimately pass to the buffer creation call. If I do:

    pub fn new_buffer(&self, bytes: &[u8]) -> Result<Buffer, Error> {
        let reader = OggStreamReader::new(Cursor::new(bytes))
            .map_err(|e| err_msg("Failed to create stream reader"))?;
        let sample_rate = reader.ident_hdr.audio_sample_rate as i32;
        let audio_channels = reader.ident_hdr.audio_channels;
        let decoded: Vec<i16> = Vec::new();
        while let Some(samples) = reader.read_dec_packet_itl()? {
            //decoded.append(&mut samples);
            self.0.new_buffer(samples, sample_rate);
        }
        self.0.new_buffer(decoded, sample_rate)
            .map_err(|e| err_msg("Error creating buffer"))
    }

That seems to work, in so far as it creates a buffer with the freshly-loaded samples in the loop, but the last buffer creation call with decoded still fails.

If I scatter around println! calls, I'm told that the samples are Vec<i16>. That's what my decoded buffer is as well, so I don't know what I'm getting wrong. I've tried a few type annotation combinations, but I can't get a match. What am I missing here?

P.s. I know I'll likely ultimately want to switch to streaming, but I'm just working with short samples now, and am trying to build up complexity over time. Thanks for any help!

Building alto on Emscripten

I recently tried to build a dummy project listing alto as one of its dependencies, targeting Emscripten with --target asmjs-unknown-emscripten, and it failed because libloading does not (yet) support Emscripten.
I had reported this, but in the meantime, al-sys actually does not need the libloading dependency when target Emscripten, because there, "out-of-the-box" support for OpenAL is claimed (see this issue).

My suggestion : When the target is Emscripten, fall back to simply declaring the FFI bindings, and disable the libloading dependency so that it builds successfully.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.