Code Monkey home page Code Monkey logo

Comments (2)

josefaidt avatar josefaidt commented on May 25, 2024

Hey @mdpotter55 👋 thanks for raising this, and glad to hear you're enjoying the library! We can definitely add the variable styles to the wrapper component

\cc @dysfunc thoughts?

from svelte-themer.

mdpotter55 avatar mdpotter55 commented on May 25, 2024

It is only a point of discussion. The more I write things down, the better I see them. My method has its own issues to consider.

There is another way:

  1. name a theme 'root' as a requirement (or it will default to the first).
  2. apply the 'root' theme variables to ':root' to set the default.
  3. All other themes are considered overlays and declared as classes.
  4. When a user picks a theme, apply the overlay class to html or body.
  5. This also allows an overlay to be used directly as a class instead of having to nest with a control.
  6. This method can be accomplished with zero controls or a visually empty one. (perhaps even a preprocessor)
  7. This method should also work much better with SSR & SEO and non-js (via svelteKit).

from svelte-themer.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.