Comments (8)
I went ahead and updated the event listener. For the context key it appears since it's used in the reactive statement to update the context it's showing that warning. That key does not change therefore I think it's safe to ignore that warning for now. I'll get this merged!
from svelte-themer.
Hi @RamiAwar thank you for the kind words! Yes SSR support would be highly beneficial I'll take a look at removing the dependencies
from svelte-themer.
@RamiAwar I've pushed an update to svelte-themer@next
which should resolve the issue. Once I am able to confirm I'll publish to 0.4.4
from svelte-themer.
merged and available under 0.4.5! let me know if you run into issues! closing for now
from svelte-themer.
That was fast! I'll test it now!
from svelte-themer.
It's all good on my end! Thanks!
from svelte-themer.
Also in case you haven't seen this already, this is the only warning I see in your code.
"CONTEXT_KEY" is declared in a module script and will not be reactive - svelte(module-script-reactive-declaration)
from svelte-themer.
Also, MediaQueryList.addListener seems deprecated, can be replaced by:
darkSchemeQuery.addEventListener(
"change",
({ matches }) =>
mode === "auto" && currentMode.set(matches ? "dark" : "light")
);
from svelte-themer.
Related Issues (18)
- Dark mode on per theme basis HOT 1
- feat: support custom prefix for CSS variables
- feat: support nested theme keys
- feat: support `prefers-color-scheme` HOT 1
- feat(next): themes object instead of array
- add proper cache bounds
- IE11 support? HOT 3
- can't reproduce it :/ HOT 2
- Is global the right way to go? HOT 2
- Uncaught TypeError: ThemeWrapper is not a constructor HOT 8
- Uncaught TypeError: getContext(...) is undefined HOT 1
- The following packages did not export their HOT 3
- add preprocessor
- improve release notes and release automation
- clean up logic, remove JS consumption logic
- per container theme? HOT 2
- Themer breaks page.js routing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svelte-themer.