Code Monkey home page Code Monkey logo

Comments (8)

josefaidt avatar josefaidt commented on May 23, 2024 2

I went ahead and updated the event listener. For the context key it appears since it's used in the reactive statement to update the context it's showing that warning. That key does not change therefore I think it's safe to ignore that warning for now. I'll get this merged!

from svelte-themer.

josefaidt avatar josefaidt commented on May 23, 2024 1

Hi @RamiAwar thank you for the kind words! Yes SSR support would be highly beneficial I'll take a look at removing the dependencies

from svelte-themer.

josefaidt avatar josefaidt commented on May 23, 2024 1

@RamiAwar I've pushed an update to svelte-themer@next which should resolve the issue. Once I am able to confirm I'll publish to 0.4.4

from svelte-themer.

josefaidt avatar josefaidt commented on May 23, 2024 1

merged and available under 0.4.5! let me know if you run into issues! closing for now

from svelte-themer.

RamiAwar avatar RamiAwar commented on May 23, 2024

That was fast! I'll test it now!

from svelte-themer.

RamiAwar avatar RamiAwar commented on May 23, 2024

It's all good on my end! Thanks!

from svelte-themer.

RamiAwar avatar RamiAwar commented on May 23, 2024

Also in case you haven't seen this already, this is the only warning I see in your code.

"CONTEXT_KEY" is declared in a module script and will not be reactive - svelte(module-script-reactive-declaration)

from svelte-themer.

RamiAwar avatar RamiAwar commented on May 23, 2024

Also, MediaQueryList.addListener seems deprecated, can be replaced by:

    darkSchemeQuery.addEventListener(
      "change",
      ({ matches }) =>
        mode === "auto" && currentMode.set(matches ? "dark" : "light")
    );

from svelte-themer.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.