Code Monkey home page Code Monkey logo

Comments (2)

disjunction avatar disjunction commented on May 20, 2024

hm, that's unfortunate. Minor versions should normally be backwards-compatible, and this lib is quite straight-forward in what it does. Thanks for reporting it!

from express-prom-bundle.

disjunction avatar disjunction commented on May 20, 2024

I couldn't reproduce this problem. It works fine for me.

I suspect there is a misunderstanding. Bare in mind: express-prom-bundle has a direct dependency on prom-client. When you were testing it it was ~11.1.2, thus you COULD NOT use 11.2.0 at all unless you meddled with the library. Since today release I upgraded the dependency to ~11.2.1

If you have [email protected] installed in your app separately, then in your app you actually have 2 different prom-client instances, one which came with express-prom-bundle, and another - your own. They don't share the metrics, so it might be you were collecting the data with one client, while trying to read from another one.

Until now you could use a workaround: instead of installing and requiring prom-client, you could directly access the one, coming with express-prom-bundle as follows:

const promClient = require('express-prom-bundle').promClient

With the new release 5.x prom-client will become a peer dependency and you won't have this problem again.

Please reopen if my guess is wrong and you still experience the problem, in which case I'd need some reproducible test case.

from express-prom-bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.