Comments (2)
hm, that's unfortunate. Minor versions should normally be backwards-compatible, and this lib is quite straight-forward in what it does. Thanks for reporting it!
from express-prom-bundle.
I couldn't reproduce this problem. It works fine for me.
I suspect there is a misunderstanding. Bare in mind: express-prom-bundle has a direct dependency on prom-client. When you were testing it it was ~11.1.2
, thus you COULD NOT use 11.2.0
at all unless you meddled with the library. Since today release I upgraded the dependency to ~11.2.1
If you have [email protected]
installed in your app separately, then in your app you actually have 2 different prom-client instances, one which came with express-prom-bundle, and another - your own. They don't share the metrics, so it might be you were collecting the data with one client, while trying to read from another one.
Until now you could use a workaround: instead of installing and requiring prom-client
, you could directly access the one, coming with express-prom-bundle as follows:
const promClient = require('express-prom-bundle').promClient
With the new release 5.x prom-client will become a peer dependency and you won't have this problem again.
Please reopen if my guess is wrong and you still experience the problem, in which case I'd need some reproducible test case.
from express-prom-bundle.
Related Issues (20)
- Missing documentation on combination of autoregister false and metricsApp HOT 2
- Intentional breaking changes? HOT 4
- Option to lowercase all paths HOT 2
- Option to erase series without requests for a given time HOT 6
- Adding prefix to "up" metric HOT 3
- Add labels to up metric
- @types/express should be marked as a peerDependency
- prom-client 15 compatibility HOT 1
- Unintentional(?) breaking peer dep change in 6.3.1 HOT 1
- Helped needed... HOT 2
- maxAgeSeconds not part of "opts" type HOT 1
- Type definitions do not include promRegistry as a configurable parameter HOT 1
- Package consuming 10gb of virtual memory HOT 5
- Allow a path whitelist option HOT 3
- excludeRoutes is missing from the TypeScript types HOT 1
- Disable http_request_duration_seconds HOT 3
- Cluster: Operation timed out. HOT 2
- Normalizing URL path: Replace #val with custom values/attributes HOT 1
- Missing `promClient` type in the `express_prom_bundle` interface HOT 6
- Disable http_request_duration_seconds_bucket and http_request_duration_seconds_count, but keep http_request_duration_seconds_sum HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express-prom-bundle.