Allow a path whitelist option about express-prom-bundle HOT 3 CLOSED

Here is a PR to add this feature (and update the tests and types):

• #91

Let me know if you'd like the feature, but want it a different way (or if I should add something to the PR like bumping the version).

from express-prom-bundle.

@RyanBard thanks for contributing. I believe it was removed because whitelisting duplicates core express functionality. And i try to keep the library as simple as possible (it already has too many options as to my taste).

You can achieve the same result with the code like this:

app.use(['/metrics', '/foo*'], promBundle())
app.get('/foo/123', handler1) // will be counted by prom bundle
app.get('/bar/567', handler2) // will be ignored by prom bundle

Have you considered this approach?

from express-prom-bundle.

Good point. I didn't think about handling this in express. Thanks! I'll close this issue and the PR.

from express-prom-bundle.