Code Monkey home page Code Monkey logo

Comments (5)

disjunction avatar disjunction commented on May 20, 2024

@wineman3 As described in the doc, the library provides either a histogram or the summary. So what you see are not just single metrics - but parts of the histogram, see https://prometheus.io/docs/concepts/metric_types/#histogram

I don't see, how the parts you're not interested in are so bad that you'd add any code or complexity to remove them. You may reduce the buckets by providing just one bucket. But that's max effort I would put into it.

Also I wonder, how is the sum alone of any use for you at all? Actually the division of sum by count gives you the average latency. I thought that's the whole point of the histogram. Average latency and corresponding count of hits all delivered with just 2 values. Isn't that cool?

from express-prom-bundle.

wineman3 avatar wineman3 commented on May 20, 2024

Yeah sorry, my mistake. We use sum and count but the bucket/histogram metrics not as much. I can definitely see the value in them, it's more so an effort to reduce cardinality on our organization's Prometheus server.

from express-prom-bundle.

disjunction avatar disjunction commented on May 20, 2024

well, as I said my solution would be to provide buckets: []. This will result in exactly one bucket (+Inf), which will be the same as count. So you get 3 values instead of 2 you need.

But hey, for an edge case of a guy, who isn't interested in the fact that some of requests are REALLLY slow but are missed because of the averages (this is the point of buckets), it should be good enough.

I'm really reluctant of going away form histogram, cause it's indeed a good practice.

from express-prom-bundle.

disjunction avatar disjunction commented on May 20, 2024

@wineman3 please forgive my tone in the previous comment. It was an unjustified arrogance on my side.

Closing the issue, hopefully you came to an adequate solution.

from express-prom-bundle.

wineman3 avatar wineman3 commented on May 20, 2024

@disjunction no worries! I really appreciate your help. It’s honestly given me insight to utilize the histogram metrics some more, and I may go that route now, this was just direction from leadership on my team but I may push back to utilize the histogram approach more extensively. Thanks again!

from express-prom-bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.