Update cmake to behave correctly when installed onto system. about cisst HOT 8 CLOSED

When something is defined in this way it can be included with:

include_directories(      $<TARGET_PROPERTY:sawConstraintController,INTERFACE_INCLUDE_DIRECTORIES>)

from cisst.

Is this based on some type of "best practices with CMake", or is it something you created?

from cisst.

It is based on best practices, my changes are ones that correctly fix installation paths. However there are features utilized come with CMake 3.0 and up, the current is 3.3.

The installation path problems are present in the current version regardless of the cmake version used.

from cisst.

Actually, I just downloaded CMake 3.4

from cisst.

Since Ubuntu 12.04 comes with CMake 2.8.7 and has been the recommended OS for the dVRK I would prefer to avoid CMake 3.x features.
The issue is that the install directory is not always properly defined during the build process hence the -config.cmake must have a mechanism to figure out where it is installed. Our strategy has been to use an external macro (cisst_find_saw_component) to centralize this logic. Does anyone know if there was a better standard practice pre CMake 2.8.7?

On Nov 18, 2015, at 7:19 AM, Peter Kazanzides [email protected] wrote:

Actually, I just downloaded CMake 3.4

—
Reply to this email directly or view it on GitHub.

from cisst.

Unfortunately 2.8.7 is very broken, there were key fixes in 2.8.8. I've been installing newer cmake versions onto 10.04 for years. Does what you have now work in your use case on 2.8.7?

I think the ProjectConfig.cmake is now expected to be installed into $CMAKE_INSTALL_PREFIX/lib/cmake/. Right now it is put in some really long share/cisst/something/somethingelse path, well when it isn't specifying paths that have been deleted. :-)

from cisst.

I found the link to the best "best practices" I've seen that is a few years old titled Modern CMake.

Here is some additional possible old "best practice" info:
https://cmake.org/pipermail/cmake/2013-February/053689.html
the above is from here
http://cmake.3232098.n2.nabble.com/CMakeModules-repository-at-GitHub-tp7583818p7583832.html

Here is an interesting conversation:
https://www.reddit.com/r/programming/comments/1qjoln/modern_cmake_with_qt_and_boost/

from cisst.

This has been fixed.

from cisst.