jesseleite / an-old-hope-syntax-atom Goto Github PK

this theme is awesome! Now I have noticed that I can't edit SASS files as used to because variables does not get highlighted. Screenshot attached. Sass editing with the official plugin from atom: https://atom.io/packages/language-sass

default, One Dark theme:

An old hope theme:

Variable @syntax-result-marker-color; is used in base.less but it's missing its value.

atom-text-editor .search-results .marker .region,
:host .search-results .marker .region {
  background-color: transparent;
  border: 1px solid @syntax-result-marker-color;
}

Hi
Great work with it, but can you modify JS syntax highlight? "this" isn't highlighted as keyword. Ofc. $this would be same color as variables, but "this" should be red as rest of keywords (like "var"). Nice to have :)

PS: One dark recognize this everywhere, so $this also has red color (not best but still good).

var and let have the storage and type classes which results in the light-gray color being selected.

The result is essentially no syntax highlighting for these keywords. I found that removing the .storage.type light gray selector results in the desired behavior for me.

I'm not sure if that selector is used elsewhere that I'm not thinking of though.

Hi there,
First , congratulations on the theme, I love the colors ,

I have a question, some JS objects in coffeescript appears without any color, is this a bug or something similar?

I use the v1.5.1 on Ubuntu 14.04

Would you consider making a branch of the theme to be used in Brackets?
I made a makeshift one myself, but there is a lot of stuff that is unknown to me, so I wouldn't know what to change it to.

I have added

document.body.classList.add('an-old-hope-modify-ui')
To my init script but it dones't seem to have made a diffrencem not sure if it is related to atom 1.13.1

I wanted this scheme in iTerm2, so I used an online tool to make it, if you're interested:

https://terminal.sexy/#FRYZy83SAAAA6S8vdrpo6sxeQLXX9H0yI-3aq6urNDQ06S8vdrpo6sxeQLXX9H0yI-3a-fn5

That's all, and thanks!

I run basicly the same setup on two different machines. Recently I tried installing An Old Hope syntax on my Windows machine, and it just didn't look right. Below are screen shots of both Windows and OS X and how they look to me.

Both are using One Dark as UI theme and An Old Hope for syntax. I'm hoping to get my Windows setup looking like my OS X.

On Windows 10

On OS X El Capitan

If any additional info is needed, I can supply it.

Hokey religions and ancient weapons are no match for a good blaster at your side, kid. - Han Solo

In an-old-hope-syntax/index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• .an-old-hope-modify-ui .tree-view .header.list-item, .an-old-hope-modify-ui .tree-view .list-item => .an-old-hope-modify-ui .tree-view .syntax--header.list-item, .an-old-hope-modify-ui .tree-view .list-item

• .an-old-hope-modify-ui .tab-bar .tab::before => .an-old-hope-modify-ui .tab-bar .syntax--tab::before

• .an-old-hope-modify-ui .tab-bar .tab .title => .an-old-hope-modify-ui .tab-bar .syntax--tab .syntax--title

• .an-old-hope-modify-ui .tab-bar .tab.active .title => .an-old-hope-modify-ui .tab-bar .syntax--tab.active .syntax--title

• .an-old-hope-modify-ui .tab-bar .tab .close-icon => .an-old-hope-modify-ui .tab-bar .syntax--tab .close-icon

• .an-old-hope-modify-ui a.link => .an-old-hope-modify-ui a.syntax--link

• .an-old-hope-modify-ui a.link:hover => .an-old-hope-modify-ui a.syntax--link:hover

• .an-old-hope-modify-ui .tooltip.top .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--top .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.top-left .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.top-left .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.top-right .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.top-right .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.right .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--right .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.left .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--left .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.bottom .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--bottom .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.bottom-left .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.bottom-left .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.bottom-right .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.bottom-right .tooltip-arrow

• .an-old-hope-modify-ui .tooltip .tooltip-inner => .an-old-hope-modify-ui .syntax--tooltip .tooltip-inner

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

I love using this theme! Unfortunately, it doesn't support all of the variables in the Stan modeling language. From what I can tell, it's unable to highlight the variable declaration (int, vector, real, matrix, etc.) and the blocks (functions, data, parameters, model, generated quantities, etc.)

It would be great if you could fully support the language so that I can exclusively use An Old Hope.

Here's an example of what is looks like

And here's a comparison using Base16 Tomorrow Dark

Hi, I used to use atom and used this theme for a long time. I'd like to use it on PhpStorm, would you be willing to port it?

Thanks.

Hi,

First, I would like to thank you for this package, it's awesome.

However the version 1.0.0 does not work with Atom 1.10: there's no syntax highlighting. I had to manually install the version 0.5.0 to get the colors back.

$ atom -v
Atom    : 1.10.2
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0

Just started an tutorial about React/JSX and I noticed the theme doesn't support it, tags just stay white. Could you add it?

I am a big fan of this theme but I mainly use RubyMine for RoR development. Would you re-create it for RM ?
Regards

var and let have the storage and type classes which results in the light-gray color being selected.

The result is essentially no syntax highlighting for these keywords. I found that removing the .storage.type light gray selector results in the desired behavior for me.

I'm not sure if that selector is used elsewhere that I'm not thinking of though.

https://github.com/JesseLeite/an-old-hope-syntax-atom/blob/d8439817d55983843422d22ef59dbb5ca53c076d/styles/base.less#L111

In an-old-hope-syntax\index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• .an-old-hope-modify-ui .tree-view .header.list-item, .an-old-hope-modify-ui .tree-view .list-item => .an-old-hope-modify-ui .tree-view .syntax--header.list-item, .an-old-hope-modify-ui .tree-view .list-item

• .an-old-hope-modify-ui .tab-bar .tab::before => .an-old-hope-modify-ui .tab-bar .syntax--tab::before

• .an-old-hope-modify-ui .tab-bar .tab .title => .an-old-hope-modify-ui .tab-bar .syntax--tab .syntax--title

• .an-old-hope-modify-ui .tab-bar .tab.active .title => .an-old-hope-modify-ui .tab-bar .syntax--tab.active .syntax--title

• .an-old-hope-modify-ui .tab-bar .tab .close-icon => .an-old-hope-modify-ui .tab-bar .syntax--tab .close-icon

• .an-old-hope-modify-ui a.link => .an-old-hope-modify-ui a.syntax--link

• .an-old-hope-modify-ui a.link:hover => .an-old-hope-modify-ui a.syntax--link:hover

• .an-old-hope-modify-ui .tooltip.top .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--top .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.top-left .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.top-left .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.top-right .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.top-right .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.right .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--right .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.left .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--left .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.bottom .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--bottom .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.bottom-left .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.bottom-left .tooltip-arrow

• .an-old-hope-modify-ui .tooltip.bottom-right .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.bottom-right .tooltip-arrow

• .an-old-hope-modify-ui .tooltip .tooltip-inner => .an-old-hope-modify-ui .syntax--tooltip .tooltip-inner

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary.

document.body.classList.add('an-old-hope-modify-ui') add to init.coffee ? thanks

Did you ever consider releasing a light syntax theme based on the colors? I guess the contrast would be good enough if you'd 'recycle' the colors in front of a light background.

.an-old-hope-modify-ui .tree-view .header.list-item, .an-old-hope-modify-ui .tree-view .list-item => .an-old-hope-modify-ui .tree-view .syntax--header.list-item, .an-old-hope-modify-ui .tree-view .list-item
.an-old-hope-modify-ui .tab-bar .tab::before => .an-old-hope-modify-ui .tab-bar .syntax--tab::before
.an-old-hope-modify-ui .tab-bar .tab .title => .an-old-hope-modify-ui .tab-bar .syntax--tab .syntax--title
.an-old-hope-modify-ui .tab-bar .tab.active .title => .an-old-hope-modify-ui .tab-bar .syntax--tab.active .syntax--title
.an-old-hope-modify-ui .tab-bar .tab .close-icon => .an-old-hope-modify-ui .tab-bar .syntax--tab .close-icon
.an-old-hope-modify-ui a.link => .an-old-hope-modify-ui a.syntax--link
.an-old-hope-modify-ui a.link:hover => .an-old-hope-modify-ui a.syntax--link:hover
.an-old-hope-modify-ui .tooltip.top .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--top .tooltip-arrow
.an-old-hope-modify-ui .tooltip.top-left .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.top-left .tooltip-arrow
.an-old-hope-modify-ui .tooltip.top-right .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.top-right .tooltip-arrow
.an-old-hope-modify-ui .tooltip.right .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--right .tooltip-arrow
.an-old-hope-modify-ui .tooltip.left .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--left .tooltip-arrow
.an-old-hope-modify-ui .tooltip.bottom .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.syntax--bottom .tooltip-arrow
.an-old-hope-modify-ui .tooltip.bottom-left .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.bottom-left .tooltip-arrow
.an-old-hope-modify-ui .tooltip.bottom-right .tooltip-arrow => .an-old-hope-modify-ui .syntax--tooltip.bottom-right .tooltip-arrow
.an-old-hope-modify-ui .tooltip .tooltip-inner => .an-old-hope-modify-ui .syntax--tooltip .tooltip-inner
Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.