Deprecated selector in `an-old-hope-syntax/index.less` about an-old-hope-syntax-atom HOT 12 CLOSED

Hi @jesseleite please check out these screenshots:

https://www.evernote.com/l/AOeC5ZKISfdIbI2IuxL85-arQvEjQpJEngkB/image.png

https://www.evernote.com/l/AOczBCNZRWhNpKaTHfmbOBEzYaDqrTi-mHcB/image.png

https://www.evernote.com/l/AOcdtEWayyBLMIJ3PYsnk0QBE3ngZ5-tScYB/image.png

from an-old-hope-syntax-atom.

Thanks for merging, I appreciate it. 👍

from an-old-hope-syntax-atom.

Already pushed an update with these changes. Gonna close this issue :P

See full commit history

from an-old-hope-syntax-atom.

Just want to inform you that I am still getting same error. Has this change been released?

from an-old-hope-syntax-atom.

@johnroach With Atom 1.13 and theme version 1.0.1? Can you also screenshot the error that you are seeing? I ask because the errors went away for me after I upgraded the theme to 1.0.x.

from an-old-hope-syntax-atom.

Cool, will see what I can figure out.

from an-old-hope-syntax-atom.

@jesseleite just so you know I did a clean install for atom (needed to install it on a new system) still having same issues.

from an-old-hope-syntax-atom.

I created a pull request to fix the selectors. I no longer get the deprecation cop alert with this change.

from an-old-hope-syntax-atom.

I'm not really sure what happened but it looks like this change was implemented and then for some reason the old file was pulled back in. Your commit b6ac56e has these changes but the master branch currently shows the file in it's old state without syntax-- implemented. If you download the zip for release 1.0.1 under the releases is has the old file in it.

from an-old-hope-syntax-atom.

Hey @DerekVance, thanks for looking into this! The reason I removed that stuff is because I didn't see syntax--tab etc. in the DOM when opening the inspector. Could you explain why syntax--tab is needed if it's not anywhere in the DOM?

from an-old-hope-syntax-atom.

Hey @jesseleite no problem I really dig the theme and UI integration. Check out this blog post the Atom Dev team put out, it should shed some light as to why they made some changes. http://blog.atom.io/2016/11/14/removing-shadow-dom-boundary-from-text-editor-elements.html

from an-old-hope-syntax-atom.

Thanks man 👍 Merged.

from an-old-hope-syntax-atom.