jeromegamez / duration-php Goto Github PK

This method should be improved to guard against DST and other timezone shenanigans...

        $now = new DateTimeImmutable();
        $then = $now->add($value);
        return $now->diff($then);

should be

        $now = new DateTimeImmutable('@'.time());
        $then = $now->add($value);
        return $now->diff($then);

this way your reference DateTimeImmutable object is created against a timestamp (aka) GMT which is not affected by Timezone trickery 😉 .

Maybe refactor your code to always use this code everywhere instead of repeating it everywhere it would make the code more maintainable too. If I'm correct this pattern is used in many places currently.

PS: if you are lazy .. you could even use DateTimeImmutable('@0') as a private static variable 👍 anyway this part should be improved.

@jeromegamez nice package why is the Duration class no longer final ? Seems to me that it is a Value Object and therefore should be final 🤔