Code Monkey home page Code Monkey logo

duration-php's Introduction

Hi there 👋

I'm Jérôme Gamez, a platform and backend engineer with 20+ years of experience. I build elvah during the day and Open Source Software at night.

I'm a Jack of all trades with a soft spot for PHP, legacy software and, of course, Open Source software.

My hobby is my job and vice versa. My mission is to make the work of all developers (myself included) more productive and enjoyable. I have a special affinity for code quality, stability, and legacy software, and consider no code base to be unmaintainable 💪🏻.

My most prolific project is the (unofficial) Firebase Admin SDK for PHP and its related libraries, which are downloaded 500K+ times a month, but I also publish and maintain many more Open Source projects in the BESTE, kreait, and my personal GitHub organizations.

👷 What I'm currently working on

🌱 My latest projects

🔭 Latest releases I've contributed to

🔨 My recent Pull Requests

⭐ Recent Stars

❤️ These awesome people sponsor me (thank you!)

👯 Check out some of my recent followers

💬 Feedback

If you use one of my projects, I'd love to hear from you. Let me know what you like and what needs being improved. And if you're a happy user of one or many of my projects, please consider becoming a GitHub Sponsor!

📫 How to reach me

duration-php's People

Contributors

ecointest avatar jeromegamez avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

smoench djoudi simphiwehlabisa parenyukln linscomt julio899payco yodthong-ch sergiy-petrov ivantalpa

duration-php's Issues

normalizeInterval should be improved

duration-php/src/Duration.php

Line 149 in 67abef8

private function normalizeInterval(DateInterval $value): DateInterval

This method should be improved to guard against DST and other timezone shenanigans...

        $now = new DateTimeImmutable();
        $then = $now->add($value);
        return $now->diff($then);

should be

        $now = new DateTimeImmutable('@'.time());
        $then = $now->add($value);
        return $now->diff($then);

this way your reference DateTimeImmutable object is created against a timestamp (aka) GMT which is not affected by Timezone trickery 😉 .

Maybe refactor your code to always use this code everywhere instead of repeating it everywhere it would make the code more maintainable too. If I'm correct this pattern is used in many places currently.

PS: if you are lazy .. you could even use DateTimeImmutable('@0') as a private static variable 👍 anyway this part should be improved.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.