Code Monkey home page Code Monkey logo

revanced-magisk-module's People

Contributors

archit9169 avatar arfawong avatar brian6932 avatar cnc-robert avatar e85addict avatar ivy-tokito avatar j-hc avatar matadorprobr avatar miroxyz avatar mokasoda avatar origamiofficial avatar osumatrix avatar rabilrbl avatar smart123s avatar theoware avatar tidalmist avatar vucko130 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

revanced-magisk-module's Issues

youtube watched video

when i watch a video its not showing in history or i watched it, its still like never watched it.

Workflow run fails

Error: Exception in thread "main" java.lang.NoClassDefFoundError: app/revanced/patcher/patch/OptionsContainer
at java.base/java.lang.ClassLoader.defineClass1(Native Method)

The app force closes

I don't know what the problem is but after flashing the magisk module and rebooting, the app's logo is changed but when i try to use it forecloses i even cleared the app data but that doesn't solve anything.

Updating protocol

In the readme.md it says:

The modules support Magisk update which means you will receive updates from your Magisk app, downloading from github releases and reflashing is not necessary.
To be able to update YouTube version, you will need to:

Disable the module
Reboot
Install the APK of the new YouTube
Update the module and reboot again

What Í'm currently doing is:

Install the APK of the new YT/YT Music but don't open it.
Update module without disabling
Rebooting

Everything works fine, with fewer steps. Theoretically, on how filesystems are built this should be working.

Workflow run failed

Binary diffing temp/music-revanced-v5.22.54-arm-v7a.apk against temp/music-stock-v5.22.54-arm-v7a.apk
xdelta3: file open failed: read: temp/music-revanced-v5.22.54-arm-v7a.apk: No such file or directory
Error: Process completed with exit code 1.

More detailed Readme

First ot all thank you for the great work you have done, you really helped us here. everything is cool I'm just here to give my feedback about the readme. It could use some more details like that this project (modules) support more than just YouTube and that it supports Reddit, Twitter... With the features the modules provide or what they patch.

Thank you for reading.

Question: Keep config

When I updated the module through magisk, my configuration was lost. Is it possible to keep those configurations after updating?

[Suggestion] Check if there is a new YT version on CI workflow

Currently CI only checks if there are any new release on the revanced-patches repo before it builds with makes sense since to support a new version of YT, the devs need to release a new version of the patches but, when you gonna use the --experimental flag and there is a new release on APKMirror but no new release is made on the revanced-patches repo, CI just skips since the workflow only checks the revanced-patches repo.

My suggestion is to check if there is a new release on APKMirror (with --experimental flag, check for the latest version and without --experimental flag, check for the latest supported version or for a more pratical solution, only check when using --experimental flag).

Using --exclusive prevent yt-update.json from being updated

if [[ "$YT_PATCHER_ARGS" != *"-e microg-support"* ]]; then
mv -f "$patched_apk" build
echo "Built YouTube (no root) '${BUILD_DIR}/${patched_apk}'"
return
fi
if [[ "$MUSIC_PATCHER_ARGS" != *"-e music-microg-support"* ]]; then
mv -f "$patched_apk" build
echo "Built Music (no root) '${BUILD_DIR}/${patched_apk}'"
return
fi

This is probably because it's not supposed to use --exclusive.

My build.conf:

# ex: for excluding patches: -e patchname -e anotherpatchname
# if you remove '-e microg-support' arg, you get noroot builds
YT_PATCHER_ARGS="--exclusive -i minimized-playback -i custom-branding -i old-quality-layout -i force-vp9-codec -i custom-playback-speed -i settings -i video-ads -i general-ads"
MUSIC_PATCHER_ARGS="-e music-microg-support"

BUILD_YT=true
BUILD_MUSIC_ARM64_V8A=true
BUILD_MUSIC_ARM_V7A=false
BUILD_TWITTER=true
BUILD_REDDIT=false

BUILD_MINDETACH_MODULE=true

ENABLE_MAGISK_UPDATE=true # set this to false if you do not want to receive updates from magisk app

UPDATE_PREBUILTS=true

# this is the repo to fallback for magisk update json if you are not building on github actions ↓
GITHUB_REPO_FALLBACK="j-hc/revanced-magisk-module"```

Ads before video play

Hi, thanks for the repo!

Occasionally, I'm getting ads before the video starts to play. I flashed the release version, then I logged in with my account, I enabled shorts in the settings and I haven't touched anything else.

It doesn't happen always, but it does from time to time.

Seekbar Tapping

Hello,
I am using the latest magisk flashable zip of revanced v17.32.35 and seekbar tapping keeps working even if I disable it in the revanced settings.

patching failed in latest pre-release

The youtube-revanced-magisk-v17.29.34-all.zip from 8-6-22 is only about 20mb and doesn't install in magisk. Not a big deal, I just used the one from the previous date. I just don't know why the most recent one was built incorrectly.

Triggers Anti-Root

This magisk module trips the anti-root mechanisms of some banking apps , I believe this is due to mindetach, is it possible to not use mindetach without using the microg version? (see comments)

YouTube player control bug

YouTube pause button (player control doesn't go away
Even if we tap or automatically after sometime)
It stays there until we close and open the video again
Please fix this bug as it is annoying

Youtube freeze

Youtube freeze when open a video, the video is playing but the other not responding. It takes time to load. And it make ui lag. All loaded and then ui responding

Screenshot_20220917-171647_YouTube

Auto play next not working

When youtube video ends it auto replay by default and when try to enable and disable again auto replay option form revanced setting it does not auto play neither does it play next...

any solution for it??

RYD Doesn't work

Hello,
I am using the latest magisk flashable zip of revanced v17.32.35 and dislike count isn't showing up.

EDIT: Return Youtube Dislike is Enabled in settings.

Screenshot_20220824-000837_YouTube

Error 400

How to get rid of error 400 when adding or voting sponsored segment?

base.apk mountpoint can be exposed

Many banking apps detect the mountpoint of base.apk for no reason. You should find a way to hide mountpoint of revanced.

:/ # magiskhide exec grep base.apk /proc/mounts
/data/app/~~ZxixEheqWH69_lQZKcX5DQ==/com.google.android.youtube-82g8HhHe78e==/base.apk ext4 rw,seclabel,nosuid,nodev,noatime,nodiratime,resgid=1065,data=ordered 0 0

Youtube Music Arm V7?

the new YouTube music update you released no longer has the YouTube Music Arm V7 option, I was wondering if you will still support this version? (I still use Arm V7 version)

Workflow run fails

After cli,patcher and integration update today,the workflow run fails

Not working for YouTube

Tried 2 version of magisk modules and Installed different version of YouTube app, arm64-v8a/xhdpi.

The modules works with YT music though, unfortunately I cannot get it to work for YT app

YouTube music

I'm having an issue with YouTube music wanting me to verify my age but won't let me enter my Google account. It just says that account already exists, what do?

[Question] New rework module logic

So it works fine, just used it the only problem is, since the module reinstalls the the correct apk everytime, it also erases the revanced settings in the process. So basically its like installing completely fresh even from just a regular update through magisk. My suggestion to a possible solution is to maybe have a cheksum check/match and if the apk is already the correct one skip the apk reinstall? The way it was simply only patching before was working completely fine in terms of updating and not resetting the revanced settings. Or whatever you think might work. I can test/debug anything you need me too. I hope I make sense I can clarify if needed.

Youtube revanced autoplay not working.

Hey I know it's not the right place as you only create build.
But I was searching for something to solve the issue of youtube revanced autoplay not working and got the solution for that by excluding the hide-autoplay-button patch.
-e hide-autoplay-button
So could you please release a build once removing this patch.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.