Code Monkey home page Code Monkey logo

Comments (6)

j-hc avatar j-hc commented on May 21, 2024
  1. did you build locally or on actions?
  2. what config are you talking about?

from revanced-magisk-module.

likkai avatar likkai commented on May 21, 2024
  1. I built the root version (17.28.34) using actions and upgraded to version 17.29.34 through magisk
  2. The config I was talking about was excluding the patches (-e packagename) in the file build.conf

from revanced-magisk-module.

j-hc avatar j-hc commented on May 21, 2024

well that shouldnt happen. module you built on your repo will always use your build.conf file. you can have a look at workflow logs.

from revanced-magisk-module.

likkai avatar likkai commented on May 21, 2024

I think I wasn't clear just now so I'll explain it again 😅
The module I built on GitHub used my build.conf file (works normally) but afterwards when I update the module from the magisk update button (I didn't build it again on GitHub), the patches I excluded was included.
For example, I built the module with -e custom-branding, is there a way to update the module through magisk (not building it on GitHub) with the same configurations I saved in the build.conf file? (The -e custom-branding patch)

from revanced-magisk-module.

j-hc avatar j-hc commented on May 21, 2024

The thing is if you didnt build again, you cant possibly receive an update from inside magisk. I would make sure you are not using the module from my repo as that way you would receive updates from my repo. you can go to /data/adb/modules/ytrv-magisk/module.prop file and see the updatejson if it points to your repo.

from revanced-magisk-module.

likkai avatar likkai commented on May 21, 2024

I see, thanks for your help

from revanced-magisk-module.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.