Comments (6)
haydenbleasel
commented on July 20, 2024
The generated markup for some of the graphics such as-
href="assets/img/favicon/apple-touch-startup-image-2048x1496.png"
href="assets/img/favicon/apple-touch-startup-image-1024x748.png"
differ from the file names which are -
apple-touch-startup-image-1496x2048.png
apple-touch-startup-image-748x1024.png
These specifc images are also rotated 90 degrees. Am I missing something? All the rest work fine.
from favicons.
alanontheweb
commented on July 20, 2024
Yeah, it's an easy fix in html.json. I just reversed the file name in my fork. Thanks!
from favicons.
haydenbleasel
commented on July 20, 2024
@alanontheweb Awesome. I'm not sure which way around the numbers are meant to be, but if you figure out, can you submit a PR? :)
from favicons.
alanontheweb
commented on July 20, 2024
Sure thing. Let me investigate to make sure all the orientations are set right and I'll do a PR.
from favicons.
haydenbleasel
commented on July 20, 2024
@alanontheweb Thanks mate. If you run npm test it will run the RFG generator too and that should show the correct output in the test/images-online folder.
from favicons.
haydenbleasel
commented on July 20, 2024
Closing this for #107
from favicons.
Related Issues (20)
- Remove node-fibers to enable support of Nodejs 16.x
- Localized manifest? HOT 1
- Dead platforms HOT 3
- Next release? HOT 10
- heads up: broken colors package HOT 10
- Bring back coverage report and badge HOT 1
- Can't be used with Next.js: Consider publishing non ESM modules: is a nightmare to setup and make it work! HOT 4
- Improved typescript types HOT 1
- Error When Installing Sharp and/or Favicons
- npm install favicons make http request to https://github.com/lovell/sharp-libvips/releases/download/v8.7.4/libvips-8.7.4-linux-x64.tar.gz HOT 2
- Unsupported platform coast HOT 2
- Handling a few different image files as favicon and touch icon HOT 3
- 7.0.0 is not working on Windows HOT 5
- [Bug] Favicons generates null value for Android platform HOT 1
- Deprecate yandex icon? HOT 3
- Deprecate Windows 8 tile icons HOT 2
- HTML for apple-touch-startup-image HOT 1
- Add a `cacheBustingQueryParam` option for a cache busting system HOT 1
- Add Release and Changelog HOT 1
- update dependency sharp to v0.32.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from favicons.