Code Monkey home page Code Monkey logo

Comments (10)

synedra-mpe avatar synedra-mpe commented on June 27, 2024 8
yarn audit v1.22.17
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ critical      │ Prototype Pollution in minimist                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=1.2.6                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ favicons                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ favicons > to-ico > resize-img > jimp > mkdirp > minimist    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/1067342                     │
└───────────────┴──────────────────────────────────────────────────────────────┘

An update would really be encouraged.

from favicons.

nrthbound avatar nrthbound commented on June 27, 2024 7

What's the overall status of this? Been quite some time, is this scheduled to be part of the main release sometime soon? Thanks.

from favicons.

alexander-akait avatar alexander-akait commented on June 27, 2024

I think we will finish browserslist support, but we can do release right now if you want, even more I can add permission to do release, so you can do it without me

from favicons.

andy128k avatar andy128k commented on June 27, 2024

I am not sure if browserlist is actually needed.

  1. Android Chrome icons depend on device's DPI, not on a browser's version
  2. Apple icons and splash screens also depend on device, not a browser.
  3. Windows platform is not a browser.
  4. Yandex browser wants a single image and this may be turned on/off completely.
  5. For standard icons favicons generates bare minimum.

from favicons.

alexander-akait avatar alexander-akait commented on June 27, 2024

@andy128k Can you give me npm name?

from favicons.

alexander-akait avatar alexander-akait commented on June 27, 2024

Found you, added https://www.npmjs.com/package/favicons/access, feel free to do release 👍

from favicons.

mureni avatar mureni commented on June 27, 2024

Any update on when the new release will be available? The audit headaches from the to-ico dependency are driving me nuts!

from favicons.

andy128k avatar andy128k commented on June 27, 2024

@mureni A version 7.0.0-beta.1 is already released.
Here is also a PR to one of downstream packages to test it.

from favicons.

drolsen avatar drolsen commented on June 27, 2024

What was the decision for 7.0.0-beta.1's dist/ files to move over to being ESModules vs. well established require like on 6.2.2?
I've got a downstream package (node 14.17.0) that I for the life of me can't seem to get working using 7.0.0-beta.1 cause dist/ is now all ESModules.

from favicons.

andy128k avatar andy128k commented on June 27, 2024

See #355

from favicons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.