Comments (5)
Any details?
from favicons.
I'm testing on mac and it isn't working for me either. No errors are being thrown but my favicons are just not being generated. 7.0.0-beta.1 and 7.0.0-beta.4 also works for me. 7.0.0-beta.5 doesn't work for me either.
from favicons.
May you provide more details? How do you test? May it happen that you use a callback to get a result? Callbacks are not supported anymore (since beta.5).
favicons(source, options, (error, result) => { ... })
should be changed to favicons(source, options).then(result => { ... }, error => { ... })
.
from favicons.
No I didn't update my code to reflect the switch to promises so I guess that's the issue. Thanks for the heads up but I would humbly suggest that you announce these kind of changes in a changelog document, not only in the readme. Especially when you change the API itself between a beta version and the corresponding release.
from favicons.
The change also isn't reflected on the npm readme
from favicons.
Related Issues (20)
- Next release? HOT 10
- heads up: broken colors package HOT 10
- Bring back coverage report and badge HOT 1
- Can't be used with Next.js: Consider publishing non ESM modules: is a nightmare to setup and make it work! HOT 4
- Improved typescript types HOT 1
- Error When Installing Sharp and/or Favicons
- npm install favicons make http request to https://github.com/lovell/sharp-libvips/releases/download/v8.7.4/libvips-8.7.4-linux-x64.tar.gz HOT 2
- Unsupported platform coast HOT 2
- Handling a few different image files as favicon and touch icon HOT 3
- [Bug] Favicons generates null value for Android platform HOT 1
- Deprecate yandex icon? HOT 3
- Deprecate Windows 8 tile icons HOT 2
- HTML for apple-touch-startup-image HOT 1
- Add a `cacheBustingQueryParam` option for a cache busting system HOT 1
- Add Release and Changelog HOT 1
- update dependency sharp to v0.32.0 HOT 1
- `icons.<platform>.sizes` weird behaviour HOT 3
- Why there is no way to configure shortcut sizes?
- I want only the icon with the '.ico' extension to be created when it is local HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from favicons.