Keep ratio when scaling? about favicons HOT 5 CLOSED

Hello,

I have encountered the same issue when using a non-square svg file without a viewBox attribute on the tag. Adding the attribute on the same exact file solved the issue.

from favicons.

I was not able to reproduce the issue. See #360
It may happen that the issue was already fixed in master branch.

@Tofandel May you check it again?

from favicons.

@jbroutier which version do you use? May you provide a reproducible test?

from favicons.

I'm using version 6.2.2.

Sure, here it is: https://github.com/jbroutier/favicons-334 Run both src/with-viewbox.js & src/without-viewbox.js and compare the generated files in the corresponding output folder.

In the second case some of the generated favicons are not centered and have an abnormally huge padding on some sides. It looks like it's broken only when the target favicon size is bigger than the source file size.

from favicons.

@jbroutier Thanks!

from favicons.