irll / hierarchycraft Goto Github PK
View Code? Open in Web Editor NEWAn environement builder for hierarchical reasoning research
License: GNU General Public License v3.0
An environement builder for hierarchical reasoning research
License: GNU General Public License v3.0
Part of a JOSS review openjournals/joss-reviews#6468
According to JOSS requirements, there should be "clear guidelines" to "2) Report issues or problems with the software 3) Seek support". I think that for GitHub users it's obvious that one should post issues (like this one) to report problems or get support, but could you please mention this explicitly in ReadMe for potential users who are somewhat new to GitHub workflow?
There is an example of solving a planning problem in ReadMe (https://github.com/IRLL/HierarchyCraft?tab=readme-ov-file#as-a-upf-problem-for-planning) but it's incomplete. For example, when I try adding proposed lines:
problem = env.planning_problem()
problem.solve()
to Minecraft example (https://github.com/IRLL/HierarchyCraft?tab=readme-ov-file#using-the-programmatic-interface) nothing really happens. Moreover, if I try using the plan as suggested in the documentation https://irll.github.io/HierarchyCraft/hcraft/planning.html, it fails with an error (probably because no plan was built):
SequentialPlan:
Traceback (most recent call last):
File "hcraft-review/venv/lib/python3.12/site-packages/hcraft/env.py", line 402, in step
action = int(action)
^^^^^^^^^^^
TypeError: int() argument must be a string, a bytes-like object or a real number, not 'NoneType'
Could you please complete the example to get started with solving the planning problem based on Minecraft environment?
ENHSP fails on a lot of items in MineHCraft, even simple ones.
It needs to be investigated whether it is due to the agent, or to the UPF problem being poorly translated.
[
"reeds",
"wood_pickaxe",
"wood_axe",
"cobblestone",
"coal",
"leather",
"book",
"flint_and_steel",
"iron_axe",
"iron_pickaxe",
"iron_shovel",
"iron_sword",
"ender_pearl",
"diamond",
"gold_ore",
"redstone",
"diamond_axe",
"diamond_pickaxe",
"diamond_shovel",
"diamond_sword",
"gold_ingot",
"clock",
"gold_axe",
"gold_pickaxe",
"gold_shovel",
"gold_sword",
"obsidian",
"enchanting_table",
"blaze_rod",
"netherrack",
"blaze_powder",
"ender_eye",
"ender_dragon_head",
]
Good job! I enjoyed reading the paper draft (openjournals/joss-reviews#6468 (comment)) and learning more about your project. Here is the list of review remarks line by line:
I have also several general remarks.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.