[Feature Request]: Add facet + cohort legend strata order in mean plot about tern HOT 7 CLOSED

@ayogasekaram Thank you for working on that, a colleague will test the new function shortly.
For your question, I believe that alt_counts_df is always equal to df (in our case), I don't see any case when you would like to put two different datasets in the two arguments. So I think we are fine from this side, I don't think we need a warning message.

from tern.

yes it's been addressed in this PR

from tern.

Hi @legrasv, I have a PR going up for this soon so I can tag you for review. I just wanted to confirm if you have any warning message in mind in the case of the alt_counts_df? for example, if the levels for the facet_var are set in adpc for example, but the user also supplied an alt_counts_df, the same levels need to be set there for the plot legend to reflect it.

from tern.

@ayogasekaram I got this error message which I can't debug, it looks like I don't have the function sfun loaded (when I am using browser()), what is this function? how can I get it?

from tern.

@legrasv the sfun is s_summary but that default should already be set in the g_lineplot parameters. Let me take a look on my end as well!

from tern.

Dear NEST,

I found a bug in the code of g_lineplot for the strata:

matches <- sapply(unique(df_N[[group_var]]), function(x) unique(df_N[[paste0(group_var, "_N")]])[grepl(paste0("^", x), unique(df_N[[paste0(group_var, "_N")]]))])

in this piece of code, it happens that group_var contains specific regex characters and therefore the grepl will not work, example:

Browse[2]> grepl("^PART 1 \\(Period Effect\\)", unique(df_N[[paste0(group_var, "_N")]]))
[1]  TRUE  TRUE FALSE FALSE
Browse[2]> grepl("^PART 1 (Period Effect)", unique(df_N[[paste0(group_var, "_N")]]))
[1] FALSE FALSE FALSE FALSE

-> I need to tell that "()" are not part of the regex expression. I don't know how we could handle that in general. Here I have the bug with the "(", but it could happen with regex characters such as "+", ".", "[", etc.

from tern.

@ayogasekaram can this issue be closed now?

from tern.