Code Monkey home page Code Monkey logo

formatcode's People

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

formatcode's Issues

Typo in the section 1.1

The second sentence in section 1.1 currently says:
"Given that the FormatCode is contriuted to by many IHE domains"...

Change "contriuted" to "contributed"

Add missing Eye Care codes to the FormatCode IG

Issue
Two Format Codes from the Eye Care CCDA-GEE supplement and one from the EC Summary supplement need to be added to the FormatCode IG

Proposed Change
Add the following codes (from Section 5.1 of the CCDA-GEE supplement):

  • General Eye Evaluation (GEE) C-CDA Progress Note urn:ihe:eyecare:geneyeevalpn:2014 text/xml 1.3.6.1.4.1.19376.1.12.1.1.2

  • General Eye Evaluation (GEE) C-CDA Consultation Note urn:ihe:eyecare:geneyeevalcn:2014 text/xml 1.3.6.1.4.1.19376.1.12.1.1.3

Add the following code from the EC Summary Supplement

  • Eye Care Summary Record (EC-Summary) urn:ihe:eyecare:summary:2015 text/xml 1.3.6.1.4.1.19376.1.12.1.1.4

Priority:

  • Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.

Some inconsistencies in the formatCode Value Set and Code System

I have been taking a close look at our formatCode value set and codeSystem in the context of some SVCM test preparation.

This Github issue points out some inconsistencies (my view). You can correct any misconceptions.

First, I am looking here: https://profiles.ihe.net/fhir/ihe.formatcode.fhir/ValueSet-formatcode.html

The “Definition” at the top includes this statement:
“The IHE FormatCode Value set is defined to be the set of FormatCode(s) defined by IHE http://wiki.ihe.net/index.php?title=IHE_Format_Codes…”.
...and that wiki page has been scrubbed (hurray) to remove the list of codes and instead include a summary including “ This FormatCode vocabulary represents: Code System 1.3.6.1.4.1.19376.1.2.3 “ (which I believe is the equivalent of http://ihe.net/fhir/ihe.formatcode.fhir/CodeSystem/formatcode).

In Sec 3.1.1.1, the "Logical Definition" of what the value set contains includes the IHE format CodeSystem, one DICOM code for the KOS manifest, and the HL7 codes for C-CDA docs (what I would expect).

ISSUE 1: There is a slight incongruity between the text in the Definition and the Logical Definition. I think the text in the Definition at the top more accurately describes the Code System http://ihe.net/fhir/ihe.formatcode.fhir/CodeSystem/formatcode and not the Value Set http://ihe.net/fhir/ihe.formatcode.fhir/ValueSet/formatcode

====
Next, I am looking here https://profiles.ihe.net/fhir/ihe.formatcode.fhir/CodeSystem-formatcode.html

The “Definition: up top includes this statement:
"The IHE FormatCode code system with canonical URI of http://ihe.net/fhir/ihe.formatcode.fhir/CodeSystem/formatcode is defined to be the set of [FormatCode(s) define by IHE (http://wiki.ihe.net/index.php?title=IHE_Format_Codes), ..."
And this is what I would expect for IHE’s formatCode Code System.

ISSUE 2 Why does IHE’s codeSystem include the deprecated concepts with C-CDA codes having a system value of “http://terminology.hl7.org/CodeSystem/hl7-document-format-code”? It seems like they could be removed, especially since the HL7 implementation guide you link in the description include both C-CDA 1.1 and 2.1 codes, and only the 1.1 deprecated codes are in our format code code system

====

**ISSUE 3 (**documented here, even though “it’s not IHE’s problem” :-) ):
Our format code value set: https://profiles.ihe.net/fhir/ihe.formatcode.fhir/ValueSet-formatcode.html

…includes all codes defined in http://terminology.hl7.org/CodeSystem/hl7-document-format-codes

For the life of me, I cannot find a Code System with the above canonical URI.

John says,
well... that is
a) Not an IHE problem
b) really strange as the IG build finds it
c) really strange because it doesn't seem to be there
d) Not an IHE problem

Note about (c)... this link you have is a canonical URI. It is not expected to be able to produce anything in a browser. yet, often Grahame manages a huge redirect database at HL7 to redirect these things. However these codes can't be found even if one browses to http://terminology.hl7.org

I have been complaining to the HL7 terminology group for almost two years
https://chat.fhir.org/#narrow/stream/179202-terminology/topic/CDA.20format.20code.20vocabulary

Format code fix: Update Display value for RAD CDA Img Report w/ Structured Headings

Reference: https://profiles.ihe.net/fhir/ihe.formatcode.fhir/ValueSet-formatcode.html

In this latest revision of IHE format codes, we have updated the Display Names. Now the display names (mostly) follow a pattern (domain and profile acronym, eg PCC APS) (Note that the “description” (which is not sent in a code/scheme/display triplet) is more descriptive, so I'm not a fan of the change, but I'm not writing an issue for that).

REQUEST: please change the Display for code urn:ihe:rad:CDA:ImagingReportStructuredHeadings:2013. It is currently “RAD XDS-I”, which is too generic. If you followed the pattern used in DENT (DENT TEXT, DENT PDF, DENT CDA), then you would change the code to “RAD CDA” (because RAD TEXT and RAD PDF exist).

(Note, also, that there are other Display values that do not follow the pattern (e.g. "Care Management (CM), but that is not in my domain, so I am also not writing this issue about that).

codesystems now should have hierarchyMeaning

New informative message from the IG builder
CodeSystems SHOULD have a stated value for the hierarchyMeaning element so that users know the status and meaning of the code system clearly.

published ig with version 2.0.4 cannot be used for validation or in a dependen ig

when we want to use the current published formatcode package an error message appears:

oad Package hl7.terminology.r4#2.0.0
2021-04-23 11:14:09.624 [main] INFO o.h.f.u.npm.BasePackageCacheManager [BasePackageCacheManager.java:80] Failed to resolve package ihe.formatcode.fhir#0.2.4 from server: http://packages.fhir.org
2021-04-23 11:14:09.987 [main] INFO o.h.f.u.npm.BasePackageCacheManager [BasePackageCacheManager.java:80] Failed to resolve package ihe.formatcode.fhir#0.2.4 from server: http://packages2.fhir.org/packages
2021-04-23 11:14:10.784 [main] INFO o.h.f.u.npm.BasePackageCacheManager [BasePackageCacheManager.java:80] Failed to resolve package ihe.formatcode.fhir#0.2.x from server: http://packages.fhir.org
2021-04-23 11:14:11.252 [main] INFO o.h.f.u.npm.BasePackageCacheManager [BasePackageCacheManager.java:80] Failed to resolve package ihe.formatcode.fhir#0.2.x from server: http://packages2.fhir.org/packages
Installing ihe.formatcode.fhir#0.2.4 to the package cache
Fetching:Publishing Content Failed: Error reading http://profiles.ihe.net/fhir/ihe.formatcode.fhir/0.2.4/package.tgz: Input is not in the .gz format (00:45.0446)
(00:45.0451)
Use -? to get command line help (00:45.0454)
(00:45.0458)
Stack Dump (for debugging): (00:45.0463)
java.io.IOException: Error reading http://profiles.ihe.net/fhir/ihe.formatcode.fhir/0.2.4/package.tgz: Input is not in the .gz format
at org.hl7.fhir.utilities.npm.NpmPackage.readStream(NpmPackage.java:379)
at org.hl7.fhir.utilities.npm.NpmPackage.fromPackage(NpmPackage.java:370)
at org.hl7.fhir.utilities.npm.FilesystemPackageCacheManager.addPackageToCache(File

  1. ihe.formatcode.fhir does not appear in the registry , is IHE planning a package feed for their publications?
  2. it looks like the package itself is also not published under http://profiles.ihe.net/fhir/ihe.formatcode.fhir/0.2.4/, could this be added?

Entries in provenance bundles - fullUrl and .id

<entry xmlns="http://hl7.org/fhir"> <fullUrl value="http://profiles.ihe.net/fhir/ihe.formatcode.fhir/Provenance/20200724"/> <resource> <Provenance> <id value="formatcode-provenance-20200724"/>

  1. fullUrl must be either a valid reference to the resource, or a urn UUID, (or urn OID)
  2. fullUrl and Provenance.id within the entry must match

mention the old URI

the codeSystem should mention the old, and deprecated canonical URI. (Deprecated because it indicates a ValueSet as a CodeSystem)
http://ihe.net/fhir/ValueSet/IHE.FormatCode.codesystem

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.