hopson97 / asciimon Goto Github PK

$ rustup install nightly
$ rustup component add clippy-preview --toolchain=nightly
$ cargo +nightly clippy

warning: using `println!("")`
  --> src\main.rs:15:5
   |
15 |     println!("");println!("");
   |     ^^^^^^^^^^^^ help: replace it with: `println!()`
   |
   = note: #[warn(println_empty_string)] on by default
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#println_empty_string

warning: using `println!("")`
  --> src\main.rs:15:18
   |
15 |     println!("");println!("");
   |                  ^^^^^^^^^^^^ help: replace it with: `println!()`
   |
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#println_empty_string

warning: returning the result of a let binding from a block. Consider returning the expression directly.
  --> src\game\game_state\state_explore.rs:36:9
   |
36 |         state
   |         ^^^^^
   |
   = note: #[warn(let_and_return)] on by default
note: this expression can be directly returned
  --> src\game\game_state\state_explore.rs:31:21
   |
31 |           let state = StateExplore {
   |  _____________________^
32 | |             player:         Player::new(),
33 | |             last_action:    Action::NoAction,
34 | |             maps:           MapManager::new()
35 | |         };
   | |_________^
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#let_and_return

warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
   --> src\graphics\renderer.rs:106:20
    |
106 |         let sect = self.render_sections.get(section).unwrap();
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.render_sections[section]`
    |
    = note: #[warn(get_unwrap)] on by default
    = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#get_unwrap

warning: the variable `line_num` is used as a loop counter. Consider using `for (line_num, item) in data.enumerate()` or similar iterators
   --> src\graphics\renderer.rs:187:21
    |
187 |         for line in data {
    |                     ^^^^
    |
    = note: #[warn(explicit_counter_loop)] on by default
    = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#explicit_counter_loop

warning: identical conversion
  --> src\graphics\colour.rs:26:9
   |
26 | /         String::from(format!(
27 | |             "\x1b[{};2;{};{};{}m", id, r, g, b
28 | |         ))
   | |__________^ help: consider removing `String::from()`; `format!` returns a `String`
   |
   = note: #[warn(identity_conversion)] on by default
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#identity_conversion

warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
  --> src\game\game_state\mod.rs:16:44
   |
16 |     fn handle_input(&mut self, input_args: &Vec<&str>) -> ReturnResult;
   |                                            ^^^^^^^^^^ help: change this to: `&[&str]`
   |
   = note: #[warn(ptr_arg)] on by default
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#ptr_arg

warning: use of `expect` followed by a function call
  --> src\game\map.rs:44:18
   |
44 |                 .expect(&format!("Unable to open file for map {} {}", x, y));
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open file for map {} {}", x))`
   |
   = note: #[warn(expect_fun_call)] on by default
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#expect_fun_call

warning: usage of `contains_key` followed by `insert` on a `HashMap`
  --> src\game\map_manager.rs:32:17
   |
32 | /                 if !self.maps.contains_key(&pos) {
33 | |                     let map = match Map::load(map_x, map_y) {
34 | |                         None =>  continue,
35 | |                         Some(map) =>  map
...  |
38 | |                     self.maps.insert(pos, map);
39 | |                 }
   | |_________________^ help: consider using: `self.maps.entry(pos)`
   |
   = note: #[warn(map_entry)] on by default
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#map_entry

warning: you seem to want to iterate on a map's values
  --> src\game\map_manager.rs:43:25
   |
43 |         for (_, map) in &self.maps {
   |                         ^^^^^^^^^^
   |
   = note: #[warn(for_kv_map)] on by default
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#for_kv_map
help: use the corresponding method
   |
43 |         for map in self.maps.values() {
   |             ^^^    ^^^^^^^^^^^^^^^^^^

warning: single-character string constant used as pattern
  --> src\game\mod.rs:76:68
   |
76 |                     let input_args: Vec<&str> = input.trim().split(" ").collect();
   |                                                 -------------------^^^- help: try using a char instead: `input.trim().split(' ')`
   |
   = note: #[warn(single_char_pattern)] on by default
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#single_char_pattern

$ cargo run --verbose
failed to parse lock file at: /Users/antonte/prj/Asciimon/Cargo.lock

Caused by:
  expected a section for the key `root`