hop-protocol / hop Goto Github PK

The "Add Liquidity" page uses DAI in certain places where it should read arbDAI. I believe this should be more consistent. I may be wrong.

Specifically, I would imagine the 3 circles below should be changed to read "arbDAI".

The alignment of the text on the "Recent Transactions" modal is inconsistent when different networks (with different name length) are used. I believe this should be left-aligned?

There are times when our Kovan node rejects calls because of the following error:

ProviderError: Too Many Requests error received from kovan.rpc.hop.exchange
at HttpProvider._fetchJsonRpcResponse (/Users/sh/Dev/authereumorg/authereum/hop/contracts/node_modules/hardhat/src/internal/core/providers/http.ts:144:15)
at processTicksAndRejections (internal/process/task_queues.js:86:5)

I have seen this only 1 time when using the app normally. I am only able to recreate it when scripting a bunch of txs and am on the FE (probably around 1 call every 1-2 seconds, maybe).

When too many requests are received, our FE does not display balances correctly. See video. When I saw it happen naturally, it resolved itself in ~ 1 minute.

I am not sure if there is anything to do. I think we are fine in most cases. However, if we send out a popular tweet or get a barrage of traffic, this may be an issue. If this limitation is coming from our server, maybe bump the rate limit up by 2x to be safe. Open for discussion.

I believe there is not a way to copy your address in the UI. Maybe make this copyable upon click.

Actual behavior: When on the pool page with MetaMask pointed at the wrong network, refreshing the page will trigger the "change network" prompt.

Expected behavior: No prompt is shown when refreshing the page. When "Add Liquidity" is clicked, the prompt is shown if MetaMask isn't on the right network.

I believe the numbers in the "Your position" section of the "Pool" page should reflect your pool balances.

With this account, I added 500 of each token, however the numbers don't necessarily reflect that.

One other note, before adding the 500 of each token, the "Share of pool" estimate said I will own ~25% of the pool. I believe this number made sense based on my knowledge of the pool at that time. After adding 500 of each token, my pool share said I only owned 0.52%.

When you exit a "Send" confirmation, a browser alert is shown. See image below.

I believe it should simply close with no alert.

To reproduce:

• Try to send on the "Send" page
• Close the confirmation modal with escape OR clicking the "X" OR clicking off the modal
• Observe the browser alert

On the Convert page, the send button is disabled and says "Insufficient funds" but the balance shown is enough to cover the swap. MetaMask is pointed to the correct network.

For some large number values, our UI cuts off a number halfway through the number.

When adding liquidity on the "Pool" page, the "Add liquidity" button gets disabled if the number of canonical tokens (first input field) is greater than the user's balance. The button does not get disabled if the number of h tokens (second input field) is greater than the user's balance.

The "Add liquidity" button should only be enabled if the user has enough liquidity in both tokens.

When converting funds "Via Hop Bridge", nothing happens (no feedback) when you confirm the conversion modal. Additionally, no transaction is made.

There is an RPC error in the console, so I believe this is related to #20 .

Note: The transactions works on all the other "Via..." options on the "Convert" page

Note: The approval works on the "Via Hop Bridge" section.

To reproduce, convert via Uniswap on xDAI. After the transaction has been confirmed on MetaMask, the error will show up.

Not sure if this is still an issue with the new MetaMask feature to add networks.

For some reason the "Send" page is giving an RPC error when trying a simple send from Kovan to Arbitrum.

To reproduce:

• Send 0.1 DAI from Kovan to Arbitrum
• Observe error alert and RPC error in the console

I believe this just hasn't been implemented yet. The rate on the Send page is hard coded but should reflect the market rate for the given amount.

Sending sETH or sBTCfrom xDAI to either Kovan or Optimism results in an RPC error before MM pops up.

DAI works perfectly.

Significant values have been added to the pools and it looks like the arbitrage bot is either off or is not correctly handling these new values. See attached image.

There are two things to note:

• Given that this is a swap of 1 and a pool of 2.5 million, I would expect the rate to be 1
• I would imagine that the pool stats on the right should all be approximately equal

When sending more than 10,000 tokens over the xDai canonical token bridge, an error is thrown. This is a limitation of the xDai OmniBridge. You can verify that there is a per-token tx limit on the bridge by looking at the code here. Alternatively, you can read the maxPerTx value of the token here. There is no daily limit, so someone can send 10,000 tokens as many times as they want. There is a 1,000,000 token per day daily limit.

This should not matter 99.999% of the time, as users who want DAI on xDai will go through our bridge and swap, thus never hitting the canonical bridge limitation. This is an issue, however, for whales who are trying to add liquidity.

I'd imagine the best way to get around this is to remove the limitation, however this is onlyOwner. Two other options:

• Show something in the UI that informs the user (and disables the button) for amounts greater than 10,000
• Spin up our own bridge. This would work great -- it would just be one other moving part (that I'd be totally fine with).

Note:

• The mainnet bridge allows for 1,000,000,000 on popular tokens, such as DAI. https://etherscan.io/address/0x88ad09518695c6c3712ac10a214be5109a655671#readProxyContract

Now that we have additional tokens to choose from, I think we should add a token logo somewhere on the page. I'm not totally sure where they should go, but I do think having the visual representation (instead of just the text) is very powerful for something like the Syntethix tokens.

SVG Logos are here:

logos.zip

Maybe @cwhinfrey has a design suggestion. Uniswap simply places the logo the left of the symbol everywhere.

Image 1: Our current page
Image 2: Uniswap reference.

I believe the dropdown menus throughout the app should have a font type and size consistent with the un-droppeddown state. Additionally, I believe the dropdown options should be rounded, similar to the un-droppeddown option.

I have an address that has 123 L2 Canonical Dai on Optimism. The address is 0x023fFdC1530468eb8c8EEbC3e38380b5bc19Cc5d.

Their Optimism DAI balance shows NaN. I am not exactly sure why. I am happy to provide the private key if needed.

Other accounts of mine work fine. I can reliably reproduce this, but cannot nail down why this may be the case. I can provide more data if needed.

I believe these buttons, when clicked, should produce a rounded highlight, not square.

When converting "via Uniswap", point your MetaMask at Kovan and select "Arbitrum Hop Bridge" as the from bridge. Hit "Convert"

Expected behavior: Prompted to switch networks

Actual behavior: Nothing happens and no errors in the console.

Note: this is only an issue when "Arbitrum Hop Bridge" is the from bridge.

I believe it will be common for a user to copy/paste values in order to send all of their tokens. If a user does this with a value that has a comma, our UI says NaN because commas are not supported in our inputs.

Action item: format inputs in order to ignore commas

As an aside, maybe a "send max" button would be useful, similar to Uniswap. I believe we will have similar issues we had w/ Authereum WRT gas estimation if we are swapping ETH, so it may not be worth it for now.

It appears as though the "Pool" page only provides instructions on how to switch MM network and does not offer the native MM switching option.

To reproduce:

• Go to "Pool" page while on Kovan
• Try to add liquidity on xDai
• Observe modal instructions instead of MM popup

This may not be an issue. Please close if this is intended.

When approving tokens, the "Approve" modal has an "Approve all" text next to a checkbox. The check box makes it feel like it should be clickable, however it is unable to be clicked.

I think there are three possible solutions:

1. Remove the checkbox and "Approve all" text completely and just do it anyway
2. Remove the checkbox and keep the "Approve all"
3. Make the checkbox clickable (note: this would probably require some extra logic to approve an exact amount instead of all)

I'm good for anything.

Update: I see that this checkbox is not grayed out on the convert page from Kovan -> xDai. Not sure why it is greyed out elsewhere.

The transaction reverts when sending sBTC out of Optimism. sETH works fine though.

When adding large amounts of liquidity on xDAI (>1000) an error shows up after sending the transaction. It doesn't happen for smaller amounts.

When connecting a MM wallet, the pill on the top right of the page will still read "Connect a Wallet" instead of displaying the address when the user must unlock their MM account after the button press. It is important to note that the wallet is actually connected (see the balance in the picture below) even though the address is not read correctly.

To reproduce:

• Lock MM
• Go on hop.exchange and click "Connect a Wallet"
• Unlock MM (and change networks if needed)
• Observe that the wallet is connected but is not displayed on the top right pill

When swapping via Uniswap on Optimism on the Convert page, no approval is requested when it's required. This causes an error to show up when attempting to swap with out the necessary amount approved.

A user is not warned if they are trying to send more funds than they have.

Note: this should probably be handled on every relevant page.

See examples from Uniswap below:

(This was reported by a user from a DM to my Twitter).

When pooling liquidity on Optimism, you are greeted with an error that says "No token contract for Network 'Optimism'".

The same behavior happens in the console when swapping from Optimism -> anywhere else.

The error received is this line.

Note: This may be easier to resolve after network switching has been resolved, as that may play a role.

When cancelling the automated MM network switcher, our instructions to switch networks are shown.

When switching to either Optimism or xDAI, the last two screenshots show Arbitrum

Note: I see that the required data is on the top of the modal. If the images are meant to be an example (and not an exact instruction) then maybe that should be more clear

When sending a transaction, if you cancel the MM popup (instead of send), you will be greeted with an alert message. I believe we should do nothing instead of show an alert.

For reference, Uniswap does nothing.

Always up for discussion. If we keep it, my vote would be to use a human-readable error, such as "You closed the Metamask window".

EDIT: Realized this happens on many pages. Added more images, but it would be worth checking all pages.

Similar to Uniswap, people may want to "clear" their transaction cache.

The balances on the "Convert" page take ~5s to load. Incorrect balances are displayed during this time.

In the video below, you will see the flicker and the incorrect balances. My correct balances should be as follows:

• Kovan DAI: 9512.82
• Arbitrum Hop Bridge: 38.30
• Arbitrum Canonical: 10.06

Note: My MM was connected to Arbitrum during this video.

Update: Sending sBTC from Kovan -> xDai takes >10s after the spinner is done. Because of this, I think we should implement some solution, as people may get confused if that is the first action they take on Hop.

As it stands, we provide visual feedback about a swap up until the point at which a tx on the source chain is confirmed. There may be ~5 seconds after this time where the user's destination balance remains unchanged. This may confuse a user. See attached video.

I think the ideal solution would be to keep the tx pending spinner going until the funds are received on the destination chain. I believe this might be a pretty big technical task, though.

I think any solution where there is some sort of visual feedback until funds are received would be perfect. Not sure what that looks like and would like to open it up for discussion. If this seems like a non-issue, I'd be happy to close it.

To recreate, select "via Uniswap" and "Optimism" on the Convert page. Enter an amount in. No amount out will be populated.