hiradary / reoverlay Goto Github PK

Great library. big ups!

A suggestion I would make is to allow implementors to make a call that will hide all modals except for the modal requested.

Hello, 😍In Reoverlay.js you wrote snappshots, I think it's misspelling, The right one is snapshots. Thanks♥️

Hello Hirad✋, If you want, I could convert the JS to TS project and add more features.😍

Hello. I see, that you've already had types in this project, but then you removed it for some reason. Is it possible to add types for typescript support? Thnx.

First off, thanks for this awesome package. There are some instances where I don't want the modal to auto-close when the user clicks outside of the modal.

An example is: the modal displays a form where a user enters a bunch of data and then accidentally clicks outside and loses everything. I can ensure they don't actually lose anything with localStorage or some global state management solution, but I could prevent all of that with a simple option that turns off the auto-close feature on outside click.

I do recognize that I can simply implement my own ModalWrapper, but making this a core option would probably benefit a lot of people and seems very easy to implement. If you agree that this would be beneficial to the community, I also wouldn't mind making a pull request to expedite things.

Hi, i really love the way you are handling Modals.

I'm struggling to use it though with Big contents, which needs vertical scrolling.

The goal is to create a 80% width and 80% height modal with scrollable content. Am i doing something wrong or the sizing an actual problem?

Hey @hiradary, I missed CodeSandbox example on this repo, If you mind I'll add that 🤘

Would be awesome

Thanks for the great lib.

The lib already supports close on "click outside", woudn't it make sense to add close on "press esacpe key" as well?

Consider following scenario:

const SomeComponent: FC = () => {
	const {
		dispatchFileAction,
		files
	} = useFile()
	return (
	    <button
		    onClick={ (): void => {
			    Reoverlay.showModal(FileBrowserModal, {
				    files,
				    onFolderOpen: (file): void => {
					    void dispatchFileAction({
						    payload: file.key,
						    type: EFileAction.openDirectory
					    })
				    }
			    })
		    } }
		    type="button"
	    >
		    Toggle File Browser
	    </button>
	)
}

How would I correctly update properties of the used modal FileBrowserModal?

Would be a static method like Reoverlay.updateProps feasable?