Code Monkey home page Code Monkey logo

currencies's People

Contributors

chuyeow avatar douwem avatar dwilkie avatar erkde avatar hexorx avatar nilandnull avatar njvitto avatar pr0d1r2 avatar semaperepelitsa avatar superscott avatar xiazek avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

currencies's Issues

Publish v0.4.3 on rubygems.org

Version 0.4.3 was tagged nearly a year ago. Am I the only one who thinks it’s time to publish that version on rubygems.org now? Would be great if someone could do that! ☺ Thanks.

full_name attr_reader commit not released as gem?

Hi guys,

Noticed you added full_name as an readable attribute. However, the commit was in Dec '14 while the most updated gem is in June '14, so full_name is not accessible with the gem.

Any plans to release an update soon?

Exchange rate sometimes inexplicably 1.0

I've dug through the code, but I can't figure out why sometimes in my Rails application, a few currencies come out with an exchange rate of 1.0.

In an initializer, I'm setting ISO4217::Currency.base_currency = 'GBP'

Yet somehow:

>> ISO4217::Currency.from_code("EUR")
=> #<ISO4217::Currency:0xb667a3c @exchange_rate=1.0, @exchange_currency="GBP", @symbol="€", @code="EUR", @name="Euro">
>> ISO4217::Currency.from_code("EUR").load_exchange_rate
=> 0.8814
>> ISO4217::Currency.from_code("EUR").exchange_rate
=> 1.0

I understand that load_exchange_rate doesn't actually store it in @exchange_rate, I just wanted to show that it's getting it successfully from Yahoo Finance. What I don't understand is how @exchange_rate got to be 1.0 in the first place. My only call to the Currency class is in a model...

  # Value of this currency in the default currency (defined in config/initializers/currencies.rb)
  def exchange_rate
    ISO4217::Currency.from_code(iso4217_code).exchange_rate
  end

"0.0" exchange rate - 403 forbidden

I discovered the gem was returning 0.0 exchange rates, having checked the source it would seem the yahoo finances request is returning a 403:

http = Net::HTTP.new('download.finance.yahoo.com', 80)
=> #<Net::HTTP download.finance.yahoo.com:80 open=false>
>> response = http.get("/d/quotes.csv?e=.csv&f=sl1d1t1&s=EURGBP=X")
=> #<Net::HTTPForbidden 403 Forbidden readbody=true>
>> response.body
=> "<html><head><title>Yahoo! - 403 Forbidden  -- error 403</title></head><body>It has come to our attention that this service is being used in violation of the Yahoo Terms of Service.  As such", " the service is being discontinued.  For all future markets and equities data research", " please refer to finance.yahoo.com.</body></html>"

Release new version v0.4.4

@hexorx Hey! Would it be possible to release a new version of the gem with all the updated countries?

Is there any way I could help with that?

Is this project still being maintained?

Hi. First of all, thanks for creating the countries and currencies gems.

I've a question—is the currencies gem still being maintained? There have been no PRs merged since late Feb 2014.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.