grssam / auto-complete Goto Github PK

If the user types something new, or the match percentage of the current query with the results shown in Awesome bar popup is low, then we should suggest for a Google search of that word, either as the first option or the second.

Any further plan for this add-on?
What about make it localable at next step?
and please look into this bug:
#23

I'd love if there were a option not to suggest any keywords. Just auto-select the first result and instant preview.

It seems it needs the option "Suggest to search for the input" to be enabled, as Rodze pointed out. Also, I can't get it to instant preview any entries by mousing over them, only by using the keyboard arrows for navigating through the entries.

Try to preview the page when suggesting to a domain or/and when suggesting for search.

The search suggestion does not appears just when the query starts having no result. Instead it appears in the next keypress, although on pressing ENTER key, the search happens.

Description:
Add an option to prerender the current selection off-screen without showing it in the content area.

Explanation:
Chrome used to have an instant preview which was similar to the one in AC but Google removed it and implemented prerendering instead for the simple reason that it is incredibly distracting for many users to have a constantly changing content area while going the the results in the AwesomeBar. But it would be still nice to get the boost in page loading (at the expense of bandwidth and CPU cycles) by starting to render the page off-screen and showing it in case the user selects the corresponding entry.

ways to reproduce:

1. open a new tab
2. click any URLbar dropdown menu item
3. Firefox can not open this page.
4. Disable AC will work.

in the newest Nightly 31.0a build

Steps to reproduce:

1. Open "Manage Search Engines..." in the search field
2. Add a keyword to a search engine of your liking
3. Use the keyword to initiate a search in the location bar

Actual result:
I'm being redirected to the Google search. The keyword is just a regular part of the search string passed to Google search.

Expected result:
A search should be initiated with the search engine which is associated with the keyword.

I don't agree with this bit:

    if ((selectionStart == 0 || selectionStart == selectionEnd)
      && selectionEnd == gURLBar.value.length && !popup.mPopupOpen) {
        async(function() {
          window.gBrowser.selectedBrowser.focus();
        }, 50);
        return;
    }

This makes it blur the address bar when the pointer is at the end of the typed url, but sometimes I want to reset the url by hitting esc and keep it focused, and when the pointer is at the end I can't because of that.

Also, most of the action you perform in that listener the browser already does by itself, so I think a better alternative would be this listener:

listen(window, gURLBar, "keydown", function(event) {
  switch (event.keyCode) {
    case event.DOM_VK_ESCAPE:
      if (gURLBar.value == window.gBrowser.selectedBrowser.currentURI.spec) {
        async(function() {
          window.gBrowser.selectedBrowser.focus();
        }, 50);
        return;
      }
      break;
  }
});

This way it only blurs when the address bar has the original url, and if not it performs the other actions which are browser defaults and therefore saving you the need for further checks and actions, possibly even resolving any potential incompatibilities with any other functionality or even other add-ons that might depend on the esc key event to propagate.

What do you think?

I need to ask you a favor, there's a few incompatibilities with my own add-on Omnibar Plus. Most of them I have already fixed on my end and am about to release an updated version with them. However there's one I can't fix on my end. I was hoping you could do it in Auto-Complete.

It's very simple, in one of the "keydown" listeners for the gURLBar, just replace the line

375 if (lastSearch != gURLBar.textValue.trim() && !searchSuggestionDisplayed)

with

375 if (lastSearch != gURLBar.textValue.trim() && !searchSuggestionDisplayed && (!gURLBar.OmnibarPlus || !gURLBar.OmnibarPlus.organizing))

The reason for this is my handlers change the value of the address bar on certain conditions, so that statement would return true and reset the value of popup.selectedIndex to -1, thus preventing me from being able to delete the entry I want. This way, the index would be reset when that feature of Omnibar Plus is also enabled and since my handlers also reset the index of the popup appropriately, this doesn't cause any problems to Auto-Complete.

Handle cases like 'g word' etc, i.e. inbuilt searching keywords.
Find out other edge cases

If you check/enable the "suggest to search for the input", the Enter key(after paste or type the website url in the address bar) will do nothing for a website you never visited, the web site won't be loaded in Firefox anyhow.

But if you unchecked it, it won't auto complete the address bar(such asyou type github, it won't complete it into github.com in the address bar, you have to type all github.com or choose from the drop list manually).

I don't know it is a bug or not.

If the user visits his account page on github.com more often than the domain itself, then typing"gi" should not auto complete to "gi[thub.com]" but to "gi[thub]" with the link to his accounts page selected in the popup.

Bugs:
1.When I uncheck the "auto select the firest result" box, it seems that when I enter something and press the enter key to search or open the link, the first thing is showing the blank page, then opening the actual page.While actually should turn to the page directly.
2. a little comflict with "Hardware acceleration". I am using an old PC, and turn off the HA because my intergrated Videocard does not support HA, but I finded it that sometimes I close all the tab(randomly) and remains the blank page, the page was all black, clicking the close button on this tab will get it white. So I have to turn on the HA althought it does nothing. This happens randomly,not always.
Feature Request:

1. add an option to open the link on a new tab, not override the current opened tab.
   2.support more search engines. Currently this add-on only shows the suggestions of google. Will you have a plan to support more engines to show their suggestions or let users customize like what Instant quick search add-on does?

If I type "fa" and it auto completes to "fa[cebook]" then I press TAB to Auto complete to "facebook" then I press SPACE and type "g".
Then that "g" should not auto complete to the most favorable word related to "g" i.e. "github", because first word is Facebook, the second word should be in relation to the first word, if possible. In this case it should auto complete to a user name on Facebook, lets say "g[regory]" with the popup displaying the first result as the page to the Facebook profile of gregory auto selected.

(In continuation from my previous issue) I think the instant preview should happen every time you select a new entry in the list, either by hovering it with the mouse or surfing through the list using the up and down keys or tab, previewing that currently active entry, not previewing only the suggested domain. Or is there a reason you've made it this way only?

Can't enter "2012" in the url bar. It's "press" enter, load site: "http://2012/" by itself.

Steps:

1. Try to enter "2012";
2. even before you stop, browser will load page with "can't connect" error.

My Auto-Compleate settings page - https://dl.dropboxusercontent.com/u/13258790/Screenshots/2014-06-01%20-%20Oleg%20Z.%20-%20140314.png

Page with loaded "http://2012/" - https://dl.dropboxusercontent.com/u/13258790/Screenshots/2014-06-01%20-%20Oleg%20Z.%20-%20134322.png

Hello,
as the title says, this plug-in erases what you already typed on the address bar when the focus of the window changes. The behavior that it should have, should be the same as when you switch a tab; the content is preserved and is automatically selected.

Disabling the plug-in fixes the problem.

Actually, I have posted this issue on my last open report, but not see your reply for several days.

Hi,problems of version 3.2.

After update to 3.2, I found that when I enter Chinese character(likely any non-western character) like "爱情公寓", it just open www.爱情公寓.com instantly.That is an unvalid URL format.Actually it should suggest from my bookmarks or open google search result as a search keyword.Then I found that inputting "iphone" will automactally open www.iphone.com which is unwant and inputting "iphone中文网" will still open www.iphone中文网.com.
3.1 is just OK.
It is likely that the URL autofill and autocomplete feature has failed. I can not get any URL autocomplete suggestion like before.

reproduce this bug on my computer(Firefox 17 aurora):

1. disable instanly preview every result of awesomebar popup on hover/up/down option.
2. keep an open tab and click the new tab button(a "+"like button) on its right to open a new tab.
3. the urlbar gets focus and shows "Go to a page" in its container.
4. click the dropdown arrow to show its results.
5. press delete key won't delete any of the results.

disable or uninstall the add on will fix this.

All the complex computational parts should be done in background thread so that it does not hinder the performance of Firefox. i.e. the breadth first and depth first search, etc.

With Auto-Complete enabled is impossible to open about:config or any other about: page.

The search suggestion stays put if u press delete key, even if the query has some matches now.

I like how you seem to have merged together most of the prospector add-ons, I haven't really explored this fully yet but I'm hoping it truly does bring improvements over them.

I believe the "Provides top 5 search suggestions based on the input text using Google Auto Complete" seems to conflict with other add-ons like Omnibar and Peers, when I enable this feature in the Auto-Complete page of the add-ons manager (and restart firefox), no suggestions from these add-ons are shown. Of course eventually I would choose between either Omnibar's suggestions or AC's suggestions, but still until I disable one or the other they should still both appear; however they never appear, neither do the Peers link suggestions which is something I find even most important as in this case it's not a one or the other case.

I haven't checked the source code yet but I'm guessing you're probably overriding these add-ons own components and probably several others as well with similar features (I'm also remembering FastestFox off the top of my head).

I think it's something you have to look at. I have to admit something though, this is probably a feature I still wouldn't use in its current state, it only shows these search suggestions if there are no entries in the suggestions popup, I'd only use it if they appeared always, regardless of how many entries there are in the list, but this is a personal taste I guess.