Code Monkey home page Code Monkey logo

Comments (26)

grssam avatar grssam commented on July 17, 2024

Thanks for the bugs.
About the feature request :

  1. The url can be loaded in a new tab by pressing Alt + Enter , it is the default key combination of firefox. Though I will add the option.
  2. Only the suggestions are shown via google (as google has a free to use suggestion service) but the urls all open in the default engine only. If you have your default engine as Yahoo, then the instant preview or the popup result would say : Search on Yahoo. and the instant preview will load the yahoo page.
    Thanks for the feedback

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Thanks for your reply.

  1. I already knew ALT+ENTER will load a page in a new tab, but addding an option would be nice because people use Enter much more freqently than ALT+ENTER.
  2. Some other engines also provide free suggestion urls, for example, some engine and suggestion url are built-in in instant quick search add-on. However, the add-on is perfect with Google.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Several bugs of handling Unicode characters(like Chinese):

  1. I entered "tu", it will suggest tudou.com from my bookmark or the history, while "dou.com" is blue color which means "dou.com" is suggested by the add-on. But then I enter Unicode Characters "土豆", it still suggests "土豆dou.com" while it's not a valid url. See the screenshot below:
    http://i.minus.com/ib6xdVXnpHd4I.png
    2.I entered "土豆", it should suggest with "土豆网" from my bookmark's name with blue color of "网", but actually it auto completes with "土豆网", the "网" is the same color of "网". See the screenshot:
    http://i.minus.com/i0DBZKjwjBZUD.png

The 2 points above happens with other Unicode characters I enter, not a individual example.

Three. When I enter some inputs(Unicode or not), there are some transparent space below the google search suggestions. This not happens in version 2.6 or earlier. Here is the screenshot:
http://i.minus.com/iYZ4ETXfg6bUd.png
Four. Sometimes when I enter a keywords(Unicode characters or not), it shows inrelavant result from history. See the screenshot:
http://i.minus.com/ibsFOmHCE3Ol74.png
In the screenshot, "min" is my input, but it suggests the remaining Unicode characters with their color blue. Actually, there is no result we could get like this from history or bookmarks or google suggestions.
By the way, I am a Chinese user and I hope Auto Complete will work perfectly with my mother language.

from auto-complete.

grssam avatar grssam commented on July 17, 2024

I will look into problem 1. But problem 2 is caused by the fact that gURLBar.setSelectionRange(start,end) does not work properly on unicode character.

The transparent space below must be out of the view by default right ?. As I contract the search suggestion, the transparent space remains below. Unicode characters are hard to handle. I will look into localizing the add-on , or some other approach to handle them.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Yes. The transparent space must be a bug because it does not happens in 2.6 and earlier.
Unicode character handling is really not easy, Firefox Awesomebar do it well just because its function is basic.
As an enhancement tool for Awesombar, Auto Complete may not escape looking into handling Unicode characters.
What does localizing the add-on mean? I have extracted the strings from options.xul and localized it into zh-CN, but the issues are still there. The localized version is here: http://www.box.com/s/xulmkmrv92i3g9r1xexg
One more advise: have a look at the order of auto complete suggestions which is a blue color.For example, I have a bookmark whose name is abchome, url is abcexample.com. Which should be suggested when I enter "abc"? I hope it is the "abcexample.com" not "abchome". This should be considered espacially when I uncheck "auto select the first result", and when it suggested the abcexample.com, I can directly press enter to open the suggested domain.
Another problem:When I uncheck "auto select the first result",and input "box" in the urlbar,it suggests "box.com" where ".com" is blue. That is fine. But when I delete ".com" and press ENTER, nothing happens. The "box" should be started for search with Google as a keyword. If I enter some word with no matched results in the popup and press ENTER, it can jumped to the google search result page.

from auto-complete.

grssam avatar grssam commented on July 17, 2024

Appearance of abcexample.com instead of abchome is totally based on the user history. If you visit abcexample.com more often, then that url will appear before abchome.
Also this is just one type of example you provided. But when you generalize the approach, like what if the bookmarks was not pointing to the domaib, but to absexample.com/home/user/forum.php?asd=th , then your approach will fail.
So if the user visits a bookmark more often, it autocompletes to the bookmark only.

I will try to improve and adjust the algorithm to better support unicode characters. Should have something by monday.

from auto-complete.

grssam avatar grssam commented on July 17, 2024

I have uploaded version 2.9 on AMO. I hope it fixes many bugs that arose from version 2.8.
I will start working on hover to preview and open in new tab from monday.
Cheers.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Thanks, the transparent space bug is fixed.
Please have a look at problem 1 and another problem I mentioned above when you have time.
Another problem:When I uncheck "auto select the first result",and input "box" in the urlbar,it suggests "box.com" where ".com" is blue. That is fine. But when I delete ".com" and press ENTER, nothing happens. The "box" should be started for search with Google as a keyword. If I enter some word with no matched results in the popup and press ENTER, it can jumped to the google search result page.

from auto-complete.

grssam avatar grssam commented on July 17, 2024

Issue 1 :

1.When I uncheck the "auto select the firest result" box, it seems that when I enter something and press the enter key to
search or open the link, the first thing is showing the blank page, then opening the actual page.While actually should turn
to the page directly.
I didn't really get this one . Can you explain a bit more ?

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

When I enter something like box, it suggests box.com,so I press ENTER to open box.com, but the URL shows nothing but "Go to a page", then go to the box.com page. The interval here is about 1 second, something like when the page is loaded at the background(instant preview), the interval is obvious. After loaded, the page shows immediately next time I open the suggested box.com.
Another bug? After installing 2.9, the built-in "about:" service like about:config,about:support and more can't work, uninstalling should fix this.

from auto-complete.

grssam avatar grssam commented on July 17, 2024

Regarding about: pages, the first results is search suggestion, but if you press escape or anything else, you should be able to go to about: pages .
I will try to improve the procedure a bit more.
try typing about:memory , hit escape to close the popup then press enter.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Press escape after inputing about:config is really annoying.I have uncheck "auto select the first result". Former version seems well.

from auto-complete.

grssam avatar grssam commented on July 17, 2024

After further testing, I find no problem in going to any of the about: pages whatever settings I have done.
Even without pressing escape. Please check.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Still the same, pressing about:config following space key would open about:config page. Otherwise, when I have matching results of "about:config" from Awesomebar popup, nothing happens. If I enter about:support with no matching result, it will show a suggestion and pressing ENTER will bring me to the about:support page. Right now, I have to press ESC first or add a SPACE key to open about:config page.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Thanks for your quick response. It is the problem of instant preview. I'm the guy reporting the issue on AMO.

from auto-complete.

grssam avatar grssam commented on July 17, 2024

Yeah I figured that out. Its not the problem of instant preview, but instant preview everywhere
I'll fix it when I get back to my room.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

stop loading when there is a huge history.
My size of hisory is about 3.0MB.When I search "google code chinalist",it stops responding.Then I got a prompt saying you have a busy js from chrome://.../bindings/autocomplete.xml.
Maybe when there are many matched results in history, the browser will lose its responsiveness.
Then I turned off the global option of URL auto complete feature that came out from 3.0, I didn't encounter any issue.
http://i.minus.com/ixwr9pcEWCMo4.png
another busy js prompt:
http://i.minus.com/i7mTnA9ymnJh9.png

from auto-complete.

grssam avatar grssam commented on July 17, 2024

My history size is around 9 mb.
I never get this Issue
And more importantly, My script never even queries the history on every Location Bar input. It stores all the keyword on Firefox Start using a Worker, so its off the main thread so no performance issues.
The fetching of awesomebar results is still done by firefox itself, not my faultit is.
I just tell the awesome bar to search for the word, after that its awesomebar who is responsible for everything.
Even the search results I show are through another thread, so belive me, there is no scope of hangs. and I have got none , not even once.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Thank you for your explanation.
But I still have no idea how to deal with the problem.
Following your tips, I trid to open firefox's safe mode allowing only Auto Complete enabled. But I still get the 2nd screenshot when entering "google code chinalist". I have do this for several times. About on the 3rd times, I will get this prompt.
The prompt says there is a busy js cause the problem called "resouce:///modules/XPIProviders.jsm->...../[email protected]!/bootstrap.js:719" and let me choose to continue or stop the js.
So these make me feel there is something wrong with Auto Complete.More importantly, after I disable Auto Complete or turn of the first URL auto complete opntion and use the Awesomebar's default behavior, I won't get any problem from then on.

from auto-complete.

grssam avatar grssam commented on July 17, 2024

Thanks for exactly pin pointing the line number. Now I see the problem, and why it occurs only on some specific inputs.
I will fix it right away.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Sometimes still trigger instant preview of google search when about:supoort or similar URL was input.
Another advice:
Would you consider to add a TAB key to navigate the popup results in addition to the existing hover/up/down keys?

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Sometimes When I input a keyword in URLbar,it immediately triggers a google search with this keyword,actually what I want is to open one of the dropdown list results. All the matched URL in the dropdown list became unclickable.

Sometimes it still triggers google search when I enter some of the "about:" pages.

Firefox 13 will support in-line url auto complete feature.Do you have any plan?

from auto-complete.

grssam avatar grssam commented on July 17, 2024

I had to disable it because it was misbehaving with the delete and other actions of this add-on. Moreover, it only auto completes urls, which this add-on provides already.

The sometimes unusual behavior that you are saying happens because firefox is taking too long to display the results based on the input text in the address bar. I was searching for a solid way to handle the google search suggestions so that this never happens, but did not find one. I will keep thinking of ways to tackle this.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Sometimes there is a transparent white layer on the actual webpage.This happens when instant preview of a page starts.
http://i50.tinypic.com/ba6c2.jpg

Now 14.0b support in-line URL autocomplete feature. Since it may be conflict with the one you provide, I think the add-on should automatic disable this feature when it's enabled.

from auto-complete.

grssam avatar grssam commented on July 17, 2024

This layer should automatically get removed, if you press escape, or enter or any other action that involves either going to the site that was in the urlbar, or not going to it and returning back to original site.
And yes, I change the pref of inline autocomplete to off, and change it back to on after uninstalling if it was on before installing of the add-on.

from auto-complete.

fang5566 avatar fang5566 commented on July 17, 2024

Hi,problems of version 3.2.

After update to 3.2, I found that when I enter Chinese character(likely any non-western character) like "爱情公寓", it just open www.爱情公寓.com instantly.That is an unvalid URL format.Actually it should suggest from my bookmarks or open google search result as a search keyword.Then I found that inputting "iphone" will automactally open www.iphone.com which is unwant and inputting "iphone中文网" will still open www.iphone中文网.com.
3.1 is just OK.
It is likely that the URL autofill and autocomplete feature has failed. I can not get any URL autocomplete suggestion like before.

from auto-complete.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.