Comments (5)
What's the actual shipped artifact here? The CMake article doesn't say.
https://stackoverflow.com/a/73601836 says that modules are not ready for binary distribution.
from prefab.
@DanAlbert Still .so
or .a
for a library. And the files in FILE_SET
in type CXX_MODULES
for cmake (module interface unit, files that declare export a module). You can verify this by performing a cmake install
on a cmake project that uses c++ modules.
from prefab.
But you're asking for a change in the distributed artifacts here. Which additional artifacts need to be distributed? As best as I can tell from the article you linked, it's source.
from prefab.
@DanAlbert well, we can distribute sources, in the case where the module interface unit and the module implement unit are in the same file. But we can also split them into different files. For example:
module interface unit foo.ixx:
export module foo;
export void test();
export struct Bar {
Bar();
};
module implement unit foo.cxx:
module foo;
void test() {}
Bar::Bar() {}
then when we compile libfoo.so
, we can only distribute foo.ixx
, and when we place it into the include directory, prefab can distribute it. So actually we don't need to do extra support to support it. However, we can also scan public CXX_MODULES FILE_SET
to identify which files are module interface units and need to be distributed.
from prefab.
Ah, that was the missing piece. Thanks!
I guess the next bit of confusion is why the work you did in #181 (automatically filtering includes by extension to determine whether it's a module interface or a regular header) isn't something built in to CMake.
from prefab.
Related Issues (20)
- [BUG] Start signing com.google.prefab:cli:2.0.0 artifacts HOT 3
- [BUG] Library not exposing c++ symbols, still enforcing its STL in the abi.json HOT 3
- [FR] Model runtime-only dependencies HOT 9
- [FR] [QUESTION] How to model optional dependencies? HOT 7
- [BUG] prefab should set LINKER_LANGUAGE property for static libraries HOT 3
- use enable_language as needed in cmake outputs? HOT 3
- [BUG] when used prefab, the module aar will have duplicate so. The one in the jni/lib, A another one is in the prefab dir. HOT 2
- [FR] export_preprocessor_defs and export_includes HOT 9
- [FR] Support app module denpends on another module which all have C/C++ code. HOT 2
- [FR] Request ability to build prefab on apple silicon: fail to get a suitable JDK HOT 1
- [FR] Add support for riscv64 HOT 1
- [FR] add better handling of whole-archive style libraries HOT 1
- [BUG] ndkports: Pull Request: Create parent directory before trying to extract file from dependency aar HOT 2
- [FR] Please revive the project HOT 1
- [BUG] CMake packages and imported targets naming incompatible with upstream HOT 1
- [FR] Bundle sources with prefab archive HOT 3
- [BUG] Prefab libraries not being included in any app on my system only HOT 4
- [PKG]
- [PKG]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prefab.