Code Monkey home page Code Monkey logo

Comments (3)

DanAlbert avatar DanAlbert commented on June 2, 2024

I suspect this is a trivial fix since the abi.json already describes the STL requirement.

from prefab.

madebr avatar madebr commented on June 2, 2024

As an aside, it would also be useful to check inside the SDL2Config.cmake config file whether the CXX language is actually enabled.
Because if it is not, the build process will fail at a later time.
See e.g. this issue I created earlier this year.

I think the cmake config file might need something like:

include(CheckLanguage)
check_language(CXX)
if(NOT CMAKE_CXX_COMPILER)
    message(WARNING "SDL2 requires CXX, but it not enabled.")
endif()

CheckLanguage documentation

Or skip the warning and do enable_language(CXX) yourself.

from prefab.

madebr avatar madebr commented on June 2, 2024

I think, instead of LINKER_LANGUAGE, the imported targets should set IMPORTED_LINK_INTERFACE_LANGUAGES.

from prefab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.