Comments (3)
I suspect this is a trivial fix since the abi.json
already describes the STL requirement.
from prefab.
As an aside, it would also be useful to check inside the SDL2Config.cmake
config file whether the CXX
language is actually enabled.
Because if it is not, the build process will fail at a later time.
See e.g. this issue I created earlier this year.
I think the cmake config file might need something like:
include(CheckLanguage)
check_language(CXX)
if(NOT CMAKE_CXX_COMPILER)
message(WARNING "SDL2 requires CXX, but it not enabled.")
endif()
CheckLanguage
documentation
Or skip the warning and do enable_language(CXX)
yourself.
from prefab.
I think, instead of LINKER_LANGUAGE
, the imported targets should set IMPORTED_LINK_INTERFACE_LANGUAGES
.
from prefab.
Related Issues (20)
- [PKG] pdfium
- [FR] set `LOCAL_ALLOW_MISSING_PREBUILT` for ndk-build for NDK r24+
- [FR] explicit ABI split for sanitized libraries?
- not compatible library issue HOT 4
- Use prefab from build.gradle to publish a precompiled library. HOT 1
- [BUG] Start signing com.google.prefab:cli:2.0.0 artifacts HOT 3
- [BUG] Library not exposing c++ symbols, still enforcing its STL in the abi.json HOT 3
- [FR] Model runtime-only dependencies HOT 9
- [FR] [QUESTION] How to model optional dependencies? HOT 7
- use enable_language as needed in cmake outputs? HOT 3
- [BUG] when used prefab, the module aar will have duplicate so. The one in the jni/lib, A another one is in the prefab dir. HOT 2
- [FR] export_preprocessor_defs and export_includes HOT 9
- [FR] Support app module denpends on another module which all have C/C++ code. HOT 2
- [FR] Request ability to build prefab on apple silicon: fail to get a suitable JDK HOT 1
- [FR] Add support for riscv64 HOT 1
- [FR] add better handling of whole-archive style libraries HOT 1
- [BUG] ndkports: Pull Request: Create parent directory before trying to extract file from dependency aar HOT 2
- [FR] Please revive the project HOT 1
- [BUG] CMake packages and imported targets naming incompatible with upstream HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prefab.