Comments (9)
That's no problem with me.
We have a workaround (use target_link_libraries
). It's not perfect, but it works.
from prefab.
Great. I've bundled up the two FRs and the bug you just filed into a GitHub Project to track a 2.1.0 release. You'll have to take my word for that, because apparently I don't have the permissions to make that publicly visible :(
from prefab.
Do you mean runtime-only dependencies?
from prefab.
I think so, yes.
In this case, libpng16.so
-> libz.so
, I mean a runtime-only dependency that should always be satisfied.
from prefab.
I'll need to think about this a bit. I don't know if CMake is capable of expressing those constraints, and I'm fairly certain ndk-build is not. Hopefully I'm wrong and we can use those mechanisms to convey this info, otherwise this is going to be mostly if not all a feature of whatever system integrates prefab (AGP in your case). Prefab probably needs to carry the metadata to support that though.
from prefab.
I just encountered this cmake property: ANDROID_NATIVE_LIB_DEPENDENCIES
.
Does the android build system respect this property?
If it does, this can also fix #160
from prefab.
The docs don't say that property actually does anything, so hard to say. I've never encountered it before, but it's worth a shot.
from prefab.
Too bad. It is not used when creating the .apk.
I replaced these lines with:
set_target_properties(sdlcross PROPERTIES ANDROID_NATIVE_LIB_DEPENDENCIES SDL2_image::external_libpng)
and removed build
and .cxx
to make sure no old state was kept..
from prefab.
btw, I'm not sure when someone will be free to implement either of these FRs. I'm plenty convinced of the need, but it'll be a bit before anyone is free to investigate.
Once someone is available, I suspect it will take quite some time for those to land since it will probably require a trip through the AGP release cycle. We can fix and ship Prefab fast, but AGP's a much larger product and has an appropriately larger release process. If the fixes can happen entirely in Prefab and don't require AGP involvement it could probably ship within days of being implemented, but I think is very unlikely, given that it's a packaging issue and that's mostly out of prefab's hands.
Probably not what you wanted to hear, but probably better than not knowing.
from prefab.
Related Issues (20)
- [BUG] Start signing com.google.prefab:cli:2.0.0 artifacts HOT 3
- [BUG] Library not exposing c++ symbols, still enforcing its STL in the abi.json HOT 3
- [FR] [QUESTION] How to model optional dependencies? HOT 7
- [BUG] prefab should set LINKER_LANGUAGE property for static libraries HOT 3
- use enable_language as needed in cmake outputs? HOT 3
- [BUG] when used prefab, the module aar will have duplicate so. The one in the jni/lib, A another one is in the prefab dir. HOT 2
- [FR] export_preprocessor_defs and export_includes HOT 9
- [FR] Support app module denpends on another module which all have C/C++ code. HOT 2
- [FR] Request ability to build prefab on apple silicon: fail to get a suitable JDK HOT 1
- [FR] Add support for riscv64 HOT 1
- [FR] add better handling of whole-archive style libraries HOT 1
- [BUG] ndkports: Pull Request: Create parent directory before trying to extract file from dependency aar HOT 2
- [FR] Please revive the project HOT 1
- [BUG] CMake packages and imported targets naming incompatible with upstream HOT 1
- [FR] Support c++ modules HOT 5
- [FR] Bundle sources with prefab archive HOT 3
- [BUG] Prefab libraries not being included in any app on my system only HOT 4
- [PKG]
- [PKG]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prefab.