Code Monkey home page Code Monkey logo

Comments (9)

madebr avatar madebr commented on July 18, 2024 1

That's no problem with me.
We have a workaround (use target_link_libraries). It's not perfect, but it works.

from prefab.

DanAlbert avatar DanAlbert commented on July 18, 2024 1

Great. I've bundled up the two FRs and the bug you just filed into a GitHub Project to track a 2.1.0 release. You'll have to take my word for that, because apparently I don't have the permissions to make that publicly visible :(

from prefab.

DanAlbert avatar DanAlbert commented on July 18, 2024

Do you mean runtime-only dependencies?

from prefab.

madebr avatar madebr commented on July 18, 2024

I think so, yes.
In this case, libpng16.so -> libz.so, I mean a runtime-only dependency that should always be satisfied.

from prefab.

DanAlbert avatar DanAlbert commented on July 18, 2024

I'll need to think about this a bit. I don't know if CMake is capable of expressing those constraints, and I'm fairly certain ndk-build is not. Hopefully I'm wrong and we can use those mechanisms to convey this info, otherwise this is going to be mostly if not all a feature of whatever system integrates prefab (AGP in your case). Prefab probably needs to carry the metadata to support that though.

from prefab.

madebr avatar madebr commented on July 18, 2024

I just encountered this cmake property: ANDROID_NATIVE_LIB_DEPENDENCIES.
Does the android build system respect this property?

If it does, this can also fix #160

from prefab.

DanAlbert avatar DanAlbert commented on July 18, 2024

The docs don't say that property actually does anything, so hard to say. I've never encountered it before, but it's worth a shot.

from prefab.

madebr avatar madebr commented on July 18, 2024

Too bad. It is not used when creating the .apk.

I replaced these lines with:

set_target_properties(sdlcross PROPERTIES ANDROID_NATIVE_LIB_DEPENDENCIES SDL2_image::external_libpng)

and removed build and .cxx to make sure no old state was kept..

from prefab.

DanAlbert avatar DanAlbert commented on July 18, 2024

btw, I'm not sure when someone will be free to implement either of these FRs. I'm plenty convinced of the need, but it'll be a bit before anyone is free to investigate.

Once someone is available, I suspect it will take quite some time for those to land since it will probably require a trip through the AGP release cycle. We can fix and ship Prefab fast, but AGP's a much larger product and has an appropriately larger release process. If the fixes can happen entirely in Prefab and don't require AGP involvement it could probably ship within days of being implemented, but I think is very unlikely, given that it's a packaging issue and that's mostly out of prefab's hands.

Probably not what you wanted to hear, but probably better than not knowing.

from prefab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.