Code Monkey home page Code Monkey logo

Comments (8)

natir avatar natir commented on May 30, 2024 1

Very nice work @rchikhi I create a pull request to update bcalm build in bioconda and merge it when all check was passed.

Follow pull request bioconda/bioconda-recipes#16213 to be notify when it's merged in bioconda

from bcalm.

natir avatar natir commented on May 30, 2024 1

With not yet merge bioconda version of bcalm installable with this command:

conda install -c https://63640-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages bcalm

I didn't reproduce bug

from bcalm.

ctb avatar ctb commented on May 30, 2024 1

from bcalm.

ctb avatar ctb commented on May 30, 2024 1

I have verified that with a regular conda install, it is now fixed. Thank you again!

from bcalm.

rchikhi avatar rchikhi commented on May 30, 2024

hmm yeah. On my computer: master branch is fine, binary v2.2.1 on github is fine, but I confirm that conda's version still has the bug.

Conda's binaries v2.2.0 and v2.2.1 oddly have the same size but they're not bit-equal:

-rwxrwxr-x 1 rayan rayan 30628741 Oct 28  2018 /home/rayan/miniconda3/pkgs/bcalm-2.2.0-hd28b015_3/bin/bcalm
-rwxrwxr-x 1 rayan rayan 30628741 Dec 26  2018 /home/rayan/miniconda3/pkgs/bcalm-2.2.1-hd28b015_0/bin/bcalm
$ diff /home/rayan/miniconda3/pkgs/bcalm-2.2.0-hd28b015_3/bin/bcalm /home/rayan/miniconda3/pkgs/bcalm-2.2.1-hd28b015_0/bin/bcalm 
Binary files /home/rayan/miniconda3/pkgs/bcalm-2.2.0-hd28b015_3/bin/bcalm and /home/rayan/miniconda3/pkgs/bcalm-2.2.1-hd28b015_0/bin/bcalm differ

I figured the culprit:
https://github.com/bioconda/bioconda-recipes/blob/master/recipes/bcalm/build.sh#L8

That conda's bcalm v2.2.1 is built using an ooold gatb-core, one that still has the 2018 bug.

@natir, a fix would be to do a git clone https://github.com/GATB/gatb-core.git && git checkout f25f57bb65db0870ec3c5b14af5e694c7941f567 there.

I keep forgetting that conda distributes a binary that it compiles, not the binary that's from github release.

Apologies for the zombie bug @ctb!

from bcalm.

ctb avatar ctb commented on May 30, 2024

from bcalm.

natir avatar natir commented on May 30, 2024

This version of bcalm's build was merge in bioconda I hope the trouble was fix. If you have another trouble please feel free to tag me in the issue.

from bcalm.

ctb avatar ctb commented on May 30, 2024

from bcalm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.