gaspardpetit / base64 Goto Github PK

Since it's so omnipresent, it would be great to have a test/benchmark for a Boost.Archive implementation, as listed in e.g. http://stackoverflow.com/questions/7053538/how-do-i-encode-a-string-to-base64-using-only-boost#7053808

I don't have a patch for it at this time, sorry!

The libb64 submodule has no URL set so it's necessary to delete libs/libb64 before invoking git submodule update --recursive --init. Consequently, the cdecode.c/cencode.c files in the libb64 test folder can't find their respective header files, which breaks the build. A workaround is to remove the libb64 test from the project, but it would be better if it didn't fail in the first place.

As the author of cppcodec, I'd like to say thanks for putting this out! The main objective for my library was to provide a decent API with workable performance, so it's good to know that it doesn't fail entirely on that front. However, according to your graphs it could be better.

I only had the opportunity to time it on gcc and clang, both Linux. Since you're running your tests on MSVC, I was hoping you could try something out for me.

I found that after a refactor, cppcodec performance was noticeably slower than before. I traced this down to GCC not inlining some of the lowest-level templated functions (cppcodec is a template-crazy beast), and adding __attribute((always_inline)) made it go back to its original, okay performance. (That attribute also works on clang.)

I wonder whether the same thing is happening with MSVC. However, lacking a Windows system, I can't test it. So here's my request: Would you be able to add another line for MSVC's __forceinline to https://github.com/tplgy/cppcodec/blob/master/cppcodec/detail/config.hpp and see it that makes a difference in performance?

If I'm doing it right, I think it should look like this:

#if __GNUC__ || __has_attribute(always_inline)
#define CPPCODEC_ALWAYS_INLINE inline __attribute__((always_inline))
#if defined(_MSC_VER) && !__INTEL_COMPILER && _MSC_VER >= 1310 // since Visual Studio .NET 2003
#define CPPCODEC_ALWAYS_INLINE inline __forceinline
#else
#define CPPCODEC_ALWAYS_INLINE inline
#endif

If you don't have the time then that's okay. Thanks anyway!

I released cppcodec v0.2, which significantly improves performance compared to the initially benchmarked version, in no small part thanks to the motivational boost from your measurements. It would be great if the numbers in this repo and on StackOverflow could reflect this change.

Thanks for your work and hopefully it's not too much to ask for an update :)

@gaspardpetit

Hello, I saw that you put my repository in your and would like to announce that I will complete this week and make it more faster under MSVC and Clang.
At the moment, I have a very good performance on my server b64encode() function, can you check on your devices?
Would like to suggest adding benchmarks for GCC.
I can also provide results on my server [email protected]

Repo here:
https://github.com/GermanAizek/picobase64