I just checked the code, at line 13 it contains a call to .done, that is not in the ES6 spec

Weird since the PR should had .then, as seen here

Tests passes?

When specifying a concurrency of 0, unexpected results happen. If passing 0, I'd expect an error to be thrown, or the function is not throttled.

Can you add more examples? The featured examples are not actually working examples and I don't know how to implement them.

I suggest something using setTimeout and console.log so you can just copy and paste and have a functioning implementation from the start.

Is your feature request related to a problem? Please describe.

During async iteration of e.g. a stream, I'd like to be able to signal the stream that the queue is full in order to stop pulling from it.

Describe the solution you'd like

E.g, the following code:

let myThroat = throat(5)
for await (let item of someStream) {
  await myThroat.enqueue(() => process(item))
}

wlll backpressure on pulling from the stream when there are 5 items in the queue already, until one of the items clear

Describe alternatives you've considered

I can't think of an alternative that doesn't somehow have access to the internal queue of throat. It might be possible to do this with standard node streams?

Additional context

N/A

The devDependency coveralls was updated from 3.0.2 to 3.0.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

coveralls is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

As io.js 1.x Promises are native into this runtime, so I hope you would lift the dependency.

throat could be required like this:

var throat = require('throat')(Promise);

// or in node 0.10.x
var throat = require('throat')(require('promise'));

There might be another (with more syntax sugar) versions of this, but this is the simpler that came to mind....

So you can delegate the Promise shim to the user.

edit: mmm... #2

Version 7.2.0 of promise just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As promise is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 2.5.3 of typescript just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As typescript is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

It's not a huge change, but it is a breaking one. Using any-promise as a defacto for Promise allows users to set the promise across a number of dependencies as once without customisation required for each. Would you be willing to accept a PR using https://www.npmjs.com/package/any-promise instead of taking a promise function?

Hey Forbes,

Very cool library! I was just curious as to why you used a thunk here: https://github.com/ForbesLindesay/throat/blob/master/index.js#L18 as opposed to a higher order function that executes resolve with the proper arguments.

Why this:

queue.push(new Delayed(resolve, fn, self, args))

instead of

queue.push(function () {
  resolve(run(fn, self, args));
});

And in https://github.com/ForbesLindesay/throat/blob/master/index.js#L26, you could then do:

      var next = queue.shift()
      next()

Not trying to bikeshed on syntax, just genuinely curious if I'm missing something.

Thanks in advance!

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Version 2.4.1 of typescript just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As typescript is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Describe the bug

Throat causes a halt in execution under certain conditions

To Reproduce

const _ = require('lodash');
const throat = require('throat');

async function main() {
  const worker = throat(4, async function (page) {});
  const pagesChunks = _.range(10).map((n) => _.range(100));

  let awaitCount = 0;
  for (const pagesChunk of pagesChunks) {
    console.log(`Await ${awaitCount++}`);
    await Promise.all(pagesChunk.map(worker));
  }

  console.log('Done');
}

main();

This outputs:

Await 0
Await 1
Await 2

Expected behaviour

Expected output:

Await 0
Await 1
Await 2
Await 3
Await 4
Await 5
Await 6
Await 7
Await 8
Await 9
Done

Versions

• node version: v14.17.5
• npm/yarn version: 6.14.14
• package version: throat-6.0.1

Additional context

Messing around with the length of pagesChunk or size can make the script complete normally, or halt earlier or later in the iterations.

not sure how this would work API-wise, but the idea is to return a promise somewhere that resolves then there is no longer any promises in the queue.

const fn = throat(3, myOtherFunction)

fn(1)
fn(2)
fn(3)
fn(4)

fn.flush().then(doSomethingElse())

it should resolve immediately if there are no more functions in the queue. flush should throw if any of the promises in the queue failed.

Is there a way to abort a promise that has already entered the throat queue?

Version 2.1.4 of testit just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As testit is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

This leads to errors that are really hard to detect.

You can see that we use throat in pnpm here and we did not add a catch to it. Throat was failing but even the unhandledRejection event was not happening because throat has a default error handler here.

According to NodeJS documentation

The 'rejectionHandled' event is emitted whenever a Promise has been rejected and an error handler was attached to it (using promise.catch(), for example) later than one turn of the Node.js event loop.

The expected behavior would be I think, that unhandledRejection event is fired when no error handler is added for throat outside of the throat source code

Related issue pnpm/pnpm#353

// Argument of type 'PromiseConstructor' is not assignable to parameter of type 'number'.
const throat = require('throat')(Promise);

cc/ @blakeembrey as typings/core is using this.

Hi,

Would you be open to a PR implementing the ability to throttle multiple functions with the same throat instance. Something like

myLimiter = throat(2);
lib.method1 = myLimiter.wrap(lib.method1)
lib.method2 = myLimiter.wrap(lib.method2)

The use case is where e.g. you use one method to read from a db, and another to write to it, but you want to place a limit on the total connections

Hi,
I work on a typescript project and I use throat module and it's work well, however when I create a lock and I call it with a function which take a argument my IDE say:
"Expected 1 arguments, but got 2."

Example:

const arg = "arg";
const lock = throat(1);
lock(func, arg);

To avoid this problem I added this line in "index.d.ts":

declare function throat(size: number): <TResult>(fn: (args?: any) => Promise<TResult>, args?: any) => Promise<TResult>;

Then I have no this problem anymore if I write like this:

const arg = "arg";
const lock = throat<void>(1);
lock(func, arg);

If you don't mind, can you add something like this?

Best regard

Hello, I'm building an upload queue and I'd like to know if it's possible to add more files after calling throat, e.g.:
`

let uploadedFiles = 0
const throat = require('throat')(10)

// uploadQueue initially has 20 files
for (const upload of uploadQueue) {
  throat(async () => {
    // logic for processing upload
    uploadedFiles++;
    console.log({ uploadedFiles, remainingFiles: uploadQueue.length - uploadedFiles })
  })
}

// add another file to the queue
uploadQueue.push(newUpload)

In the above example, I get { uploadedFiles: 20, remainingFiles: 1 } after the initial 20 files are processed and the queue never gets to the new upload. Is there any way to listen to changes in uploadQueue? Or do I have to call throat again every time I add more items to the queue?

Thanks in advance.

The devDependency promise was updated from 8.0.1 to 8.0.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

promise is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴