Fluids messed up with ic2 universal cell, compatibility issue with techreborn about ihl HOT 13 CLOSED

Has to reopen this issue, because this happens and only happens with both ihl and techreborn installed

from ihl.

That's cool. Only paper machine? Other machines are ok? Try it with chemical reactor and bronze tub.

from ihl.

Same for all fluid containers, including buildcraft and railcraft
For example shift rightclick a bc tank with any universal fluid cell will give Beryllium...and a empty bucket

from ihl.

@wormzjl it's definitely something like

if (FML.isModLoaded("ihl")) {
       this.fuckUpIC2UnivesalCells();
}

from ihl.

Mind take a look at this?
https://github.com/TechReborn/TechReborn/blob/1.7.10/src/main/java/techreborn/items/ItemCells.java#L28

I have no idea why putting both mod together would cause such a problem :P

from ihl.

@wormzjl as for IC2 universal fluid cells while drained dry they simple remove NBT tag of fluid from itself. There is no way this operation could change item ID (normally). Care to put cells into "Ore dictionary item scanner" to check if they are still IC2 ones? Also put a bucket and check item class of it as well.

from ihl.

yes they are

from ihl.

@wormzjl have no ideas then.

from ihl.

Don't know much about coding, but could these 2 conflict?
https://github.com/Foghrye4/ihl/blob/master/ihl/processing/invslots/InvSlotConsumableLiquidIHL.java#L37

https://github.com/TechReborn/TechReborn/blob/1.7.10/src/main/java/techreborn/items/ItemCells.java#L152

from ihl.

@wormzjl no. Bug could occur if universal cells registered as fluid container in FluidContainerRegistry, but this is not happened as long as I check in TechReborn.

from ihl.

Oops, there is something wrong with my tests

Apparently there is no problem draining these cells in railcraft tanks

Doing further testing...

from ihl.

Did some extensive testing with all fluid tanks I got

IHL machines:
Insert cell through GUI: bugged
Shift + rightclick with cell: Normal

IC2 fluid/solid canning machine:
Insert cell through GUI: bugged
Shift + rightclick with cell: Normal

Buildcraft tank:
Shift + rightclick with cell: bugged

Immersive engineering tank:
Shift + rightclick with cell: bugged

Raicraft tank and tankcart:
Insert cell through GUI: Normal
Shift + rightclick with cell: Normal

Advanced rocketry tank:
Insert cell through GUI: bugged
Shift + rightclick with cell: normal

Open blocks tank:
Shift + rightclick with cell: normal

Rotarycraft reservoir:
Shift + rightclick with cell: normal

Pressure pipes tank:
Insert cell through GUI: bugged

from ihl.

Bug on techreborn's side, thanks for looking through :D

from ihl.