Code Monkey home page Code Monkey logo

Comments (70)

Foghrye4 avatar Foghrye4 commented on June 17, 2024

I can't recreate that crash. Could you show me your setup?

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

It happens a bit random, probably by connecting ihl cable directly to ic2 cables

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

I still could not catch it. I added additional null check in grid calculation in 0.640. This should solve a case.
http://www.mediafire.com/file/hgqj9ekcyagh457/ihl-tools_n_machines-0.640-1.7.10.jar

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

ok thx!

from ihl.

yuyuyzl avatar yuyuyzl commented on June 17, 2024

Another stall happened in our server today, luckily we have recorded the stall log and an image of his wire connections.
ihlcablestall
And the stall log:
stall-2017-05-29_20.44.19.txt

Seems it would be a IHL&Uncomplication compatible problem.
And we're using Thermos.
Hoping this would help.

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

Seems to be a fatal flaw of using NBT object as grid cable representative. Fixing this would take some time.

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

Ok, try a new version (0.642), it should not cause stalls, because I get rid of NBT in energy net.

from ihl.

tony987852 avatar tony987852 commented on June 17, 2024

It happened again. We have already updated to the latest version.

Here is the stall log:
stall-2017-05-31_23.06.49-2.txt

Thanks.

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

I'm not sure in anything now, but I changed a code a little bit. Maybe this could help.
http://www.mediafire.com/file/5dx5ff93rmq152c/ihl-tools_n_machines-0.0.643-1.7.10.jar
BTW how complex is grid? Do it contain a circles?*


  • that's should be absolutely safe.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

It quiet simple, just power source -> electrolysis bath with length less than 2

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

private IEnergyNetNode getHasCable(NBTTagCompound cable, IEnergyNetNode exclude)

Can you add some sort of size limit & debug warning on this hashmap? Might help pinpointing the issue
Also is it possible to print the location of bugged cable?

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl I removed that hashmap. Source updated, check by yourself.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

ok will test

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl ...no. Does it stall?

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Nvm, still testing
Just have a probable cause for the issue coming up in mind.
Thermos/ spigot "deactivates" entities if they are some distance away from players, will this cause issue with the cables?
Also if the nbt is not saved properly on chunk unload, on chunk reload will it crash like this?

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl entities does not involved in enegy transfer unless they are touch ground and uninsulated or voltage in cable above insulation breakdown voltage. In that case they emit smoke particles.
Each time chunk containing energy node unloaded ... wait... I think I found a possible case. When TE is in uloaded chunk it is invalidated and removed from all lists. But in my case it is remains in grid TE list. So, when chunk is loaded again it will generate new instance of TE, which will be added to grid alongside with old invalid instance of TE.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

So boom?

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

Ok, try this: http://www.mediafire.com/file/taojc7ubcicbyke/ihl-tools_n_machines-0.644-1.7.10.jar
Also check fractionator column.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

https://pastebin.com/PSijj7ht
crashed by linking an electrolysis bath with a mfe

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

Unexpected.
Well this version does not crash: http://www.mediafire.com/file/gw2fbm0yl7j7o5y/ihl-tools_n_machines-0.645-1.7.10.jar
(and as well does not work with uncomplication mod (energy not transferred after first packet))

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Some weirdness in the enet?

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl probably demanded energy >0d but <1d bug.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Seems that when the electrolysis bath finishes it's work, it refuses to work again unless the cable is reconnected

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

For a freaking hour I tried one to another options to fix that. Screw it. Ok, IHL officially incompatible with Uncomplication mod until a further notice.

Maybe I should make electrolyzer to support work with normal cables?

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

That will lose some...identity

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl I took my will into fist and found a lot of bugs related to flexible cable energy transfer system (0.646). I did not test fixes with uncomplication, but it was not an uncomplication related bugs at a first place. You may want to check a work with uncomplication now, and I need to sleep.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Thank you very much! gonna do some more testing

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Ok, the power transfer from/to ic2 energy block is fine.
But it seems that the electrolysis bath is not receiving any power?
Also before you can attach wire to desired block face by simple shift + rightclick, but now you need to stand right before that side

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

But it seems that the electrolysis bath is not receiving any power?

Is recipe conditions are fulfilled? Because everything fine at my side (even with uncomplication mod). Try this: launch Minecraft with opened console. Right-click at electrolysis bath with thermometer (from IHL creative inventory). Copy-paste 4 lower lines of console output here. Do a same thing with opposite side of cable connected (there should be invisible but clickable "junction box").

Also before you can attach wire to desired block face by simple shift + rightclick, but now you need to stand right before that side

O.O I did not change anything related to this part of code. At least as I remember.

from ihl.

yuyuyzl avatar yuyuyzl commented on June 17, 2024

Also before you can attach wire to desired block face by simple shift + rightclick, but now you need to stand right before that side

That's true. I have not read your code but in game you should stand at the face you want to put wire and click or your wire will connect to other faces.

Because everything fine at my side (even with uncomplication mod).

And i'm sorry about my misleading to uncomplication. IC+IHL+Uncomplication works fine, The problem is Immersive engineering use a strange way to feed energy to IC capacitors, which causes the problem i've mentioned before. An IE->IC->IHL wire connection will cause the problem, but IE->IC->IC->IHL wire works fine.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

[19:34:03] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:104]: gridId=7
[19:34:03] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:106]: grid energy=0.0
[19:34:03] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:107]: getEnergyAmountThisNodeWant()=32000.0
[19:34:04] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:104]: gridId=7
[19:34:04] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:106]: grid energy=0.0
[19:34:04] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:107]: getEnergyAmountThisNodeWant()=32000.0
[19:34:05] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:104]: gridId=7
[19:34:05] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:106]: grid energy=0.0
[19:34:05] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:107]: getEnergyAmountThisNodeWant()=32000.0

The recipe works normally before update

setup
image

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

getEnergyAmountThisNodeWant()=32000.0

32000 at both sides?
This value show amount of energy which can consume node when energy injected in net.
400*400/5 - is basic value before grid update for electrolisis bath. So everything fine here.
Please check opposite side (invisible junction box). There will be a small black box when you point tool to an end of cable.
http://imgur.com/a/bgJk1

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

[20:09:51] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:88]: demanded=0.0
[20:09:51] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:104]: gridId=1
[20:09:51] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:106]: grid energy=0.0
[20:09:51] [Server thread/INFO] [STDOUT/]: [ihl.items_blocks.IHLTool:func_77659_a:107]: getEnergyAmountThisNodeWant()=0.0

This is on the side of the MFE

image

and the wire I'm using
image

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

Weird. Different grid ids... (id=1 at MFE side and id=7 at electrolysis bath side). Is it bug persistent? If you remove a cable and reconnect devices together again it will be a same?

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

it's the same all the time

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl send me your world and modpack.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

https://mega.nz/#!fcRGRCwC!MA62EeTdt_yY18IVzBUyDY6AVMF4sedyKcYnVOZzztY
You can import it via multimc

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl it's a DragonAPI. Have no idea what it do, but everything works fine without it.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

why it no longer works after the fix...this is really weird-

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl A thing I fixed - "junction box" sending energy back to source if it is a sink as well (all energy storage devices are both sink and sources). If it is a second node in grid - everything work fine. If it is first - energy does not go further. I added condition to junction box to send energy to attached device only if this device allow input from box side.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Seems that the cable orientation issue starts from 645...still checking

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

If the machines and wire were placed before adding dragonapi, everything works properly...investigating

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

Damn. It seems you founded it. If DragonAPI use ASM to add that interface with provided functions into all IC2 energy tiles, this could cause collision with my own function result. And it seems DragonAPI just catch exceptions caused by this mess silently.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

No this is probably not the issue so I deleted it, still investigating

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Ok this has nothing to do with dragonapi
Ihl cables only conducts power when energy source is facing east, you might want to have a look at the side checks

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

You mean that energy source transfer energy to flexible cables only if it facing east? Why everything works fine without DragonAPI then?

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

yeah, tested without DragonAPI, no power emit when it's not facing east even with MFE->MFE connection, nothing to do with the electrolysis bath

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

Ooops. My bad.

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

What about now?
http://www.mediafire.com/file/zq5pffyh311hibo/ihl-tools_n_machines-0.647-1.7.10.jar

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

thx, doing some live testing

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

no problem occurred yet, seems to be solved

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Crashing again...gonna post them later

from ihl.

tony987852 avatar tony987852 commented on June 17, 2024

New bug:
When cable overload, it will crash the server.
I also wonder why it did not happen before today that using the same cable and the same energy network.

I tried 3 times.
crash-2017-07-06_10.02.03-server.txt
crash-2017-07-06_10.20.48-server.txt
crash-2017-07-06_10.31.45-server.txt

Thanks.

from ihl.

tony987852 avatar tony987852 commented on June 17, 2024

The stall happened again. I don't know which player is using the cable.

stall-2017-07-06_21.18.46.txt
stall-2017-07-06_19.39.39.txt

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

I wonder how that is happened. I add a code to prevent crash in 0.650 and it will generate some log output while removing corrupted tile-entities. I would like to see that log. As for stalls - if they happened again I would like to see log output as well.

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl is latest version of IHL fix issue?

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Been able to crash it on singleplayer, put down a MFE, connect it to a MV transformer then a diamond cable, then ihl cable -> electrolysis bath. Crash seems to happen on cable meltdown.
crash-2017-07-08_16.22.51-server.txt
fml-client-3.txt

Also got another bug, seems that the length of cable used is calculated by player move distance?
If I do not move during cable placement, the length will be 0

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

ihl-tools_n_machines-0.648-1.7.10.jar
Umm you have updated to 650? did anything change related to the cable?
Going to test with the latest

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

@wormzjl yes. I added a code, which should remove nodes with ID == -1 from grid and generate some log output.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Ok, can you take a look at the cable length issue mentioned above?

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Got the same result.....
fml-server-3.txt

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

Damn, I forgot to add a one more line.

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

http://www.mediafire.com/file/6565zoj5and4sna/ihl-tools_n_machines-0.651-1.7.10.jar
Ok, it should work now.

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

[17:05:27] [Server thread/ERROR] [ihl/]: Removing TE with grid ID==-1 ihl.processing.chemistry.ElectrolysisBathTileEntity If it happened more than a single time, report that to mod author.
[17:05:27] [Server thread/WARN] [Uncomplication/]: EnergyNet.emitEnergyFrom: ihl.flexible_cable.AnchorTileEntity@2d2179 is not added to the enet
[17:05:40] [Server thread/ERROR] [ihl/]: Removing TE with grid ID==-1 ihl.processing.chemistry.ElectrolysisBathTileEntity If it happened more than a single time, report that to mod author.
[17:05:40] [Server thread/WARN] [Uncomplication/]: EnergyNet.emitEnergyFrom: ihl.flexible_cable.AnchorTileEntity@2d2179 is not added to the enet
[17:05:53] [Server thread/ERROR] [ihl/]: Removing TE with grid ID==-1 ihl.processing.chemistry.ElectrolysisBathTileEntity If it happened more than a single time, report that to mod author.
[17:05:53] [Server thread/WARN] [Uncomplication/]: EnergyNet.emitEnergyFrom: ihl.flexible_cable.AnchorTileEntity@2d2179 is not added to the enet
[17:05:59] [Server thread/ERROR] [ihl/]: Removing TE with grid ID==-1 ihl.processing.chemistry.ElectrolysisBathTileEntity If it happened more than a single time, report that to mod author.
[17:05:59] [Server thread/WARN] [Uncomplication/]: EnergyNet.emitEnergyFrom: ihl.flexible_cable.AnchorTileEntity@2d2179 is not added to the enet

Got these in the console

Screenshot, the cable can be actually burned
1

2

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

So happen every time on cable burnout?

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

Nope, seems to happen only on certain setups

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

image

Seems somewhat related to direction, the one on the left will not give error on burnout, the one on the right will

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

image
Also...the cable length bug

from ihl.

wormzjl avatar wormzjl commented on June 17, 2024

This is too difficult to replicate, maybe just let the electrolysis bath accept EU directly (from the upper side)

from ihl.

Foghrye4 avatar Foghrye4 commented on June 17, 2024

http://www.mediafire.com/file/5ojxiv8p9h3tgk3/ihl-tools_n_machines-0.652-1.7.10.jar

from ihl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.