Comments (5)
Some tests:
Let alpha := beta := 1.0
.
Test # 1: A is rectangular, C is square.
Let A be a 3x5 matrix:
2 9 1 5 0
2 2 7 3 8
3 1 3 8 5
Let B be a 5x3 matrix:
9 2 4
9 3 8
2 8 0
4 3 9
6 3 1
Let C be a 3x3 matrix:
8 2 6
8 1 2
5 9 4
Then the correct answer would be:
129 2 6
118 100 2
109 81 101
Result of gemmlnn:
129 2 6
118 100 2
109 81 101
Result of dgemmlnn:
129 2 6
118 100 2
109 81 101
Result of zgemmlnn:
129 2 6
118 100 2
109 81 101
So, it works with rectangular A, this contradicts documentation.
Test # 2: A is square, C is rectangular.
Let A be a 5x5 matrix:
0 5 0 9 9
5 9 3 7 8
6 8 4 9 1
7 7 3 7 2
7 5 7 3 6
Let B be a 5x4 matrix:
3 4 7 5
9 0 1 2
0 0 4 5
4 6 5 9
8 9 2 3
Let C be a 5x4 matrix:
4 4 3 8
2 9 7 5
0 7 8 8
8 6 6 9
0 7 9 7
Then the correct answer would be:
157 4 3 8
190 143 7 5
134 94 121 8
136 94 113 142
126 107 118 132
Result of gemmlnn:
libblis: frame/3/bli_l3_check.c (line 84):
libblis: Expected square object.
libblis: Aborting.
./jconsole.sh: line 6: 5834 Core dumped
Result of dgemmlnn:
157 4 3 8
190 143 7 5
134 94 121 8
136 94 113 142
0 7 9 7
Result of zgemmlnn
157 4 3 8
190 143 7 5
134 94 121 8
136 94 113 142
0 7 9 7
So, the result is incorrect.
from blis.
@jip can you please send a minimal working example of the failure in test # 2? Also, what is gemmlnn
? If the call goes through bli_trmm3
then it should perform checks via bli_trmm3_check
which only checks that A
is square, rather than bli_gemmt_check
which is where your error occurs (line 84).
from blis.
Also, which version of BLIS are you using (release or git commit ID)?
from blis.
Yeah, I don't see where the problem would be in master
.
from blis.
@devinamatthews and @fgvanzee I'm sorry for the noise, you are right: I messed up bli_gemmt
with bli_trmm3
. gemmlnn
is my wrapper for bli_gemmt
on another language using lower C triangle and non-transposed A and B.
Just for the record: my libblis.so.4.0.0 has version 0.9.0-91 and was build for haswell 2023-03-20.
from blis.
Related Issues (20)
- Header path for default source build and Debian should match HOT 6
- bli_gemmsup_rd_haswell_asm_d6x8m.c:1296:1:error:bp cannot be used in ams here HOT 3
- New release? HOT 6
- A more complete list of ARM cpu implementations
- arm64 cpu identification is not portable to BSDs HOT 3
- What is the best way to debug BLIS? HOT 2
- GPU support and PortBLAS HOT 4
- getting error as illegal instruction HOT 4
- Support compiler names with spaces HOT 1
- Regarding Default Behaviour for CPU Affinity HOT 4
- BF16 on AMD CPU? HOT 4
- Upstream BLIS patches for ARM SVE? HOT 5
- Memory location in the prefetch instructions HOT 5
- Facing issue when running following command: pip install --upgrade --no-cache-dir thinc HOT 1
- AMD FX(tm)-6300 Six-Core Processor piledriver errors with check HOT 4
- errors with scalapack due to [cz]symv and [cz]syr interfaces HOT 10
- Not possible to link Blis and Lapack statically into the same executable HOT 12
- Follow up on https://github.com/flame/blis/issues/811, remaining error in out.zblat3.txt after applying fix #814 HOT 4
- LAPACK test segfault on zen/zen2/zen3 at bli_sgemmsup_rd_haswell_asm_1x16n HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blis.