How to cross-compile libraries for use on Android? about blis HOT 14 CLOSED

"Librt and Libpthread are included in Bionic lib, which substitutes GLibC in Android, so just remove -pthread (or -lpthread -lrt) flags from your Makefiles" (ref)

from blis.

from blis.

I'm willing to write a PR for this issue this evening.

from blis.

Thanks @leekillough

from blis.

thanks

it's work when comment out https://github.com/flame/blis/blob/a0b04e3c007f1207e5678bf20c07752906742fb7/common.mk#L970C4-L970C4
and

from blis.

@leekillough is there an easy way to check for Bionic in configure?

from blis.

@devinamatthews SO to the rescue

You can see an example in configure of testing preprocessor macros, for example, here.

from blis.

@devinamatthews and I talked about formally supporting this. I'm thinking maybe a --enable-android option?

from blis.

Actually, I can't seem to convince myself that -lpthread is ever needed on line 913 since pthreads is included in the link command by default (via line 579). 🤔

from blis.

I prefer the autodetection option: #ifdef __BIONIC__. A separate explicit option to force it is fine, but the default autodetection should detect Bionic.

It shouldn't be too hard. RISC-V already autodetects using preprocessor macros.

from blis.

@leekillough Just to clarify, you're referring to trying to build a dummy .c file that contains #ifdef __BIONIC__ and branching within configure based on the result of that compilation attempt?

from blis.

I am saying that, just like in RISC-V, it is possible to detect properties in the build environment with preprocessor macros.

A .h or similar file can be "preprocessed" and produce an output based on macros, which can then be parsed or grep'ed for a certain output.

Bionic seems to be an easy property to detect through preprocessor macros.

With cc -E or similar, a source file dependent on Bionic macros can be tested. The source file would have things like #ifdef __BIONIC_ in it, and would output source code dependent on the presence of the macro (whether defined or not).

It is possible to parse the preprocessor output without having to fully compile the source. Please see the RISC-V autodetection code as an example.

from blis.

See the RISC-V autodetection code for examples

from blis.

Thanks for clarifying, @leekillough. Could you share a link to the RISC-V autodetection code?

from blis.